Skip to content

Commit 23062f1

Browse files
committed
Add support for version numbers with a v prefix
1 parent 0ace37b commit 23062f1

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/util/version.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ describe('Parse', () => {
44
test.each([
55
['1', '1'],
66
['1.0', '1.0'],
7+
['v1.0', '1.0'],
78
['1.0-beta', '1.0-beta'],
89
['1.10.3', '1.10.3'],
910
['1.10.3.4', '1.10.3.4'],
@@ -23,6 +24,7 @@ describe('Parse', () => {
2324
['0x1'],
2425
['.1'],
2526
['0.1..'],
27+
['b0.1'],
2628
['1.10.3.5.alpha'],
2729
])('should fail to parse version %s', (versionNumber) => {
2830
expect(() => {
@@ -36,6 +38,8 @@ describe('Compare', () => {
3638
test.each([
3739
['1', '1', 0],
3840
['1.0', '1', 0],
41+
['v1.0', '1', 0],
42+
['v1.0', '1.0', 0],
3943
['1.01-beta', '1.1-beta', 0],
4044
['1.1', '1.1-beta', -1],
4145
['1.10', '1.10.3', -1],

src/util/version.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
const VersionExpression = /^(\d)+(\.(\d+))?(\.(\d+))?(\.(\d+))?(-([\w][\w.-]*))?$/;
1+
const VersionExpression = /^v?(\d)+(\.(\d+))?(\.(\d+))?(\.(\d+))?(-([\w][\w.-]*))?$/;
22

33
export default class Version {
44
readonly major: number;

0 commit comments

Comments
 (0)