Price conversion NOT working no matter what on testnet

[rileymross]

I'm on lesson 4 and I am completely losing it over here.

I just want the fund button to be able to know whether I'm sending the contract an amount of Wei that's worth at least $50.

Every time I deploy the contract on the rinkby testnet it works but then every time I try to went after calculating the right about of wei based on the current USD value of ETH, it says an error and it does nothing, even when I do the amount that would be $50 worth or even more. What the hell am I doing wrong? Here is my script:

// SPDX-License-Identifier: MIT

//get funds from people
//withdraw funds
//set minimum usd value thanks to LINK

pragma solidity ^0.8.8;

import "@chainlink/contracts/src/v0.8/interfaces/AggregatorV3Interface.sol";

contract FundMe {

uint256 public minimumUsd = 50*1e18;

address[] public funders;
mapping(address => uint256) public addressToAmountFunded;

function fund() public payable{
    require(getConversionRate(msg.value) >= minimumUsd, "Sent a amount!?"); // 1e18=10*18=1000000000000000000 - measured in terms of wei
    funders.push(msg.sender);
    addressToAmountFunded[msg.sender] = msg.value;
}

function getPrice() public view returns(uint256) {
    AggregatorV3Interface priceFeed = AggregatorV3Interface(0x5f4eC3Df9cbd43714FE2740f5E3616155c5b8419);
    (,int256 price,,,) = priceFeed.latestRoundData();
    return uint256(price * 1e10); // 1**10 = 8 zeros
    //ETH in terms of current usd. 8 decimals in price feed
}

function getVersion() public view returns (uint256) {
    AggregatorV3Interface priceFeed = AggregatorV3Interface(0x5f4eC3Df9cbd43714FE2740f5E3616155c5b8419);
    return priceFeed.version();
}

function getConversionRate(uint256 ethAmount) public view returns (uint256) {
    uint256 ethPrice = getPrice();
    uint256 ethAmountInUsd = (ethPrice * ethAmount) / 1e18;
    return ethAmountInUsd;
}
//function withdraw(){}

}

[LordReya]

Let me help you, bro. Did you check if you have enough funds in your wallet first? If that's the case then you should change your payable function. It seems incorrect:

function fund() public payable {
        require(msg.value.getConversionRate() >= MINIMUM_USD, "You need to spend more ETH!");
        //  you can also use: "require(PriceConverter.getConversionRate(msg.value) >= MINIMUM_USD, "You need to spend more ETH!");" if you have already made it to the priceconverter section in the video. 

        addressToAmountFunded[msg.sender] += msg.value;
        funders.push(msg.sender);

Let me know if it helps 👍

[rileymross]

I double checked that. But it looks like the problem was that I used the wrong contract address for the ETH/USD. On Rinkeby it's this:
0x8A753747A1Fa494EC906cE90E9f37563A8AF630e

[alymurtazamemon]

@rileymross

for ETH/USD on Rinkeby aggregator interface address is this => 0x8A753747A1Fa494EC906cE90E9f37563A8AF630e.

Which address are you using?

[rileymross]

It worked after I changed the contract address to that. Thank you! I think I picked up the address for the ones under the real ETH network, or a different testnet. Now it makes sense.