Skip to content

Commit 5a9f5ca

Browse files
author
Gonzalo Diaz
committed
[REFACTOR] [CodeFactor] Apply fixes
1 parent c92f379 commit 5a9f5ca

File tree

2 files changed

+18
-16
lines changed
  • src
    • algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps
    • algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps

2 files changed

+18
-16
lines changed

src/algorithm_exercises_csharp/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/FrequencyQueries.cs

+3-7
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@ namespace algorithm_exercises_csharp.hackerrank.interview_preparation_kit.dictio
77

88
public class FrequencyQueries
99
{
10-
private FrequencyQueries()
11-
{
12-
}
10+
[ExcludeFromCodeCoverage]
11+
private FrequencyQueries() { }
1312

1413
private static readonly long __INITIAL__ = 1L;
1514

@@ -20,8 +19,6 @@ private FrequencyQueries()
2019
private static readonly int __NOT_FOUND__ = 0;
2120
private static readonly int __FOUND__ = 1;
2221

23-
private const string OPERATION_ERROR = "Operation %d not supported";
24-
2522
readonly Dictionary<long, long> valueFreqs = [];
2623
readonly Dictionary<long, List<long>> freqDictionary = [];
2724
List<int> result = [];
@@ -145,8 +142,7 @@ public static List<int> freqQuery(List<List<int>> queries)
145142
fq.select(value);
146143
break;
147144
default:
148-
throw new InvalidOperationException(
149-
String.Format(OPERATION_ERROR, operation));
145+
throw new InvalidOperationException($"Operation {operation} not supported");
150146
}
151147
}
152148

src/algorithm_exercises_csharp_test/hackerrank/interview_preparation_kit/dictionaries_and_hashmaps/FrequencyQueries.Test.cs

+15-9
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,11 @@ public void testFrequencyQueries()
4545
foreach (FrequencyQueriesTestCase test in testCases)
4646
{
4747
solutionFound = FrequencyQueries.freqQuery(test.input);
48-
CollectionAssert.AreEqual(test.expected, solutionFound);
48+
CollectionAssert.AreEqual(
49+
test.expected,
50+
solutionFound,
51+
$"FrequencyQueries.freqQuery({test.input}) answer must be: {test.expected}"
52+
);
4953
}
5054
}
5155

@@ -57,10 +61,11 @@ public void testFrequencyQueriesBigCases()
5761
foreach (FrequencyQueriesTestCase test in testCase6)
5862
{
5963
solutionFound = FrequencyQueries.freqQuery(test.input);
60-
CollectionAssert.AreEqual(test.expected, solutionFound, String.Format("%s(%s) answer must be: %s" +
61-
"FrequencyQueriesTest.freqQuery",
62-
test.input.ToString(),
63-
test.expected.ToString()));
64+
CollectionAssert.AreEqual(
65+
test.expected,
66+
solutionFound,
67+
$"FrequencyQueries.freqQuery({test.input}) answer must be: {test.expected}"
68+
);
6469
}
6570
}
6671

@@ -72,10 +77,11 @@ public void testFrequencyQueriesBorderCases()
7277
foreach (FrequencyQueriesTestCase test in testCaseBorderCases)
7378
{
7479
solutionFound = FrequencyQueries.freqQuery(test.input);
75-
CollectionAssert.AreEqual(test.expected, solutionFound, String.Format("%s(%s) answer must be: %s" +
76-
"FrequencyQueriesTest.freqQuery",
77-
test.input.ToString(),
78-
test.expected.ToString()));
80+
CollectionAssert.AreEqual(
81+
test.expected,
82+
solutionFound,
83+
$"FrequencyQueries.freqQuery({test.input}) answer must be: {test.expected}"
84+
);
7985
}
8086
}
8187

0 commit comments

Comments
 (0)