Various updates incl node, gems (#461)

* Update versions
* configure travis like react_on_rails
* Removed capybara-webkit
* Removed poltergeist
* Updated Ruby version
* Update React on Rails
* Update node version

Author: justin808

.nvmrc

@@ -1 +1 @@
-7.8.0
+11

.ruby-version

@@ -1 +1 @@
-ruby-2.4.1
+ruby-2.5.3

.travis.yml

@@ -1,44 +1,62 @@
-language:
-  - ruby
+language: ruby
+
 rvm:
-  - 2.4.1
-sudo: true
+  - 2.5.3
+
+services:
+  - docker
+
 notifications:
   slack: shakacode:YvfXbuFMcFAHt6ZjABIs0KET
-addons:
-  apt:
-    sources:
-      - ubuntu-toolchain-r-test
-    packages:
-      - g++-4.9
-services:
-  - postgresql
+
+cache:
+  bundler: true
+  directories:
+    - node_modules # NPM packages
+  yarn: true
+
+gemfile: Gemfile
+
+#addons:
+#  apt:
+#    sources:
+#      - ubuntu-toolchain-r-test
+#    packages:
+#      - g++-4.9
+#  chrome: beta
+
 env:
   global:
     - RAILS_ENV=test
-    - CXX=g++-4.9
-install:
-  - bundle install
-  - chromedriver-update
-  - wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
-  - sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
+    - DRIVER=selenium_chrome
+    - CHROME_BIN=/usr/bin/google-chrome
+    - USE_COVERALLS=TRUE
+
+before_install:
   - sudo apt-get update
-  - sudo apt-get install google-chrome-stable
-  - nvm install stable && nvm alias default stable
-  - npm install -g npm@5.6.x
-  - npm install -g yarn
-  - node --version
-  - npm --version
+  - sudo apt-get install -y xvfb libappindicator1 fonts-liberation
+  - wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
+  - sudo dpkg -i google-chrome*.deb
+  - "/sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen scn 1600x1200x16"
+
+install:
+  - travis_retry gem install bundler -v '<2' # Ruby 2.2 and Rails 3.2 & 4.2 depend on bundler 1.x.
+  - travis_retry nvm install 11.7.0
+  - node -v
+  - travis_retry npm i -g yarn
+  - travis_retry bundle install
+  - travis_retry yarn
+  - bundle
+  - yarn
   - google-chrome --version
-  - chromedriver --version
-  - yarn install
+
+  # Temp set chromediver to version matching chrome 73
+  #- chromedriver-update 73.0.3683.68
+  #- chromedriver --version
   - rake db:setup
 
-# Tip: No need to run xvfb if running headless testing. However, we're going to start with
-# Poltergeist and switch to selenium if a test fails.
 before_script:
-   - export DISPLAY=:99.0
-   - sh -e /etc/init.d/xvfb start
+  - "export DISPLAY=:99"
 
 script:
   - bundle exec rake db:schema:load

Gemfile

@@ -1,7 +1,7 @@
 source "https://rubygems.org"
-ruby "2.4.1"
+ruby "2.5.3"
 
-gem "react_on_rails", "11.0.7"
+gem "react_on_rails", "11.2.2"
 gem "webpacker"
 
 # Bundle edge Rails instead: gem "rails", github: "rails/rails"
@@ -94,13 +94,11 @@ end
 group :test do
   gem "capybara", "2.18.0"
   gem "capybara-screenshot"
-  gem "capybara-webkit"
   gem "chromedriver-helper"
   gem "coveralls", require: false
   gem "database_cleaner"
   gem "generator_spec"
   gem "launchy"
-  gem "poltergeist"
   gem "rails_best_practices"
   gem "rspec-rails", "3.7.2"
   gem "selenium-webdriver"

Gemfile.lock

@@ -44,7 +44,7 @@ GEM
       tzinfo (~> 1.1)
     addressable (2.5.2)
       public_suffix (>= 2.0.2, < 4.0)
-    archive-zip (0.11.0)
+    archive-zip (0.12.0)
       io-like (~> 0.3.0)
     arel (9.0.0)
     ast (2.4.0)
@@ -70,15 +70,11 @@ GEM
     capybara-screenshot (1.0.21)
       capybara (>= 1.0, < 4)
       launchy
-    capybara-webkit (1.15.0)
-      capybara (>= 2.3, < 4.0)
-      json
     childprocess (0.9.0)
       ffi (~> 1.0, >= 1.0.11)
-    chromedriver-helper (1.2.0)
+    chromedriver-helper (2.1.0)
       archive-zip (~> 0.10)
       nokogiri (~> 1.8)
-    cliver (0.3.2)
     code_analyzer (0.4.8)
       sexp_processor
     coderay (1.1.2)
@@ -90,7 +86,7 @@ GEM
       execjs
     coffee-script-source (1.12.2)
     concurrent-ruby (1.0.5)
-    connection_pool (2.2.1)
+    connection_pool (2.2.2)
     coveralls (0.8.21)
       json (>= 1.8, < 3)
       simplecov (~> 0.14.1)
@@ -128,7 +124,7 @@ GEM
     json (2.1.0)
     launchy (2.4.3)
       addressable (~> 2.3)
-    libv8 (6.3.292.48.1)
+    libv8 (6.7.288.46.1)
     listen (3.1.5)
       rb-fsevent (~> 0.9, >= 0.9.4)
       rb-inotify (~> 0.9, >= 0.9.7)
@@ -143,22 +139,18 @@ GEM
     method_source (0.9.0)
     mimemagic (0.3.2)
     mini_mime (1.0.0)
-    mini_portile2 (2.3.0)
-    mini_racer (0.1.15)
-      libv8 (~> 6.3)
+    mini_portile2 (2.4.0)
+    mini_racer (0.2.4)
+      libv8 (>= 6.3)
     minitest (5.11.3)
     multi_json (1.13.1)
     nio4r (2.3.1)
-    nokogiri (1.8.2)
-      mini_portile2 (~> 2.3.0)
+    nokogiri (1.10.1)
+      mini_portile2 (~> 2.4.0)
     parallel (1.12.1)
     parser (2.5.1.0)
       ast (~> 2.4.0)
     pg (1.0.0)
-    poltergeist (1.18.0)
-      capybara (>= 2.1, < 4)
-      cliver (~> 0.3.1)
-      websocket-driver (>= 0.2.0)
     powerpack (0.1.1)
     pry (0.11.3)
       coderay (~> 1.1.0)
@@ -222,7 +214,7 @@ GEM
     rb-inotify (0.9.10)
       ffi (>= 0.5.0, < 2)
     rdoc (6.0.4)
-    react_on_rails (11.0.7)
+    react_on_rails (11.2.2)
       addressable
       connection_pool
       execjs (~> 2.5)
@@ -334,7 +326,6 @@ DEPENDENCIES
   bundler-audit
   capybara (= 2.18.0)
   capybara-screenshot
-  capybara-webkit
   chromedriver-helper
   coffee-rails
   coveralls
@@ -347,7 +338,6 @@ DEPENDENCIES
   listen
   mini_racer
   pg
-  poltergeist
   pry
   pry-byebug
   pry-doc
@@ -359,7 +349,7 @@ DEPENDENCIES
   rails-html-sanitizer
   rails_best_practices
   rainbow
-  react_on_rails (= 11.0.7)
+  react_on_rails (= 11.2.2)
   redis (= 3.3.3)
   rspec-rails (= 3.7.2)
   rubocop
@@ -375,7 +365,7 @@ DEPENDENCIES
   webpacker
 
 RUBY VERSION
-   ruby 2.4.1p111
+   ruby 2.5.3p105
 
 BUNDLED WITH
-   1.16.0
+   1.16.6

README.md

@@ -140,7 +140,6 @@ See package.json and Gemfile for versions
 1. Check that you have Ruby 2.3.0 or greater
 1. Check that you're using the right version of node. Run `nvm list` to check. Use 5.5 or greater.
 1. Check that you have Postgres installed. Run `which postgres` to check. Use 9.4 or greater.
-1. Check that you have `qmake` installed. Run `which qmake` to check. If missing, follow these instructions: [Installing Qt and compiling capybara-webkit](https://github.com/thoughtbot/capybara-webkit/wiki/Installing-Qt-and-compiling-capybara-webkit)
 1. Check that you have Redis installed. Run `which redis-server` to check. If missing and on MacOS, install with Homebrew (`brew install redis`)
 1. `bundle install`
 1. `brew install yarn`

client/package.json

@@ -5,7 +5,6 @@
   "main": "server-express.js",
   "engines": {
     "node": "^7.8.0 || ^8.0.0 || ^9.2.0 || ^10.0.0 || ^11.0.0",
-    "npm": "^4.4.4 || ^5.0.0",
     "yarn": "^1.0.0"
   },
   "repository": {
@@ -82,7 +81,7 @@
     "react-bootstrap": "^0.31.5",
     "react-dom": "^16.1.1",
     "react-intl": "^2.4.0",
-    "react-on-rails": "11.0.7",
+    "react-on-rails": "11.2.2",
     "react-redux": "^5.0.6",
     "react-router": "^4.2.0",
     "react-router-dom": "^4.2.2",

client/yarn.lock

@@ -38,6 +38,14 @@
     esutils "^2.0.2"
     js-tokens "^4.0.0"
 
+"@babel/runtime-corejs2@^7.0.0":
+  version "7.3.4"
+  resolved "https://registry.yarnpkg.com/@babel/runtime-corejs2/-/runtime-corejs2-7.3.4.tgz#63f8bbc77622da202e9ea6f8f6e3bf28991832d9"
+  integrity sha512-QwPuQE65kNxjsNKk34Rfgen2R5fk0J2So99SD45uXBp34QOfyz11SqVgJ4xvyCpnCIieSQ0X0hSSc9z/ymlJJw==
+  dependencies:
+    core-js "^2.5.7"
+    regenerator-runtime "^0.12.0"
+
 "@babel/template@7.0.0-beta.32":
   version "7.0.0-beta.32"
   resolved "https://registry.yarnpkg.com/@babel/template/-/template-7.0.0-beta.32.tgz#e1d9fdbd2a7bcf128f2f920744a67dab18072495"
@@ -1941,6 +1949,11 @@ core-js@^2.4.0, core-js@^2.5.0:
   version "2.5.1"
   resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.5.1.tgz#ae6874dc66937789b80754ff5428df66819ca50b"
 
+core-js@^2.5.7:
+  version "2.6.5"
+  resolved "https://registry.yarnpkg.com/core-js/-/core-js-2.6.5.tgz#44bc8d249e7fb2ff5d00e0341a7ffb94fbf67895"
+  integrity sha512-klh/kDpwX8hryYL14M9w/xei6vrv6sE8gTHDG7/T/+SEovB/G4ejwcfE/CBzO6Edsu+OETZMZ3wcX/EjUkrl5A==
+
 core-util-is@1.0.2, core-util-is@~1.0.0:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/core-util-is/-/core-util-is-1.0.2.tgz#b5fd54220aa2bc5ab57aab7140c940754503c1a7"
@@ -6402,9 +6415,12 @@ react-intl@^2.4.0:
     intl-relativeformat "^2.0.0"
     invariant "^2.1.1"
 
-react-on-rails@11.0.7:
-  version "11.0.7"
-  resolved "https://registry.yarnpkg.com/react-on-rails/-/react-on-rails-11.0.7.tgz#6a938d4928f594f65aac1cb386b6142f44c313bf"
+react-on-rails@11.2.2:
+  version "11.2.2"
+  resolved "https://registry.yarnpkg.com/react-on-rails/-/react-on-rails-11.2.2.tgz#e5cc062e41832f548d9d40dfc2aebd586b932f95"
+  integrity sha512-ZTS69giZDxVxwnraFNKujHpzK9GO5be+ISyGw5v3rKs4VlLKJ7BTVDtT22Fn0iEMe6x817s/cwGwepkAEEwA9A==
+  dependencies:
+    "@babel/runtime-corejs2" "^7.0.0"
 
 react-overlays@^0.7.4:
   version "0.7.4"
@@ -6590,9 +6606,10 @@ regenerator-runtime@^0.11.0:
   version "0.11.0"
   resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.11.0.tgz#7e54fe5b5ccd5d6624ea6255c3473be090b802e1"
 
-regenerator-runtime@^0.12.1:
+regenerator-runtime@^0.12.0, regenerator-runtime@^0.12.1:
   version "0.12.1"
   resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.12.1.tgz#fa1a71544764c036f8c49b13a08b2594c9f8a0de"
+  integrity sha512-odxIc1/vDlo4iZcfXqRYFj0vpXFNoGdKMAUieAlFYO6m/nl5e9KR/beGf41z4a1FI+aQgtjhuaSlDxQ0hmkrHg==
 
 regenerator-transform@^0.10.0:
   version "0.10.1"

docs/codeship-ci.md

@@ -6,11 +6,7 @@ Pick "I want to create my own custom commands" on the Project Settings, Test tab
 ## Setup Commands
 ```bash
 #!/bin/bash
-# Install a custom version of PhantomJS, http://phantomjs.org/
-export PHANTOMJS_HOST="https://s3.amazonaws.com/codeship-packages"
-export PHANTOMJS_VERSION=2.1.1
-\curl -sSL https://raw.githubusercontent.com/codeship/scripts/master/packages/phantomjs.sh | bash -s
-rvm use 2.4.1
+rvm use 2.5.3
 gem update --system
 gem install bundler
 bundle config build.nokogiri --use-system-libraries

docs/integration-test-notes.md

@@ -10,16 +10,11 @@ See the .travis.yml file, at the bottom, to see what driver is used by Travis.
 Codeship is set to use the default driver.  
 
 ## Driver Options
-The current default driver is poltergeist_errors_ok.
 
 Support is included for the following drivers:
 
 1. Selenium Chrome (`DRIVER=selenium_chrome rspec`)
 1. Selenium Firefox (`DRIVER=selenium_firefox rspec`)
-1. Poltergeist (`DRIVER=poltergeist rspec`)
-1. Poltergeist no animations (`DRIVER=poltergeist_no_animations rspec`)
-1. Poltergeist errors ok (`DRIVER=poltergeist_errors_ok rspec`)
-1. Webkit (`DRIVER=webkit rspec`). Note, webkit has more errors than the other drivers.
 
 You may want to experiment with using the different drivers.
 
@@ -32,12 +27,3 @@ You may want to experiment with using the different drivers.
 
 You may want to see the [chromedriver-helper docs](https://github.com/flavorjones/chromedriver-helper) and run chromedriver-update to get the latest version of the Chrome driver.
 
-
-## Poltergeist
-
-Poltergeist is awesome because it will crash on JS Errors. Poltergeist is not aswesome because phantomjs is currently having race conditions on crashing a lot.
-
-### 2016-11-25
-Polteregeist is consistently crashing due to [issue 830](https://github.com/teampoltergeist/poltergeist/issues/830) and [issue 232](https://github.com/teampoltergeist/poltergeist/issues/232). Hopefully, this will be fixed in the future.
-
-`support/poltergeist.rb:34` contains code to restart phantomjs with the hopes that this will cause a failing test to pass.

package.json

@@ -4,8 +4,7 @@
   "description": "ShakaCode's example of React on Rails plus React Native",
   "main": "server-express.js",
   "engines": {
-    "node": "^7.8.0 || ^8.0.0 || ^9.2.0 || ^10.0.0",
-    "npm": "^4.4.4 || ^5.0.0",
+    "node": "^7.8.0 || ^8.0.0 || ^9.2.0 || ^10.0.0 || ^11.0.0",
     "yarn": "^1.0.0"
   },
   "scripts": {

spec/rails_helper.rb

@@ -98,6 +98,7 @@
 
   config.before(:each, type: :system, js: true) do
     driven_by driver
+    driven_by :selenium, using: :chrome, options: { args: ["headless", "disable-gpu", "no-sandbox", "disable-dev-shm-usage"] }
   end
 
   # Capybara.default_max_wait_time = 15

spec/support/driver_registration.rb

@@ -24,7 +24,7 @@ def self.register_selenium_firefox
   def self.register_selenium_chrome_headless
     return if @selenium_headless_registered
     Capybara.register_driver :selenium_chrome_headless do |app|
-      capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(chromeOptions: { args: %w[headless disable-gpu] })
+      capabilities = Selenium::WebDriver::Remote::Capabilities.chrome(chromeOptions: { args: %w[headless disable-gpu no-sandbox disable-dev-shm-usage] })
       Capybara::Selenium::Driver.new app, browser: :chrome, desired_capabilities: capabilities
     end
     Capybara::Screenshot.register_driver(:selenium_chrome_headless) do |js_driver, path|