Skip to content

Commit 3e87fbd

Browse files
committed
fix broken logging
1 parent f3684fe commit 3e87fbd

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 0.8.1
2+
3+
- fix broken logging
4+
15
# 0.8.0
26

37
- switch internal actor mailbox to `flume` from `crossbeam-channel`

src/actor/actor.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use std::error::Error;
22
use crate::prelude::{ActorContext, ActorPanicSource, ActorResult, SerializedMessage};
33
use std::panic::UnwindSafe;
4-
use log::{debug, error};
4+
use log::{error};
55
use crate::message::actor_stop_message::ActorStopMessage;
66

77
/// Core trait to define Actors
@@ -446,7 +446,7 @@ pub trait Actor: Send + Sync + UnwindSafe + Sized {
446446
fn on_system_stop(&mut self, context: &ActorContext<Self>) -> Result<ActorResult, Box<dyn Error>> {
447447
let result = context.actor_ref.send(ActorStopMessage::new());
448448
if result.is_err() {
449-
error!("Could not forward message ActorStopMessage to target {}", forward_to.get_address().actor);
449+
error!("Could not forward message ActorStopMessage to target {}", context.actor_ref.get_address().actor);
450450
}
451451
return Ok(ActorResult::Ok);
452452
}

src/routers/round_robin_router.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ where
157157
let forward_to = self.route_to.get(self.route_index).unwrap();
158158
let result = forward_to.send(msg.msg);
159159
if result.is_err() {
160-
error!("Could not forward message {} to target {}", msg.get_id(), forward_to.get_address().actor);
160+
error!("Could not forward message to target {}", forward_to.get_address().actor);
161161
}
162162
return Ok(ActorResult::Ok);
163163
}
@@ -187,7 +187,7 @@ where
187187
let chunk: Vec<M> = msg.data.drain(0..messages_per_routee).collect();
188188
let result = forward_to.send(BulkActorMessage::new(chunk));
189189
if result.is_err() {
190-
error!("Could not forward message {} to target {}", msg.get_id(), forward_to.get_address().actor);
190+
error!("Could not forward message to target {}", forward_to.get_address().actor);
191191
}
192192
}
193193
return Ok(ActorResult::Ok);

src/routers/sharded_router.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ impl<A, M> Handler<RouterMessage<M>> for ShardedRouter<A>
168168
let forward_to = self.sharding.get(&shard_id).unwrap();
169169
let result = forward_to.send(msg.msg);
170170
if result.is_err() {
171-
error!("Could not forward message {} to target {}", msg.get_id(), forward_to.get_address().actor);
171+
error!("Could not forward message to target {}", forward_to.get_address().actor);
172172
}
173173
return Ok(ActorResult::Ok);
174174
}
@@ -193,7 +193,7 @@ impl<A, M> Handler<BulkRouterMessage<M>> for ShardedRouter<A>
193193
let chunk: Vec<M> = msg.data.drain(0..messages_per_routee).collect();
194194
let result = forward_to.send(BulkActorMessage::new(chunk));
195195
if result.is_err() {
196-
error!("Could not forward message {} to target {}", msg.get_id(), forward_to.get_address().actor);
196+
error!("Could not forward message to target {}", forward_to.get_address().actor);
197197
}
198198
}
199199
return Ok(ActorResult::Ok);

src/system/delay_actor.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ impl<A, M> Handler<DelayedMessage<A, M>> for DelayActor
3535
if duration >= msg.delay {
3636
let result = msg.destination.send(msg.msg);
3737
if result.is_err() {
38-
error!("Could not delay message {} to target {}", msg.get_id(), forward_to.get_address().actor);
38+
error!("Could not delay message to target {}", msg.destination.get_address().actor);
3939
}
4040
}
4141
else {

src/system/internal_actor_manager.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ impl InternalActorManager {
3737
{
3838
let result = self.delay_router.as_ref().unwrap().send(RouterMessage::new(DelayedMessage::new(msg, destination, duration)));
3939
if result.is_err() {
40-
debug!("");
40+
error!("Could not send message to delay router");
4141
}
4242
}
4343

0 commit comments

Comments
 (0)