Fix #493: Ignore leading/trailing spaces in url (#494)

Author: Jessie-JY2728

src/internal/projecturl.cpp

@@ -22,6 +22,20 @@ ProjectUrl::ProjectUrl(const std::string &url)
 
     if (parts.empty())
         return;
+    
+    // trim leading whitespaces
+    str = parts.front();
+    str.erase(str.begin(), std::find_if(str.begin(), str.end(), [](unsigned char ch) {
+        return !std::isspace(ch);
+    }));
+    parts[0] = str;
+
+    // trim trailing whitespaces
+    str = parts.back();
+    str.erase(std::find_if(str.rbegin(), str.rend(), [](int ch){
+        return !std::isspace(ch);
+        }).base(), str.end());
+    parts[parts.size() - 1] = str;
 
     // Remove empty parts
     parts.erase(std::remove(parts.begin(), parts.end(), ""), parts.end());

test/network/projecturl_test.cpp

@@ -59,4 +59,23 @@ TEST(ProjectUrlTest, Parse)
         ASSERT_FALSE(url.isProjectUrl());
         ASSERT_TRUE(url.projectId().empty());
     }
+
+    {
+        ProjectUrl url("    https:/scratch.mit.edu/projects/886166351");
+        ASSERT_TRUE(url.isProjectUrl());
+        ASSERT_EQ(url.projectId(), "886166351");
+    }
+
+    {
+        ProjectUrl url("https:/scratch.mit.edu/projects/886166351    ");
+        ASSERT_TRUE(url.isProjectUrl());
+        ASSERT_EQ(url.projectId(), "886166351");
+    }
+
+    {
+        ProjectUrl url(" https:/scratch.mit.edu/projects/886166351  ");
+        ASSERT_TRUE(url.isProjectUrl());
+        ASSERT_EQ(url.projectId(), "886166351");
+    }
+    
 }