Fix eslint errors

Author: rtucek

.eslintrc.js

@@ -17,6 +17,7 @@ module.exports = {
     'class-methods-use-this': 'warn',
     'no-use-before-define': ['error', { functions: false }],
     'no-param-reassign': ['error', { props: false }],
+    'arrow-parens': ['error', 'as-needed'],
   },
 
   parserOptions: {
@@ -33,5 +34,12 @@ module.exports = {
         jest: true,
       },
     },
+    {
+      files: ['**/*.ts', '**/*.vue'],
+      rules: {
+        'no-unused-vars': 'off',
+        '@typescript-eslint/no-unused-vars': ['error'],
+      },
+    },
   ],
 };

package.json

@@ -73,8 +73,7 @@
   },
   "lint-staged": {
     "*.{js,vue,ts}": [
-      "vue-cli-service lint",
-      "git add"
+      "vue-cli-service lint"
     ]
   }
 }

src/QueryBuilderGroup.vue

@@ -10,7 +10,7 @@ import {
   QueryBuilderConfig, RuleSet, Rule, OperatorDefinition, RuleDefinition,
   GroupOperatorSlotProps, GroupCtrlSlotProps, QueryBuilderGroup as QueryBuilderGroupInterface,
 } from '@/types';
-import { isRuleSet, isRule, isQueryBuilderConfig } from '@/guards';
+import { isQueryBuilderConfig } from '@/guards';
 import MergeTrap from '@/MergeTrap';
 import QueryBuilderChild from './QueryBuilderChild.vue';
 

src/types.ts

@@ -48,6 +48,13 @@ export interface RuleSlotProps {
   updateRuleData: (newData: any) => void,
 }
 
+export interface QueryBuilderGroup extends Vue {
+  selectedOperator: string,
+  depth: number,
+  trap: ((position: number, newChild: RuleSet | Rule) => void) | null,
+  children: Array<RuleSet | Rule>,
+}
+
 export interface ComponentRegistration {
   component: QueryBuilderGroup,
   ev: RuleSet,
@@ -58,10 +65,3 @@ export interface ComponentRegistration {
 export interface MergeTrap {
   registerSortUpdate(update: ComponentRegistration): void,
 }
-
-export interface QueryBuilderGroup extends Vue {
-  selectedOperator: string,
-  depth: number,
-  trap: ((position: number, newChild: RuleSet | Rule) => void) | null,
-  children: Array<RuleSet | Rule>,
-}

tests/components/App.vue

@@ -9,7 +9,7 @@
 </template>
 
 <script lang="ts">
-import { Component, Vue, Watch } from 'vue-property-decorator';
+import { Component, Vue } from 'vue-property-decorator';
 
 import QueryBuilder from '@/QueryBuilder.vue';
 import { RuleSet, QueryBuilderConfig } from '@/types';

tests/unit/colored-borders.spec.ts

@@ -115,7 +115,7 @@ describe('Testing drag\'n\'drop related features', () => {
     expect(groups).toHaveLength(9);
 
     groups.wrappers
-      .forEach((w) => {
+      .forEach(w => {
         expect(w.vm.$props).toHaveProperty('depth');
         const el = (w.find('.query-builder-group__group-children')).element as HTMLDivElement;
         expect(el.style.borderColor).toBeFalsy();
@@ -141,7 +141,7 @@ describe('Testing drag\'n\'drop related features', () => {
     expect(groups).toHaveLength(9);
 
     groups.wrappers
-      .forEach((w) => {
+      .forEach(w => {
         expect(w.vm.$props).toHaveProperty('depth');
         const el = (w.find('.query-builder-group__group-children')).element as HTMLDivElement;
         const targetIdx = w.vm.$props.depth % w.vm.$props.config.colors.length;

tests/unit/drag-n-drop.spec.ts

@@ -130,7 +130,7 @@ describe('Test drag\'n\'drop related actions', () => {
     ((qbClone.children[0] as RuleSet).children[3] as RuleSet).children = children;
 
     const group = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'
@@ -151,7 +151,7 @@ describe('Test drag\'n\'drop related actions', () => {
     expect(app.emitted().input[0][0]).toStrictEqual(qbClone);
   });
 
-  it('tests drag\'n\'drop by merging with a parent group', async (done) => {
+  it('tests drag\'n\'drop by merging with a parent group', async done => {
     const app = mount(QueryBuilder, {
       propsData: {
         value,
@@ -170,7 +170,7 @@ describe('Test drag\'n\'drop related actions', () => {
 
     // Removing branch
     const removerComponent = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'
@@ -188,7 +188,7 @@ describe('Test drag\'n\'drop related actions', () => {
 
     // Adding branch
     const adderComponent = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'
@@ -212,7 +212,7 @@ describe('Test drag\'n\'drop related actions', () => {
     done();
   });
 
-  it('tests drag\'n\'dropping with merging within the adding group', async (done) => {
+  it('tests drag\'n\'dropping with merging within the adding group', async done => {
     const app = mount(QueryBuilder, {
       propsData: {
         value,
@@ -229,7 +229,7 @@ describe('Test drag\'n\'drop related actions', () => {
 
     // Removing branch
     const removerComponent = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'
@@ -247,7 +247,7 @@ describe('Test drag\'n\'drop related actions', () => {
 
     // Adding branch
     const adderComponent = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'
@@ -271,7 +271,7 @@ describe('Test drag\'n\'drop related actions', () => {
     done();
   });
 
-  it('tests drag\'n\'dropping with merging within the deleting group', async (done) => {
+  it('tests drag\'n\'dropping with merging within the deleting group', async done => {
     const app = mount(QueryBuilder, {
       propsData: {
         value,
@@ -288,7 +288,7 @@ describe('Test drag\'n\'drop related actions', () => {
 
     // Removing branch
     const removerComponent = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'
@@ -306,7 +306,7 @@ describe('Test drag\'n\'drop related actions', () => {
 
     // Adding branch
     const adderComponent = app.findAll(QueryBuilderGroup)
-      .filter((qb) => {
+      .filter(qb => {
         const vm = qb.vm as QueryBuilderGroupInterface;
 
         return vm.selectedOperator === 'AND'

tests/unit/query-builder.spec.ts

@@ -213,7 +213,6 @@ describe('Test basic functionality of QueryBuilder.vue', () => {
       .$parent
       .$emit('delete-child');
 
-
     expect(app.vm.$data.query).toStrictEqual({
       operatorIdentifier: 'and',
       children: [

vue.config.js

@@ -2,7 +2,7 @@ module.exports = {
   css: {
     extract: false,
   },
-  chainWebpack: (config) => {
+  chainWebpack: config => {
     const svgRule = config.module.rule('svg');
     svgRule.uses.clear();
     svgRule.use('url-loader')