Skip to content

Commit 34ed5a5

Browse files
committed
renamed scmversion to RTCVersion
1 parent f12a5e2 commit 34ed5a5

File tree

4 files changed

+18
-16
lines changed

4 files changed

+18
-16
lines changed

config.ini.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ ScmCommand = lscm
1414
# See "https://github.com/rtcTo/rtc2git/wiki/Encoding" for further instructions
1515
encoding =
1616
# Optional - SCM version. Different SCM versions have different commands. If not specific, default is 5.
17-
ScmVersion = 5
17+
RTCVersion = 5
1818

1919
[Migration]
2020
# Stream to be migrated, referenced by Name or UUID

configuration.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import os
21
import configparser
3-
import shutil
2+
import os
43
import shlex
4+
import shutil
55

66
import shell
77
import shouter
@@ -34,7 +34,7 @@ def read(configname=None):
3434
scmcommand = generalsection.get('ScmCommand', "lscm")
3535
shell.logcommands = parsedconfig.get(miscsectionname, 'LogShellCommands', fallback="False") == "True"
3636
shell.setencoding(generalsection.get('encoding'))
37-
scmversion = generalsection.get('ScmVersion', "5");
37+
rtcversion = generalsection.get('RTCVersion', "5");
3838

3939
workspace = shlex.quote(generalsection['WorkspaceName'])
4040
gitreponame = generalsection['GIT-Reponame']
@@ -58,7 +58,7 @@ def read(configname=None):
5858
gitattributes = parsesplittedproperty(gitattributesproperty)
5959

6060
configbuilder = Builder().setuser(user).setpassword(password).setstored(stored).setrepourl(repositoryurl)
61-
configbuilder.setscmcommand(scmcommand).setscmversion(scmversion)
61+
configbuilder.setscmcommand(scmcommand).setrtcversion(rtcversion)
6262
configbuilder.setworkspace(workspace).setgitreponame(gitreponame).setrootfolder(os.getcwd())
6363
configbuilder.setuseexistingworkspace(useexistingworkspace).setuseprovidedhistory(useprovidedhistory)
6464
configbuilder.setuseautomaticconflictresolution(useautomaticconflictresolution)
@@ -131,7 +131,7 @@ def __init__(self):
131131
self.stored = False
132132
self.repourl = ""
133133
self.scmcommand = "lscm"
134-
self.scmversion = ""
134+
self.rtcversion = ""
135135
self.workspace = ""
136136
self.useexistingworkspace = ""
137137
self.useprovidedhistory = ""
@@ -172,8 +172,8 @@ def setscmcommand(self, scmcommand):
172172
self.scmcommand = scmcommand
173173
return self
174174

175-
def setscmversion(self, scmversion):
176-
self.scmversion = int(scmversion)
175+
def setrtcversion(self, scmversion):
176+
self.rtcversion = int(scmversion)
177177
return self
178178

179179
def setworkspace(self, workspace):
@@ -250,7 +250,8 @@ def isenabled(stringwithbooleanexpression):
250250
return stringwithbooleanexpression == "True"
251251

252252
def build(self):
253-
return ConfigObject(self.user, self.password, self.stored, self.repourl, self.scmcommand, self.scmversion, self.workspace,
253+
return ConfigObject(self.user, self.password, self.stored, self.repourl, self.scmcommand, self.rtcversion,
254+
self.workspace,
254255
self.useexistingworkspace, self.workdirectory, self.initialcomponentbaselines,
255256
self.streamname, self.gitreponame, self.useprovidedhistory,
256257
self.useautomaticconflictresolution, self.maxchangesetstoaccepttogether, self.clonedgitreponame, self.rootFolder,
@@ -260,7 +261,8 @@ def build(self):
260261

261262
class ConfigObject:
262263

263-
def __init__(self, user, password, stored, repourl, scmcommand, scmversion, workspace, useexistingworkspace, workdirectory,
264+
def __init__(self, user, password, stored, repourl, scmcommand, rtcversion, workspace, useexistingworkspace,
265+
workdirectory,
264266
initialcomponentbaselines, streamname, gitreponame, useprovidedhistory,
265267
useautomaticconflictresolution, maxchangesetstoaccepttogether, clonedgitreponame, rootfolder, previousstreamname,
266268
ignorefileextensions, ignoredirectories, includecomponentroots, commitmessageprefix, gitattributes):
@@ -269,7 +271,7 @@ def __init__(self, user, password, stored, repourl, scmcommand, scmversion, work
269271
self.stored = stored
270272
self.repo = repourl
271273
self.scmcommand = scmcommand
272-
self.scmversion = scmversion
274+
self.rtcversion = rtcversion
273275
self.workspace = workspace
274276
self.useexistingworkspace = useexistingworkspace
275277
self.useprovidedhistory = useprovidedhistory

tests/resources/test_config.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Directory = /tmp/migration
88
useExistingWorkspace = True
99
ScmCommand = scm
1010
encoding = UTF-8
11-
ScmVersion = 6
11+
RTCVersion = 6
1212

1313
[Migration]
1414
StreamToMigrate = Superstream

tests/test_configuration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import unittest
21
import os
2+
import unittest
33

4-
from configuration import Builder
54
import configuration
65
import shell
6+
from configuration import Builder
77
from tests import testhelper
88

99

@@ -137,7 +137,7 @@ def _assertTestConfig(self, config, user=None, password=None):
137137
self.assertTrue(config.useexistingworkspace)
138138
self.assertEqual('scm', config.scmcommand)
139139
self.assertEqual('UTF-8', shell.encoding) # directly deviated to shell
140-
self.assertEqual(6, config.scmversion)
140+
self.assertEqual(6, config.rtcversion)
141141
# [Migration]
142142
self.assertEqual('Superstream', config.streamname)
143143
self.assertEqual('Previousstream', config.previousstreamname)
@@ -182,7 +182,7 @@ def _assertDefaultConfig(self, config):
182182
self.assertFalse(config.useexistingworkspace)
183183
self.assertEqual('lscm', config.scmcommand)
184184
self.assertEqual(None, shell.encoding) # directly deviated to shell
185-
self.assertEqual(5, config.scmversion)
185+
self.assertEqual(5, config.rtcversion)
186186
# [Migration]
187187
self.assertEqual('Ministream', config.streamname)
188188
self.assertEqual('', config.previousstreamname)

0 commit comments

Comments
 (0)