Length check in others

Author: linev

examples.htm

@@ -550,7 +550,7 @@ <h1><div><a href="https://root.cern/js/">JSROOT</a></div><a id="version" href="h
          document.getElementById('plaindraw').innerHTML = '';
          document.getElementById('plaindraw').style['background-color'] = '';
 
-         if (durl.length > 0) {
+         if (durl) {
             return drawUrl(durl + (opt ? `&opt=${opt}` : '') + extra_opts);
          } else if (jsonname) {
             return httpRequest(jsonname, 'object')
@@ -699,26 +699,26 @@ <h1><div><a href="https://root.cern/js/">JSROOT</a></div><a id="version" href="h
 
          createRootColors(); // ensure default colors
 
-         if (url.length > 0) {
+         if (url) {
             if (no_interactive)
                url += '&interactive=0';
 
             testfile = testobj = null;
             // if (keyid == 'TGeo') return runBigTest(0);  // ignore TGeo URLs - too complex
 
             drawUrl(url).then(TestContinue, TestFailure);
-         } else if (jsonname.length > 0) {
+         } else if (jsonname) {
             testfile = testobj = null;
             httpRequest(jsonname, 'object').then(obj => {
                testobj = obj;
                return drawEntry(entry, obj, opt).then(TestContinue, TestFailure);
             });
-         } else if (filename.length > 0) {
+         } else if (filename) {
             openFile(filename)
                   .then(file => { testfile = file; return testfile.readObject(itemname); })
                   .then(obj => { testobj = obj; return drawEntry(entry, obj, opt); })
                   .then(TestContinue, TestFailure);
-         } else if (itemname.length > 0) {
+         } else if (itemname) {
             testfile.readObject(itemname)
                    .then(obj => { testobj = obj; return drawEntry(entry, obj, opt); })
                    .then(TestContinue, TestFailure);

modules/gui/menu.mjs

@@ -155,7 +155,7 @@ class JSRootMenu {
          if (without_sub)
             name = top_name + ' ' + name;
 
-         if (group.length > 0) {
+         if (group.length) {
             this.sub(name, opts[i], call_back);
             group.forEach(sub => {
                this.add(sub, sub, call_back);

modules/tree.mjs

@@ -198,7 +198,7 @@ class ArrayIterator {
             continue;
          }
 
-         if ((typ === 'array') && ((obj.length > 0) || (this.select[cnt + 1] === '$size$'))) {
+         if ((typ === 'array') && (obj.length || (this.select[cnt + 1] === '$size$'))) {
             this.arr[++cnt] = obj;
             switch (this.select[cnt]) {
                case undefined: this.indx[cnt] = 0; break;
@@ -2348,7 +2348,7 @@ async function treeProcess(tree, selector, args) {
 
             const branch = bitems[n].branch;
 
-            if (places.length === 0)
+            if (!places.length)
                filename = branch.fFileName;
             else if (filename !== branch.fFileName)
                continue;
@@ -2358,7 +2358,7 @@ async function treeProcess(tree, selector, args) {
             places.push(branch.fBasketSeek[bitems[n].basket], branch.fBasketBytes[bitems[n].basket]);
          }
 
-         return places.length > 0 ? { places, filename } : null;
+         return places.length ? { places, filename } : null;
       }
 
       function readProgress(value) {
@@ -2633,7 +2633,7 @@ async function treeProcess(tree, selector, args) {
                if (handle.process_entries !== undefined) {
                   elem.selected_baskets.shift();
                   // -1 means that basket is not yet found for following entries
-                  elem.curr_basket = (elem.selected_baskets.length > 0) ? elem.selected_baskets[0] : -1;
+                  elem.curr_basket = elem.selected_baskets.length ? elem.selected_baskets[0] : -1;
                }
             }
 
@@ -2918,7 +2918,7 @@ function treeHierarchy(tree_node, obj) {
             const object_class = getBranchObjectClass(bobj, bobj.$tree, true),
                   methods = object_class ? getMethods(object_class) : null;
 
-            if (methods && (bobj.fBranches.arr.length > 0)) {
+            if (methods && bobj.fBranches.arr.length) {
                for (const key in methods) {
                   if (!isFunc(methods[key])) continue;
                   const s = methods[key].toString();
@@ -2963,8 +2963,7 @@ function treeHierarchy(tree_node, obj) {
    tree_node._childs = [];
    tree_node._tree = obj;  // set reference, will be used later by TTree::Draw
 
-   for (let i = 0; i < obj.fBranches?.arr.length; ++i)
-      createBranchItem(tree_node, obj.fBranches.arr[i], obj);
+   obj.fBranches?.arr.forEach(branch => createBranchItem(tree_node, branch, obj));
 
    return true;
 }

modules/webwindow.mjs

@@ -388,7 +388,7 @@ class WebWindowHandle {
    processQueue() {
       if (this._loop_msgqueue || !this.msgqueue) return;
       this._loop_msgqueue = true;
-      while ((this.msgqueue.length > 0) && this.msgqueue[0].ready) {
+      while (this.msgqueue.length && this.msgqueue[0].ready) {
          const front = this.msgqueue.shift();
          this.invokeReceiver(false, 'onWebsocketMsg', front.msg, front.len);
       }

scripts/JSRoot.core.js

@@ -239,7 +239,7 @@ exports.decodeUrl = function(url) {
    if (p1 < 0) return res;
    url = decodeURI(url.slice(p1+1));
 
-   while (url.length > 0) {
+   while (url) {
       // try to correctly handle quotes in the URL
       let pos = 0, nq = 0, eq = -1, firstq = -1;
       while ((pos < url.length) && ((nq !== 0) || ((url[pos] !== '&') && (url[pos] !== '#')))) {