enforce eslint (#312)

* reformat

* add eslint

Author: vonovak

.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: ['@react-native-community'],
+};

.github/workflows/nodejs.yml

@@ -0,0 +1,29 @@
+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
+name: Node.js CI
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        node-version: [12.x]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - run: yarn install --frozen-lockfile
+      - run: yarn lint
+        env:
+          CI: true

.prettierrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+  printWidth: 100,
+  singleQuote: true,
+  trailingComma: 'es5',
+};

README.md

@@ -250,4 +250,3 @@ RNFS.uploadFiles({
 
 - Fix Xcode warning about constraints
 - support options for the [UIDocumentPickerViewController](https://developer.apple.com/library/ios/documentation/FileManagement/Conceptual/DocumentPickerProgrammingGuide/AccessingDocuments/AccessingDocuments.html#//apple_ref/doc/uid/TP40014451-CH2-SW5)
-- Handle Upload by itself ?

__tests__/typescript/index.test.ts

@@ -1,81 +1,78 @@
-import DocumentPicker from "react-native-document-picker";
+import DocumentPicker from 'react-native-document-picker';
 
 // Option is correct about pick
 DocumentPicker.pick({
-  type: [DocumentPicker.types.allFiles]
-})
+  type: [DocumentPicker.types.allFiles],
+});
 
 DocumentPicker.pick({
-  type: [DocumentPicker.types.audio]
-})
+  type: [DocumentPicker.types.audio],
+});
 
 DocumentPicker.pick({
-  type: [DocumentPicker.types.images]
-})
+  type: [DocumentPicker.types.images],
+});
 
 DocumentPicker.pick({
-  type: [DocumentPicker.types.plainText]
-})
+  type: [DocumentPicker.types.plainText],
+});
 
 DocumentPicker.pick({
-  type: [DocumentPicker.types.video]
-})
+  type: [DocumentPicker.types.video],
+});
 
 DocumentPicker.pick({
-  type: [DocumentPicker.types.pdf]
-})
+  type: [DocumentPicker.types.pdf],
+});
 
 DocumentPicker.pick({
-  type: [DocumentPicker.types.video,DocumentPicker.types.pdf, 'public.audio']
-})
+  type: [DocumentPicker.types.video, DocumentPicker.types.pdf, 'public.audio'],
+});
 
 // Option is correct about pickMultiple
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.allFiles]
-})
+  type: [DocumentPicker.types.allFiles],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.allFiles]
-})
+  type: [DocumentPicker.types.allFiles],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.audio]
-})
+  type: [DocumentPicker.types.audio],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.images]
-})
+  type: [DocumentPicker.types.images],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.plainText]
-})
+  type: [DocumentPicker.types.plainText],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.video]
-})
+  type: [DocumentPicker.types.video],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.pdf]
-})
+  type: [DocumentPicker.types.pdf],
+});
 
 DocumentPicker.pickMultiple({
-  type: [DocumentPicker.types.video,DocumentPicker.types.pdf, 'public.audio']
-})
+  type: [DocumentPicker.types.video, DocumentPicker.types.pdf, 'public.audio'],
+});
 
-DocumentPicker.pick({type: 'image/jpg'});
-DocumentPicker.pick({type: 'public.png'});
-
-DocumentPicker.pick({type: ['image/jpg', 'image/jpeg', 'image/png', 'application/pdf']});
-DocumentPicker.pick({type: ['public.png', 'public.jpeg']});
+DocumentPicker.pick({ type: 'image/jpg' });
+DocumentPicker.pick({ type: 'public.png' });
 
+DocumentPicker.pick({ type: ['image/jpg', 'image/jpeg', 'image/png', 'application/pdf'] });
+DocumentPicker.pick({ type: ['public.png', 'public.jpeg'] });
 
 try {
-  throw new Error('test')
+  throw new Error('test');
 } catch (e) {
-  if(DocumentPicker.isCancel(e)){
-
+  if (DocumentPicker.isCancel(e)) {
   } else {
-
   }
 }

index.d.ts

@@ -4,52 +4,51 @@ declare module 'react-native-document-picker' {
   type Extension = '.jpeg' | '.jpg' | '.png' | '.txt' | '.pdf';
 
   type DocumentType = {
-    android: MimeType | MimeType[]
-    ios: UTI | UTI[]
-    windows: Extension | Extension[]
+    android: MimeType | MimeType[];
+    ios: UTI | UTI[];
+    windows: Extension | Extension[];
   };
 
   type Types = {
     mimeTypes: {
-      allFiles: '*/*',
-      audio: 'audio/*',
-      csv: 'text/csv',
-      images: 'image/*',
-      plainText: 'text/plain',
-      pdf: 'application/pdf',
-      video: 'video/*',
-      zip: 'application/zip',
-    },
+      allFiles: '*/*';
+      audio: 'audio/*';
+      csv: 'text/csv';
+      images: 'image/*';
+      plainText: 'text/plain';
+      pdf: 'application/pdf';
+      video: 'video/*';
+      zip: 'application/zip';
+    };
     utis: {
-      allFiles: 'public.content',
-      audio: 'public.audio',
-      csv: 'public.comma-separated-values-text',
-      images: 'public.image',
-      plainText: 'public.plain-text',
-      pdf: 'com.adobe.pdf',
-      video: 'public.movie',
-      zip: 'public.zip-archive',
-    },
+      allFiles: 'public.content';
+      audio: 'public.audio';
+      csv: 'public.comma-separated-values-text';
+      images: 'public.image';
+      plainText: 'public.plain-text';
+      pdf: 'com.adobe.pdf';
+      video: 'public.movie';
+      zip: 'public.zip-archive';
+    };
     extensions: {
-      allFiles: '*',
-      audio:
-        '.3g2 .3gp .aac .adt .adts .aif .aifc .aiff .asf .au .m3u .m4a .m4b .mid .midi .mp2 .mp3 .mp4 .rmi .snd .wav .wax .wma',
-      csv: '.csv',
-      images: '.jpeg .jpg .png',
-      plainText: '.txt',
-      pdf: '.pdf',
-      video: '.mp4',
-      zip: '.zip .gz',
-    },
+      allFiles: '*';
+      audio: '.3g2 .3gp .aac .adt .adts .aif .aifc .aiff .asf .au .m3u .m4a .m4b .mid .midi .mp2 .mp3 .mp4 .rmi .snd .wav .wax .wma';
+      csv: '.csv';
+      images: '.jpeg .jpg .png';
+      plainText: '.txt';
+      pdf: '.pdf';
+      video: '.mp4';
+      zip: '.zip .gz';
+    };
   };
   type PlatformTypes = {
-    android: Types['mimeTypes']
-    ios: Types['utis']
-    windows: Types['extensions']
+    android: Types['mimeTypes'];
+    ios: Types['utis'];
+    windows: Types['extensions'];
   };
   interface DocumentPickerOptions<OS extends keyof PlatformTypes> {
     type: Array<PlatformTypes[OS][keyof PlatformTypes[OS]]> | DocumentType[OS];
-	  copyTo?: 'cachesDirectory' | 'documentDirectory';
+    copyTo?: 'cachesDirectory' | 'documentDirectory';
   }
   interface DocumentPickerResponse {
     uri: string;
@@ -59,15 +58,15 @@ declare module 'react-native-document-picker' {
     name: string;
     size: string;
   }
-  type Platform = 'ios' | 'android' | 'windows'
+  type Platform = 'ios' | 'android' | 'windows';
   export default class DocumentPicker<OS extends keyof PlatformTypes = Platform> {
-    static types: PlatformTypes['ios'] | PlatformTypes['android'] | PlatformTypes['windows']
+    static types: PlatformTypes['ios'] | PlatformTypes['android'] | PlatformTypes['windows'];
     static pick<OS extends keyof PlatformTypes = Platform>(
       options: DocumentPickerOptions<OS>
     ): Promise<DocumentPickerResponse>;
     static pickMultiple<OS extends keyof PlatformTypes = Platform>(
       options: DocumentPickerOptions<OS>
     ): Promise<DocumentPickerResponse[]>;
-    static isCancel<IError extends {code?: string}>(err?: IError): boolean;
+    static isCancel<IError extends { code?: string }>(err?: IError): boolean;
   }
 }

index.js

@@ -38,7 +38,7 @@ function pick(opts) {
 
   opts.type = Array.isArray(opts.type) ? opts.type : [opts.type];
 
-  if (opts.type.some(type => type === undefined)) {
+  if (opts.type.some((type) => type === undefined)) {
     throw new TypeError(
       'Unexpected undefined type option, did you try using a DocumentPicker.types.* that does not exist?'
     );
@@ -50,23 +50,15 @@ function pick(opts) {
     );
   }
 
-  opts.type.forEach(type => {
+  opts.type.forEach((type) => {
     if (typeof type !== 'string') {
-      throw new TypeError(
-        'Invalid type option, expected a string not: ' + type
-      );
+      throw new TypeError('Invalid type option, expected a string not: ' + type);
     }
   });
 
-  if (
-    opts.type.length > 1 &&
-    Platform.OS === 'android' &&
-    Platform.Version < 19
-  ) {
+  if (opts.type.length > 1 && Platform.OS === 'android' && Platform.Version < 19) {
     console.warn(
-      `RNDocumentPicker: Android API level ${
-        Platform.Version
-      } does not support multiple types, falling back to */*`
+      `RNDocumentPicker: Android API level ${Platform.Version} does not support multiple types, falling back to */*`
     );
   }
 
@@ -86,7 +78,7 @@ const Types = {
     plainText: 'text/plain',
     pdf: 'application/pdf',
     video: 'video/*',
-    zip: 'application/zip'
+    zip: 'application/zip',
   },
   utis: {
     allFiles: 'public.content',
@@ -107,6 +99,7 @@ const Types = {
     plainText: '.txt',
     pdf: '.pdf',
     video: '.mp4',
+    zip: '.zip .gz',
   },
 };
 
@@ -130,7 +123,7 @@ export default class DocumentPicker {
       multiple: false,
     };
 
-    return pick(options).then(results => results[0]);
+    return pick(options).then((results) => results[0]);
   }
 
   static pickMultiple(opts) {

package.json

@@ -4,7 +4,8 @@
   "description": "A react native interface to access Documents from dropbox google drive, iCloud",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "lint": "eslint ."
   },
   "repository": {
     "type": "git",
@@ -29,7 +30,13 @@
     "react-native": ">= 0.33"
   },
   "devDependencies": {
+    "@react-native-community/eslint-config": "^2.0.0",
+    "eslint": "^7.2.0",
+    "eslint-plugin-prettier": "^3.1.3",
+    "prettier": "^2.0.5",
     "react": "^16.0.0-beta.5",
-    "react-native": "^0.49.3"
-  }
+    "react-native": "^0.49.3",
+    "typescript": "^3.9.5"
+  },
+  "dependencies": {}
 }