Skip to content

Commit d8b14ec

Browse files
committed
Update rubocop configuration to support the latest release (v0.85.1)
The Metrics/LineLength cop was moved to Layout/LineLength, and its default value for the `Max` attribute was changed from 80 to 120. We're going to stick to 80 for now, though (may revisit later). Additionally, we've set `NewCops: enable` to opt into new cops. If this becomes a pain we can instead switch to enabling individual cops, but for now we'd like to stay as close to the default style guide as possible.
1 parent 7dcef54 commit d8b14ec

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.rubocop.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
AllCops:
2+
NewCops: enable
23
TargetRubyVersion: 2.5.5
34
Exclude:
45
- examples/**/*
56
- vendor/bundle/**/*
67

8+
Layout/LineLength:
9+
Max: 80
10+
711
Style/Documentation:
812
Enabled: false

test/external_asset_pipeline/manifest_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,11 @@ def test_fall_back_to_sprockets
9797
private
9898

9999
def modify_application_js_fingerprint(manifest_path)
100-
`sed -i'.bak' -e 's/7b3dc2436f7956c77987/22222222222222222222/g' #{manifest_path}` # rubocop:disable Metrics/LineLength
100+
`sed -i'.bak' -e 's/7b3dc2436f7956c77987/22222222222222222222/g' #{manifest_path}` # rubocop:disable Layout/LineLength
101101
end
102102

103103
def revert_application_js_fingerprint(manifest_path)
104-
`sed -i'.bak' -e 's/22222222222222222222/7b3dc2436f7956c77987/g' #{manifest_path}` # rubocop:disable Metrics/LineLength
104+
`sed -i'.bak' -e 's/22222222222222222222/7b3dc2436f7956c77987/g' #{manifest_path}` # rubocop:disable Layout/LineLength
105105
`rm #{manifest_path}.bak`
106106
end
107107
end

0 commit comments

Comments
 (0)