Skip to content

stub_uploader: verify external stub packages require runtime #14045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srittau opened this issue May 13, 2025 · 1 comment
Open

stub_uploader: verify external stub packages require runtime #14045

srittau opened this issue May 13, 2025 · 1 comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@srittau
Copy link
Collaborator

srittau commented May 13, 2025

We currently have a check in stub_uploader that external stubs packages require their runtime package:

https://github.com/typeshed-internal/stub_uploader/blob/de903bfb39be09084b72ceee6854ecae40ef2db0/stub_uploader/metadata.py#L335

This breaks for the suggested pydbus stubs (#13921), which depend on PyGObject-stubs, but PyGObject-stubs doesn't depend on PyGObject:

https://github.com/python/typeshed/actions/runs/14886712852/job/41808156011?pr=13921#step:6:206

Does anyone remember or know why we have this check? And what should we do about it?

  1. Remove the check, because it doesn't serve a known purpose?
  2. Add an exception list to the check?
  3. Remove the dependency on PyGObject-stubs from pydbus and use Any or stub protocols instead?
@srittau srittau added the project: infrastructure typeshed build, test, documentation, or distribution related label May 13, 2025
@hauntsaninja
Copy link
Collaborator

It's to try and avoid security issues: #5768 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Development

No branches or pull requests

2 participants