Skip to content

Commit e5e45e8

Browse files
Kiuk Chungfacebook-github-bot
Kiuk Chung
authored andcommitted
use isort==4.3.21 since >= 5.x.x produces different import sorting compared to platform009's isort
Summary: `isort==5.8.0` produces different sorting order compared to platform009's `isort` (not sure which version is used with platform009 but `isort==4.3.21` is the one we used to use for `pytorch/elastic` which produces consistent results to our internal `arc f`. This should fix linter failures for both: 1. pytorch#12 2. pytorch#10 Reviewed By: d4l3k Differential Revision: D28669450 fbshipit-source-id: 8ead84f96d2ef2d0c01ddaba2ce513c78f7966f3
1 parent 4d7e2a1 commit e5e45e8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/lint.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- name: Install Dependencies
2121
run: |
2222
set -eux
23-
pip install isort
23+
pip install isort==4.3.21
2424
pip install black
2525
- name: Run Lint
2626
run: |

dev-requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ moto>=2.0.6
33
kfp==1.4.0
44
pyre-extensions>=0.0.21
55
black>=21.5b1
6-
isort>=5.8.0
6+
isort==4.3.21
77
pytorch-lightning>=0.5.3
88
torch>=1.8.1
99
torchvision>=0.9.1

0 commit comments

Comments
 (0)