review comments

Author: dgrove-oss

Makefile

@@ -12,7 +12,7 @@ VERSION ?= v0.0.0-dev
 BUNDLE_VERSION ?= $(VERSION:v%=%)
 
 # APPWRAPPER_VERSION defines the default version of the AppWrapper controller
-APPWRAPPER_VERSION ?= v0.7.2
+APPWRAPPER_VERSION ?= v0.7.3
 APPWRAPPER_REPO ?= github.com/project-codeflare/appwrapper
 # Upstream AppWrapper is currently only creating release tags of the form `vX.Y.Z` (i.e the version)
 APPWRAPPER_CRD ?= ${APPWRAPPER_REPO}/config/crd?ref=${APPWRAPPER_VERSION}

README.md

@@ -9,7 +9,7 @@ CodeFlare Stack Compatibility Matrix
 | Component                | Version                                                                                  |
 |--------------------------|------------------------------------------------------------------------------------------|
 | CodeFlare Operator       | [v1.2.0](https://github.com/project-codeflare/codeflare-operator/releases/tag/v1.2.0)    |
-| AppWrapper               | [v0.7.2](https://github.com/project-codeflare/appwrapper/releases/tag/v0.7.2)            |
+| AppWrapper               | [v0.7.3](https://github.com/project-codeflare/appwrapper/releases/tag/v0.7.3)            |
 | CodeFlare-SDK            | [v0.14.0](https://github.com/project-codeflare/codeflare-sdk/releases/tag/v0.14.0)       |
 | KubeRay                  | [v1.0.0](https://github.com/opendatahub-io/kuberay/releases/tag/v1.0.0)                  |
 <!-- Compatibility Matrix end -->

config/crd/appwrapper/kustomization.yaml

@@ -1,4 +1,4 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-- github.com/project-codeflare/appwrapper/config/crd?ref=v0.7.2
+- github.com/project-codeflare/appwrapper/config/crd?ref=v0.7.3

config/rbac/kustomization.yaml

@@ -7,11 +7,7 @@ resources:
 - admin_role.yaml
 - editor_role.yaml
 - service_account.yaml
-- mcad_manager_role.yaml
-- mcad_manager_role_binding.yaml
 - role.yaml
 - role_binding.yaml
 - leader_election_role.yaml
 - leader_election_role_binding.yaml
-- mcad-controller-ray-clusterrolebinding.yaml
-- mcad-controller-ray-clusterrole.yaml

config/rbac/mcad-controller-ray-clusterrole.yaml

@@ -5,9 +5,10 @@ go 1.21
 require (
 	github.com/onsi/ginkgo/v2 v2.15.0
 	github.com/onsi/gomega v1.31.1
+	github.com/open-policy-agent/cert-controller v0.10.1
 	github.com/openshift/api v0.0.0-20230213134911-7ba313770556
 	github.com/openshift/client-go v0.0.0-20221019143426-16aed247da5c
-	github.com/project-codeflare/appwrapper v0.7.2
+	github.com/project-codeflare/appwrapper v0.7.3
 	github.com/project-codeflare/codeflare-common v0.0.0-20240404131119-10cc4982cd0e
 	github.com/ray-project/kuberay/ray-operator v1.1.0
 	go.uber.org/zap v1.26.0
@@ -61,7 +62,6 @@ require (
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
-	github.com/open-policy-agent/cert-controller v0.10.1 // indirect
 	github.com/openshift-online/ocm-sdk-go v0.1.368 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/prometheus/client_golang v1.18.0 // indirect

config/rbac/mcad-controller-ray-clusterrolebinding.yaml

@@ -341,10 +341,8 @@ github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
 github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/project-codeflare/appwrapper v0.7.2 h1:VTApjW6mTGZbuPasugcsWhCb5jnZG/Hk897tNJdskWQ=
-github.com/project-codeflare/appwrapper v0.7.2/go.mod h1:f4SYPB6sPteegtekwD4bjPdpWZ+nFlLF2Eoz9iyw73s=
-github.com/project-codeflare/codeflare-common v0.0.0-20240328182412-38df643db183 h1:WOy8nuzZ3zGLVxj2evwfSkTj5SLMVCX5rbI7J5NZxOg=
-github.com/project-codeflare/codeflare-common v0.0.0-20240328182412-38df643db183/go.mod h1:ebDcLOZsMe3t9JvUGAv4By2ttu+7NenSpAQZUAaYUak=
+github.com/project-codeflare/appwrapper v0.7.3 h1:OYz4x3ymsHC26nrfq6iikp0iF78dPJfx/VzLFP1EE4Y=
+github.com/project-codeflare/appwrapper v0.7.3/go.mod h1:f4SYPB6sPteegtekwD4bjPdpWZ+nFlLF2Eoz9iyw73s=
 github.com/project-codeflare/codeflare-common v0.0.0-20240404131119-10cc4982cd0e h1:ucvjQJ+UVCAqdxFJlgLhNxDwvuiZcT+Li73xbCPHH8I=
 github.com/project-codeflare/codeflare-common v0.0.0-20240404131119-10cc4982cd0e/go.mod h1:ebDcLOZsMe3t9JvUGAv4By2ttu+7NenSpAQZUAaYUak=
 github.com/prometheus/client_golang v0.9.1/go.mod h1:7SWBe2y4D6OKWSNQJUaRYU/AaXPKyh/dDVn+NZz0KFw=