Skip to content

XCM v5 support #6087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmpolaczyk opened this issue Feb 4, 2025 · 12 comments
Closed

XCM v5 support #6087

tmpolaczyk opened this issue Feb 4, 2025 · 12 comments

Comments

@tmpolaczyk
Copy link

I get the same error as this issue:

#5811

src/dancebox/interfaces/types-lookup.ts:1358:24 - error TS2304: Cannot find name 'Lookup87'.

1358     readonly asX1: Vec<Lookup87>;
                            ~~~~~~~~

I am using polkadot js 15.5.1
@valentinfernandez1
Copy link
Contributor

Hi @tmpolaczyk thanks for creating the issue, could you provide additional information 🙏🏻. What is the enviroment you are using, or maybe a code snipped so we can try to replicate the issue and investigate it

@tmpolaczyk
Copy link
Author

It's a bit hard to reproduce, can't you just do the same as last time?

If you need to reproduce,

In this branch: https://github.com/moondance-labs/tanssi/commits/tomasz-wip-wip-stable2412

cargo build --release --features=fast-runtime
cd typescript-api
pnpm i
pnpm create-local-interfaces

That last command with give the error. Full output:

Logs 
tomasz@tomasz-XPS-15-9520:~/projects/tanssi/typescript-api$ pnpm create-local-interfaces

> @tanssi/api-augment@0.800.1 create-local-interfaces /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx ./scripts/runtime-upgrade.ts && pnpm fmt:fix

Starting dancebox node
Getting dancebox metadata
Starting flashbox node
Getting flashbox metadata
Starting dancelight node
Getting dancelight metadata
Generating typescript api code...

> @tanssi/api-augment@0.800.1 generate:defs /home/tomasz/projects/tanssi/typescript-api
> pnpm run generate:defs:dancebox && pnpm run generate:defs:flashbox && pnpm run generate:defs:dancelight


> @tanssi/api-augment@0.800.1 generate:defs:dancebox /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx node_modules/@polkadot/typegen/scripts/polkadot-types-from-defs.mjs --package @tanssi/api-augment/tanssi/interfaces --input ./src/dancebox/interfaces --endpoint ./metadata-dancebox.json

/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/types.ts
	Generating
	Extracting interfaces for tanssi
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-types.ts
	Generating
	Writing

2025-02-11 15:32:11        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/lookup.ts
	Generating
	Writing


> @tanssi/api-augment@0.800.1 generate:defs:flashbox /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx node_modules/@polkadot/typegen/scripts/polkadot-types-from-defs.mjs --package @tanssi/api-augment/tanssi/interfaces --input ./src/flashbox/interfaces --endpoint ./metadata-flashbox.json

/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/types.ts
	Generating
	Extracting interfaces for tanssi
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-types.ts
	Generating
	Writing

2025-02-11 15:32:12        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/lookup.ts
	Generating
	Writing


> @tanssi/api-augment@0.800.1 generate:defs:dancelight /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx node_modules/@polkadot/typegen/scripts/polkadot-types-from-defs.mjs --package @tanssi/api-augment/tanssi/interfaces --input ./src/dancelight/interfaces --endpoint ./metadata-dancelight.json

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/types.ts
	Generating
	Extracting interfaces for starlight
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-types.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/lookup.ts
	Generating
	Writing


> @tanssi/api-augment@0.800.1 generate:meta /home/tomasz/projects/tanssi/typescript-api
> pnpm run generate:meta:dancebox && pnpm run generate:meta:flashbox && pnpm run generate:meta:dancelight


> @tanssi/api-augment@0.800.1 generate:meta:dancebox /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx node_modules/@polkadot/typegen/scripts/polkadot-types-from-chain.mjs --endpoint ./metadata-dancebox.json --package @tanssi/api-augment/tanssi/interfaces --output ./src/dancebox/interfaces

Generating from metadata, 250,242 bytes
2025-02-11 15:32:15        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-consts.ts
	Generating
	Writing

2025-02-11 15:32:16        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-errors.ts
	Generating
	Writing

2025-02-11 15:32:16        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-events.ts
	Generating
	Writing

2025-02-11 15:32:16        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-query.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-rpc.ts
	Generating
	Writing

2025-02-11 15:32:16        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-runtime.ts
	Generating
	Writing

2025-02-11 15:32:16        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api-tx.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancebox/interfaces/augment-api.ts
	Generating
	Writing


> @tanssi/api-augment@0.800.1 generate:meta:flashbox /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx node_modules/@polkadot/typegen/scripts/polkadot-types-from-chain.mjs --endpoint ./metadata-flashbox.json --package @tanssi/api-augment/tanssi/interfaces --output ./src/flashbox/interfaces

Generating from metadata, 133,187 bytes
2025-02-11 15:32:17        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-consts.ts
	Generating
	Writing

2025-02-11 15:32:17        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-errors.ts
	Generating
	Writing

2025-02-11 15:32:17        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-events.ts
	Generating
	Writing

2025-02-11 15:32:17        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-query.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-rpc.ts
	Generating
	Writing

2025-02-11 15:32:18        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-runtime.ts
	Generating
	Writing

2025-02-11 15:32:18        REGISTRY: Unknown signed extensions StorageWeightReclaim found, treating them as no-effect
/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api-tx.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/flashbox/interfaces/augment-api.ts
	Generating
	Writing


> @tanssi/api-augment@0.800.1 generate:meta:dancelight /home/tomasz/projects/tanssi/typescript-api
> pnpm tsx node_modules/@polkadot/typegen/scripts/polkadot-types-from-chain.mjs --endpoint ./metadata-dancelight.json --package @tanssi/api-augment/tanssi/interfaces --output ./src/dancelight/interfaces

Generating from metadata, 537,742 bytes
/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-consts.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-errors.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-events.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-query.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-rpc.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-runtime.ts
	Generating
Unable to find matching version for runtime BeefyApi, expected 5
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api-tx.ts
	Generating
	Writing

/home/tomasz/projects/tanssi/typescript-api/src/dancelight/interfaces/augment-api.ts
	Generating
	Writing

Building package...

> @tanssi/api-augment@0.800.1 prebuild /home/tomasz/projects/tanssi/typescript-api
> rimraf build


> @tanssi/api-augment@0.800.1 build /home/tomasz/projects/tanssi/typescript-api
> tsc -b --verbose

[15:32:20] Projects in this build: 
    * src/dancebox/tsconfig.json
    * src/flashbox/tsconfig.json
    * src/dancelight/tsconfig.json
    * tsconfig.json

[15:32:20] Project 'src/dancebox/tsconfig.json' is out of date because output file 'build/dancebox/tsconfig.tsbuildinfo' does not exist

[15:32:20] Building project '/home/tomasz/projects/tanssi/typescript-api/src/dancebox/tsconfig.json'...

src/dancebox/interfaces/types-lookup.ts:1358:24 - error TS2304: Cannot find name 'Lookup89'.

1358     readonly asX1: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1360:24 - error TS2304: Cannot find name 'Lookup89'.

1360     readonly asX2: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1362:24 - error TS2304: Cannot find name 'Lookup89'.

1362     readonly asX3: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1364:24 - error TS2304: Cannot find name 'Lookup89'.

1364     readonly asX4: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1366:24 - error TS2304: Cannot find name 'Lookup89'.

1366     readonly asX5: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1368:24 - error TS2304: Cannot find name 'Lookup89'.

1368     readonly asX6: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1370:24 - error TS2304: Cannot find name 'Lookup89'.

1370     readonly asX7: Vec<Lookup89>;
                            ~~~~~~~~

src/dancebox/interfaces/types-lookup.ts:1372:24 - error TS2304: Cannot find name 'Lookup89'.

1372     readonly asX8: Vec<Lookup89>;
                            ~~~~~~~~

[15:32:22] Project 'src/flashbox/tsconfig.json' is out of date because output file 'build/flashbox/tsconfig.tsbuildinfo' does not exist

[15:32:22] Building project '/home/tomasz/projects/tanssi/typescript-api/src/flashbox/tsconfig.json'...

[15:32:22] Project 'src/dancelight/tsconfig.json' is out of date because output file 'build/dancelight/tsconfig.tsbuildinfo' does not exist

[15:32:22] Building project '/home/tomasz/projects/tanssi/typescript-api/src/dancelight/tsconfig.json'...

src/dancelight/interfaces/types-lookup.ts:771:24 - error TS2304: Cannot find name 'Lookup76'.

771     readonly asX1: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:773:24 - error TS2304: Cannot find name 'Lookup76'.

773     readonly asX2: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:775:24 - error TS2304: Cannot find name 'Lookup76'.

775     readonly asX3: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:777:24 - error TS2304: Cannot find name 'Lookup76'.

777     readonly asX4: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:779:24 - error TS2304: Cannot find name 'Lookup76'.

779     readonly asX5: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:781:24 - error TS2304: Cannot find name 'Lookup76'.

781     readonly asX6: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:783:24 - error TS2304: Cannot find name 'Lookup76'.

783     readonly asX7: Vec<Lookup76>;
                           ~~~~~~~~

src/dancelight/interfaces/types-lookup.ts:785:24 - error TS2304: Cannot find name 'Lookup76'.

785     readonly asX8: Vec<Lookup76>;
                           ~~~~~~~~


Found 16 errors.

 ELIFECYCLE  Command failed with exit code 2.
Error: Command failed: pnpm run build
    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at main (/home/tomasz/projects/tanssi/typescript-api/scripts/runtime-upgrade.ts:100:5)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  status: 2,
  signal: null,
  output: [ null, null, null ],
  pid: 63793,
  stdout: null,
  stderr: null
}
 ELIFECYCLE  Command failed with exit code 1.

@girazoki
Copy link
Contributor

girazoki commented Mar 4, 2025

@valentinfernandez1 for some reason we upgraded to polkadot 2412 and our type generation is generating XcmV5 junctions etc.

While I see that westend etc have also ugpraded to xcm v5, I dont see the types generated here contain the xcmv5 types, e.g., see:

api/packages/types-augment/src/lookup/types-polkadot.ts

Line 186 in 3f73f4d

interface StagingXcmV4Junctions extends Enum {

We dont know what is the process or how can we help with this

@girazoki
Copy link
Contributor

girazoki commented Mar 4, 2025

A bit more info, here is the metadata in json format:

metadata-dancebox.json

@timbrinded
Copy link
Contributor

@valentinfernandez1 We are missing the V5 type def here:

api/packages/types/src/interfaces/xcm/definitions.ts

Line 15 in cf7e2f0

import { v4 } from './v4.js';

@valentinfernandez1
Copy link
Contributor

@tmpolaczyk @girazoki sorry for the late response, I believe that with the PR that was merged with the Kusama types #6139 there is a fix necessary to address this problem.

I think that should resolve the issue, the fix will land in a release yesterday. Additionally I am also adding the V5 types definitions and will try to merge that today so it also lands on tomorrows release.

That should be enough to fix all the issues with XcmV5 compatibility. Will update this issue when the changes are live so you can test whether this is fixed.

@valentinfernandez1 valentinfernandez1 mentioned this issue May 12, 2025
Merged
@tmpolaczyk tmpolaczyk mentioned this issue May 13, 2025
Merged
@valentinfernandez1
Copy link
Contributor

valentinfernandez1 commented May 13, 2025 •
edited
Loading

Should be addressed in latest release v15.10.1. Please give it a try and let me know so that we can close this issue

@tmpolaczyk
Copy link
Author

Thanks @valentinfernandez1 , latest version seems to be working!
moondance-labs/tanssi#1026

However I see this suspicious diff in StagingXcmV5Junctions enum, where previously the variants had a Vec<Junction> but now only have a Junction. Is this expected?

Image

@valentinfernandez1
Copy link
Contributor

valentinfernandez1 commented May 13, 2025 •
edited
Loading

Nice catch!! Let me look deeper into this, it should be a Vec<StagingXcmV5Junction>

@valentinfernandez1
Copy link
Contributor

Should be addressed by #6145, will quickly merge it and do a patch release. Should be live in about an hour

@valentinfernandez1
Copy link
Contributor

Please try again with the new release v15.10.2

@tmpolaczyk
Copy link
Author

Updated to 15.10.2, is now a Vec so the fix works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@girazoki @valentinfernandez1 @tmpolaczyk @timbrinded