close() in Effects-WebSocket case study client code #3680
Unanswered
sillygoose
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I am looking at Effects-WebSocket in the Case Studies for inspiration on the design of asynchronous streams and noticed the actor close() function is never used, perhaps because a task cancelation callback is used in open() that cancels the socket and cleans up the dependancies (so no need to remember to invoke close() at a later time).
Seems to me this code could be removed but I'll admit to knowing nothing about web sockets and defer to someone with more experience on the topic.
Beta Was this translation helpful? Give feedback.
All reactions