Fix(Dashboard): fix 'pending' and 'To be validated' counter (#3584)

Author: stonebuzz

hook.php

@@ -309,6 +309,10 @@ function plugin_formcreator_addWhere($link, $nott, $itemtype, $ID, $val, $search
                   $tocheck = $item->getPendingStatusArray();
                   break;
 
+               case PluginFormcreatorFormAnswer::STATUS_WAITING:
+                  $tocheck = $item->getPendingValidationStatusArray();
+                  break;
+
                case Ticket::CLOSED:
                   $tocheck = $item->getClosedStatusArray();
                   break;

inc/formanswer.class.php

@@ -75,9 +75,9 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    public static function getStatuses() {
       return [
-         self::STATUS_WAITING  => __('Waiting', 'formcreator'),
-         self::STATUS_REFUSED  => __('Refused', 'formcreator'),
-         self::STATUS_ACCEPTED => __('Accepted', 'formcreator'),
+         self::STATUS_WAITING  => __('To validate', 'formcreator'),
+         self::STATUS_REFUSED  => __('Validation Refused', 'formcreator'),
+         self::STATUS_ACCEPTED => __('Validation Accepted', 'formcreator'),
       ];
    }
 

inc/issue.class.php

@@ -1135,7 +1135,11 @@ static function getNewStatusArray() {
    }
 
    static function getPendingStatusArray() {
-      return [Ticket::WAITING, PluginFormcreatorFormAnswer::STATUS_WAITING];
+      return [Ticket::WAITING];
+   }
+
+   static function getPendingValidationStatusArray() {
+      return [PluginFormcreatorFormAnswer::STATUS_WAITING];
    }
 
    static function getProcessStatusArray() {