Improve feature toggling exception for type offsets

SerafimArts · SerafimArts · commit 2047664e4a3c · 2025-01-11T02:15:27.000+03:00
diff --git a/resources/grammar.php b/resources/grammar.php
@@ -707,7 +707,7 @@
                     // In case of offset access type
                     case $child instanceof Node\Stmt\TypeStatement:
                         if ($this->offsets === false) {
-                            throw FeatureNotAllowedException::fromFeature('square bracket type offsets', $offset);
+                            throw FeatureNotAllowedException::fromFeature('type offsets', $offset);
                         }
 
                         $statement = new Node\Stmt\TypeOffsetAccessNode($statement, $child);
diff --git a/resources/grammar.pp2 b/resources/grammar.pp2
@@ -135,7 +135,7 @@ TypesList -> {
             // In case of offset access type
             case $child instanceof Node\Stmt\TypeStatement:
                 if ($this->offsets === false) {
-                    throw FeatureNotAllowedException::fromFeature('square bracket type offsets', $offset);
+                    throw FeatureNotAllowedException::fromFeature('type offsets', $offset);
                 }
 
                 $statement = new Node\Stmt\TypeOffsetAccessNode($statement, $child);

Original file line number	Diff line number	Diff line change
`@@ -707,7 +707,7 @@`
`707`	`707`	`// In case of offset access type`
`708`	`708`	`case $child instanceof Node\Stmt\TypeStatement:`
`709`	`709`	`if ($this->offsets === false) {`
`710`		`- throw FeatureNotAllowedException::fromFeature('square bracket type offsets', $offset);`
	`710`	`+ throw FeatureNotAllowedException::fromFeature('type offsets', $offset);`
`711`	`711`	`}`
`712`	`712`
`713`	`713`	`$statement = new Node\Stmt\TypeOffsetAccessNode($statement, $child);`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ TypesList -> {`
`135`	`135`	`// In case of offset access type`
`136`	`136`	`case $child instanceof Node\Stmt\TypeStatement:`
`137`	`137`	`if ($this->offsets === false) {`
`138`		`- throw FeatureNotAllowedException::fromFeature('square bracket type offsets', $offset);`
	`138`	`+ throw FeatureNotAllowedException::fromFeature('type offsets', $offset);`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`$statement = new Node\Stmt\TypeOffsetAccessNode($statement, $child);`