Declare strict types (#375)

* Enable strict rule and allow risky rules
* Added phpunit cache to gitignore
* Fix codestyle issues

Author: gmponos

.gitignore

@@ -1,3 +1,4 @@
+/.phpunit.result.cache
 /.php_cs.cache
 /behat.yml
 /build/

.php_cs.dist

@@ -7,9 +7,11 @@ $finder = PhpCsFixer\Finder::create()
 ;
 
 return PhpCsFixer\Config::create()
+    ->setRiskyAllowed(true)
     ->setRules([
         '@Symfony' => true,
         'array_syntax' => ['syntax' => 'short'],
+        'declare_strict_types' => true,
         'visibility_required' => [
             'elements' => [
                 'const',

src/ClientFactory/AutoDiscoveryFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Discovery\HttpClientDiscovery;

src/ClientFactory/BuzzFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Buzz\Client\FileGetContents;

src/ClientFactory/ClientFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Client\HttpClient;

src/ClientFactory/CurlFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Client\Curl\Client;

src/ClientFactory/DummyClient.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 @trigger_error('The '.__NAMESPACE__.'\DummyClient interface is deprecated since version 1.7 and will be removed in 2.0.', E_USER_DEPRECATED);

src/ClientFactory/Guzzle5Factory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use GuzzleHttp\Client;

src/ClientFactory/Guzzle6Factory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Adapter\Guzzle6\Client;

src/ClientFactory/MockFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Client\HttpClient;

src/ClientFactory/PluginClientFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 @trigger_error('The '.__NAMESPACE__.'\PluginClientFactory class is deprecated since version 1.8 and will be removed in 2.0. Use Http\Client\Common\PluginClientFactory instead.', E_USER_DEPRECATED);

src/ClientFactory/ReactFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Adapter\React\Client;

src/ClientFactory/SocketFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Http\Client\Socket\Client;

src/ClientFactory/SymfonyFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\ClientFactory;
 
 use Psr\Http\Message\ResponseFactoryInterface;

src/Collector/Collector.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Symfony\Component\HttpFoundation\Request;

src/Collector/Formatter.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Exception;

src/Collector/PluginClientFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Http\Client\Common\Plugin;

src/Collector/PluginClientFactoryListener.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Http\Client\Common\PluginClientFactory as DefaultPluginClientFactory;

src/Collector/Profile.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 /**

src/Collector/ProfileClient.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Http\Client\Common\FlexibleHttpClient;

src/Collector/ProfileClientFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Http\Client\Common\FlexibleHttpClient;

src/Collector/ProfilePlugin.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Exception;

src/Collector/Stack.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 /**

src/Collector/StackPlugin.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector;
 
 use Exception;

src/Collector/Twig/HttpMessageMarkupExtension.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Collector\Twig;
 
 use Twig\Extension\AbstractExtension;

src/DependencyInjection/Configuration.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\DependencyInjection;
 
 use Http\Client\Common\Plugin\Cache\Generator\CacheKeyGenerator;

src/DependencyInjection/HttplugExtension.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\DependencyInjection;
 
 use Http\Client\Common\BatchClient;

src/Discovery/ConfiguredClientsStrategy.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Discovery;
 
 use Http\Client\HttpClient;

src/HttplugBundle.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle;
 
 use Symfony\Component\HttpKernel\Bundle\Bundle;

tests/Functional/DiscoveredClientsTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Functional;
 
 use Http\Client\HttpAsyncClient;
@@ -11,9 +13,9 @@
 use Http\HttplugBundle\Discovery\ConfiguredClientsStrategy;
 use Nyholm\NSA;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
+use Symfony\Component\EventDispatcher\Event as LegacyEvent;
 use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Contracts\EventDispatcher\Event;
-use Symfony\Component\EventDispatcher\Event as LegacyEvent;
 
 class DiscoveredClientsTest extends WebTestCase
 {

tests/Functional/DiscoveryTest.php

@@ -1,7 +1,10 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\DependencyInjection\Compiler;
 
+use Http\Adapter\Guzzle6\Client;
 use Http\Client\HttpAsyncClient;
 use Http\Client\HttpClient;
 use Http\Discovery\HttpClientDiscovery;
@@ -13,7 +16,6 @@
 use Matthias\SymfonyDependencyInjectionTest\PhpUnit\ContainerBuilderHasAliasConstraint;
 use PHPUnit\Framework\Constraint\LogicalNot;
 use Symfony\Component\DependencyInjection\Definition;
-use Http\Adapter\Guzzle6\Client;
 
 /**
  * @author Márk Sági-Kazár <mark.sagikazar@gmail.com>

tests/Functional/ProfilerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Functional;
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;

tests/Functional/ProfilingTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Functional;
 
 use GuzzleHttp\Psr7\Request;

tests/Functional/ServiceInstantiationTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Functional;
 
 use GuzzleHttp\Psr7\Request as GuzzleRequest;

tests/Unit/ClientFactory/BuzzFactoryTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
 
 use Http\Adapter\Buzz\Client;

tests/Unit/ClientFactory/CurlFactoryTest.php

@@ -1,9 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
 
-use Http\HttplugBundle\ClientFactory\CurlFactory;
 use Http\Client\Curl\Client;
+use Http\HttplugBundle\ClientFactory\CurlFactory;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ResponseFactoryInterface;
 use Psr\Http\Message\StreamFactoryInterface;

tests/Unit/ClientFactory/Guzzle6FactoryTest.php

@@ -1,9 +1,11 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
 
-use Http\HttplugBundle\ClientFactory\Guzzle6Factory;
 use Http\Adapter\Guzzle6\Client;
+use Http\HttplugBundle\ClientFactory\Guzzle6Factory;
 use PHPUnit\Framework\TestCase;
 
 /**

tests/Unit/ClientFactory/MockFactoryTest.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /**
  * This file is part of the HttplugBundle package.
  *

tests/Unit/ClientFactory/ReactFactoryTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
 
 use Http\Adapter\React\Client;

tests/Unit/ClientFactory/SocketFactoryTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
 
 use Http\Client\Socket\Client;

tests/Unit/ClientFactory/SymfonyFactoryTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\ClientFactory;
 
 use Http\HttplugBundle\ClientFactory\SymfonyFactory;

tests/Unit/Collector/CollectorTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\Collector;
 
 use Http\HttplugBundle\Collector\Collector;

tests/Unit/Collector/FormatterTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\Collector;
 
 use GuzzleHttp\Psr7\Request;

tests/Unit/Collector/PluginClientFactoryListenerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\Collector;
 
 use Http\Client\Common\PluginClientFactory as DefaultPluginClientFactory;

tests/Unit/Collector/ProfileClientFactoryTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\Collector;
 
 use Http\Client\HttpClient;

tests/Unit/Collector/ProfileClientTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Http\HttplugBundle\Tests\Unit\Collector;
 
 use GuzzleHttp\Psr7\Request;