CA1846: Performance: Prefer 'AsSpan' over 'Substring'

Author: manfred-brands

src/NUnitConsole/nunit4-console/ConsoleRunner.cs

@@ -368,7 +368,7 @@ private void DisplayExtensionList()
 
             _outWriter.WriteLine(ColorStyle.SectionHeader, "Installed Extensions");
 
-            if (_extensionService?.ExtensionPoints != null)
+            if (_extensionService?.ExtensionPoints is not null)
                 foreach (var ep in _extensionService.ExtensionPoints)
                 {
                     _outWriter.WriteLabelLine(INDENT4 + "Extension Point: ", ep.Path);

src/NUnitConsole/nunit4-console/Options/Options.cs

@@ -225,7 +225,11 @@ private static IEnumerable<string> CreateWrappedLinesIterator(string self, IEnum
                         --end;
                         continuation = "-";
                     }
+#if NETFRAMEWORK
                     string line = self.Substring(start, end - start) + continuation;
+#else
+                    string line = string.Concat(self.AsSpan(start, end - start), continuation);
+#endif
                     yield return line;
                     start = end;
                     if (char.IsWhiteSpace(c))
@@ -1629,7 +1633,7 @@ private static string GetDescription(string? description)
                         }
                         else
                         {
-                            sb.Append(description.Substring(start, i - start));
+                            sb.Append(description, start, i - start);
                             start = -1;
                         }
                         break;