Make recipe keywords an array #1085
Closed
christianlupus
started this conversation in
Ideas and discussions
Replies: 1 comment 2 replies
-
I don't know of and don't see a reason. I implemented this in the frontend like this only because that was the data the API returned! |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
In a JSON+LD object, the
keywords
are an array of entries. We are currently mapping that into a comma-separated list of keywords stored in the*.json
files. On the frontend, the array is reconstructed and used in av-for
Vue attribute.Example locations:
cookbook/lib/Service/RecipeService.php
Lines 292 to 294 in f299ecc
cookbook/src/components/RecipeEdit.vue
Lines 518 to 523 in f299ecc
I am considering this a bad idea to do such mapping back and forth without any obvious benefit. I do not see such a benefit at the moment. However, I might be misled and there is in fact a reason for this. I am asking for you opinions on this. Any comments, @seyfeb?
Beta Was this translation helpful? Give feedback.
All reactions