Skip to content

Commit 84da0c7

Browse files
committed
Downgraded SASS to fix deprecation issues.
1 parent 18a64dc commit 84da0c7

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+456
-59
lines changed

CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## [v3.2.1](https://github.com/neonexus/sails-react-bootstrap-webpack/compare/v3.2.0...v3.2.1) (2022-11-16)
4+
5+
### Features
6+
7+
Downgraded SASS to prevent issues with deprecations.
8+
39
## [v3.2.0](https://github.com/neonexus/sails-react-bootstrap-webpack/compare/v3.1.1...v3.2.0) (2022-11-16)
410

511
### Features

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ module.exports.bootstrap = function(next) {
119119
## PwnedPasswords.com Integration
120120
When a new password is being created, it is checked with the [PwnedPasswords.com API](https://haveibeenpwned.com/API/v3#PwnedPasswords). This API uses a k-anonymity model, so the password that is searched for is never exposed to the API. Basically, the password is hashed, then the first 5 characters are sent to the API, and the API returns any hashes that start with those 5 characters, including the amount of times that hash (aka password) has been found in known security breaches.
121121

122-
This functionality is turned on by default, and can be shutoff per-use, or globally throughout the app. `sails.helpers.isPasswordValid` can be used with `skipPwned` option set to `true`, to disable the check per use. Inside of [`config/security.js`](config/security.js), the variable `checkPwned` can be set to `false` to disable it globally.
122+
This functionality is turned on by default, and can be shutoff per-use, or globally throughout the app. [`sails.helpers.isPasswordValid`](api/helpers/is-password-valid.js) can be used with `skipPwned` option set to `true`, to disable the check per use (see [`api/controllers/common/login.js`](api/controllers/common/login.js#L40) for example). Inside of [`config/security.js`](config/security.js), the variable `checkPwned` can be set to `false` to disable it globally.
123123

124124
## What about SEO?
125125
I recommend looking at [prerender.io](https://prerender.io). They offer a service (free up to 250 pages) that caches the end result of a JavaScript-rendered view (React, Vue, Angular), allowing search engines to crawl otherwise un-crawlable web views. You can use the service in a number of ways. One way, is to use the [prerender-node](https://www.npmjs.com/package/prerender-node) package. To use it with Sails, you'll have to add it to the [HTTP Middleware](https://sailsjs.com/documentation/concepts/middleware#?http-middleware). Here's a quick example:

package-lock.json

+9-9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "sails-react-bootstrap-webpack",
3-
"version": "3.2.0",
3+
"version": "3.2.1",
44
"description": "An opinionated base configuration of Sails, with Webpack for React support, and Bootstrap for styling.",
55
"keywords": [
66
"sails",
@@ -60,7 +60,7 @@
6060
"react-router-dom": "6.4.3",
6161
"react-transition-group": "4.4.5",
6262
"rimraf": "3.0.2",
63-
"sass": "1.56.1",
63+
"sass": "1.55.0",
6464
"sass-loader": "13.2.0",
6565
"style-loader": "3.3.1",
6666
"supertest": "6.3.1",

test/coverage/controllers/admin/create-api-token.js.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">controllers/
163163
<div class='footer quiet pad2 space-top1 center small'>
164164
Code coverage generated by
165165
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
166-
at Wed Nov 16 2022 00:40:07 GMT-0600 (Central Standard Time)
166+
at Wed Nov 16 2022 01:20:11 GMT-0600 (Central Standard Time)
167167
</div>
168168
<script src="../../prettify.js"></script>
169169
<script>

test/coverage/controllers/admin/create-user.js.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">controllers/
379379
<div class='footer quiet pad2 space-top1 center small'>
380380
Code coverage generated by
381381
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
382-
at Wed Nov 16 2022 00:40:07 GMT-0600 (Central Standard Time)
382+
at Wed Nov 16 2022 01:20:11 GMT-0600 (Central Standard Time)
383383
</div>
384384
<script src="../../prettify.js"></script>
385385
<script>

test/coverage/controllers/admin/delete-user.js.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">controllers/
214214
<div class='footer quiet pad2 space-top1 center small'>
215215
Code coverage generated by
216216
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
217-
at Wed Nov 16 2022 00:40:07 GMT-0600 (Central Standard Time)
217+
at Wed Nov 16 2022 01:20:11 GMT-0600 (Central Standard Time)
218218
</div>
219219
<script src="../../prettify.js"></script>
220220
<script>

0 commit comments

Comments
 (0)