Merge pull request #137 from nasirkhan/analysis-qMmgKM

Apply fixes from StyleCI

Author: nasirkhan

Modules/Article/Notifications/NewCommentAdded.php

@@ -3,10 +3,10 @@
 namespace Modules\Article\Notifications;
 
 use Illuminate\Bus\Queueable;
-use Illuminate\Notifications\Notification;
 use Illuminate\Contracts\Queue\ShouldQueue;
 use Illuminate\Notifications\Messages\MailMessage;
 use Illuminate\Notifications\Messages\SlackMessage;
+use Illuminate\Notifications\Notification;
 use Modules\Article\Entities\Comment;
 
 class NewCommentAdded extends Notification implements ShouldQueue
@@ -29,6 +29,7 @@ public function __construct(Comment $comment)
      * Get the notification's delivery channels.
      *
      * @param mixed $notifiable
+     *
      * @return array
      */
     public function via($notifiable)
@@ -40,14 +41,15 @@ public function via($notifiable)
      * Get the mail representation of the notification.
      *
      * @param mixed $notifiable
+     *
      * @return \Illuminate\Notifications\Messages\MailMessage
      */
     public function toMail($notifiable)
     {
         $comment = $this->comment;
         $user = $notifiable;
 
-        return (new MailMessage)
+        return (new MailMessage())
                     ->line('The introduction to the notification.')
                     ->action('Notification Action', 'https://laravel.com')
                     ->line('Thank you for using our application!');
@@ -56,25 +58,26 @@ public function toMail($notifiable)
     /**
      * Get the Slack representation of the notification.
      *
-     * @param  mixed  $notifiable
+     * @param mixed $notifiable
+     *
      * @return SlackMessage
      */
     public function toSlack($notifiable)
     {
         $comment = $this->comment;
         $user = $notifiable;
 
-        return (new SlackMessage)
+        return (new SlackMessage())
                 ->success()
                 ->from('BlueCube', ':incoming_envelope:')
                 ->content('New Comment: '.$comment->name.' | From:'.$comment->user_name)
                 ->attachment(function ($attachment) use ($comment) {
-                    $attachment->title('Comment '.$comment->id, route('backend.comments.show',$comment->id))
+                    $attachment->title('Comment '.$comment->id, route('backend.comments.show', $comment->id))
                     ->fields([
-                        'Post' => $comment->post_name,
-                        'User' => $comment->user_name,
+                        'Post'    => $comment->post_name,
+                        'User'    => $comment->user_name,
                         'Comment' => $comment->name,
-                        'Status' => $comment->status_label_text,
+                        'Status'  => $comment->status_label_text,
                     ]);
                 });
     }
@@ -83,6 +86,7 @@ public function toSlack($notifiable)
      * Get the array representation of the notification.
      *
      * @param mixed $notifiable
+     *
      * @return array
      */
     public function toArray($notifiable)
@@ -91,14 +95,14 @@ public function toArray($notifiable)
         $user = $notifiable;
 
         return [
-            'id' => $comment->id,
-            'name' => $comment->name,
-            'comment' => $comment->comment,
-            'post_id' => $comment->post_id,
+            'id'        => $comment->id,
+            'name'      => $comment->name,
+            'comment'   => $comment->comment,
+            'post_id'   => $comment->post_id,
             'post_name' => $comment->post_name,
-            'user_id' => $comment->user_id,
+            'user_id'   => $comment->user_id,
             'user_name' => $comment->user_name,
-            'status' => $comment->status,
+            'status'    => $comment->status,
         ];
     }
 }

app/Models/User.php

@@ -89,7 +89,8 @@ public function setPasswordAttribute($password)
     /**
      * Route notifications for the Slack channel.
      *
-     * @param  \Illuminate\Notifications\Notification  $notification
+     * @param \Illuminate\Notifications\Notification $notification
+     *
      * @return string
      */
     public function routeNotificationForSlack($notification)

database/migrations/2019_07_08_104305_create_failed_jobs_table.php

@@ -1,8 +1,8 @@
 <?php
 
-use Illuminate\Support\Facades\Schema;
-use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
 
 class CreateFailedJobsTable extends Migration
 {