fix: ensure CompanyName, CompanyIdentification, and CompanyEntryDescription are non-zero

Issue: #1600

Author: adamdecaf

batchHeader.go

@@ -316,15 +316,27 @@ func (bh *BatchHeader) Validate() error {
 		if err := bh.isAlphanumeric(bh.CompanyName); err != nil {
 			return fieldError("CompanyName", err, bh.CompanyName)
 		}
+		if err := bh.isNonZero(bh.CompanyName); err != nil {
+			return fieldError("CompanyName", err, bh.CompanyName)
+		}
+
 		if err := bh.isAlphanumeric(bh.CompanyDiscretionaryData); err != nil {
 			return fieldError("CompanyDiscretionaryData", err, bh.CompanyDiscretionaryData)
 		}
+
 		if err := bh.isAlphanumeric(bh.CompanyIdentification); err != nil {
 			return fieldError("CompanyIdentification", err, bh.CompanyIdentification)
 		}
+		if err := bh.isNonZero(bh.CompanyIdentification); err != nil {
+			return fieldError("CompanyIdentification", err, bh.CompanyIdentification)
+		}
+
 		if err := bh.isAlphanumeric(bh.CompanyEntryDescription); err != nil {
 			return fieldError("CompanyEntryDescription", err, bh.CompanyEntryDescription)
 		}
+		if err := bh.isNonZero(bh.CompanyEntryDescription); err != nil {
+			return fieldError("CompanyEntryDescription", err, bh.CompanyEntryDescription)
+		}
 	}
 	return nil
 }

batchHeader_test.go

@@ -269,6 +269,27 @@ func BenchmarkBatchHeaderFieldInclusion(b *testing.B) {
 	}
 }
 
+func TestBatchHeader_CompanyIdentificationZeros(t *testing.T) {
+	bh := mockBatchHeader()
+	bh.CompanyIdentification = strings.Repeat("0", 10)
+	err := bh.Validate()
+	require.ErrorContains(t, err, "CompanyIdentification 0000000000 contains only spaces and zeros")
+}
+
+func TestBatchHeader_CompanyNameZeros(t *testing.T) {
+	bh := mockBatchHeader()
+	bh.CompanyName = "000  000"
+	err := bh.Validate()
+	require.ErrorContains(t, err, "CompanyName 000  000 contains only spaces and zeros")
+}
+
+func TestBatchHeader_CompanyEntryDescriptionZeros(t *testing.T) {
+	bh := mockBatchHeader()
+	bh.CompanyEntryDescription = "  000  "
+	err := bh.Validate()
+	require.ErrorContains(t, err, "CompanyEntryDescription   000   contains only spaces and zeros")
+}
+
 // testBatchHeaderCompanyNameAlphaNumeric validates batch header company name is alphanumeric
 func testBatchHeaderCompanyNameAlphaNumeric(t testing.TB) {
 	bh := mockBatchHeader()

validators.go

@@ -25,6 +25,7 @@ import (
 	"strconv"
 	"strings"
 	"time"
+	"unicode"
 	"unicode/utf8"
 )
 
@@ -435,6 +436,20 @@ func (v *validator) isAlphanumeric(s string) error {
 	return nil
 }
 
+var (
+	ErrOnlyZeros = errors.New("contains only spaces and zeros")
+)
+
+// isNonZero checks if a string is not blank and non-zero
+func (v *validator) isNonZero(s string) error {
+	for _, r := range s {
+		if !unicode.IsSpace(r) && r != '0' {
+			return nil
+		}
+	}
+	return ErrOnlyZeros
+}
+
 // CalculateCheckDigit returns a check digit for a routing number
 // Multiply each digit in the Routing number by a weighting factor. The weighting factors for each digit are:
 // Position: 1 2 3 4 5 6 7 8

validators_test.go

@@ -227,6 +227,49 @@ func TestValidators__isAlphanumericExamples(t *testing.T) {
 	})
 }
 
+func TestValidators__isNonZero(t *testing.T) {
+	v := &validator{}
+
+	cases := []struct {
+		input string
+		err   error
+	}{
+		{
+			input: "",
+			err:   ErrOnlyZeros,
+		},
+		{
+			input: " ",
+			err:   ErrOnlyZeros,
+		},
+		{
+			input: "0",
+			err:   ErrOnlyZeros,
+		},
+		{
+			input: "0 0",
+			err:   ErrOnlyZeros,
+		},
+		{
+			input: "    000   ",
+			err:   ErrOnlyZeros,
+		},
+		// Valid cases
+		{input: "abc"},
+		{input: "000 123 a "},
+	}
+	for _, tc := range cases {
+		t.Run(tc.input, func(t *testing.T) {
+			err := v.isNonZero(tc.input)
+			if tc.err == nil {
+				require.NoError(t, err)
+			} else {
+				require.ErrorIs(t, tc.err, ErrOnlyZeros)
+			}
+		})
+	}
+}
+
 func TestValidators__validateJulianDay(t *testing.T) {
 	empty := "   "
 	cases := map[string]string{