fix: fix enumeration for authentication response (#118)

kleyow · web-flow · commit 29e64f07c3ac · 2022-02-17T14:34:35.000-05:00
* fix: fix enumeration for authentication response

* chore: build

* chore: rebuild
diff --git a/docs/thirdparty-openapi3-snippets.yaml b/docs/thirdparty-openapi3-snippets.yaml
@@ -3027,7 +3027,7 @@ paths:
                                 - "FIDO" - A FIDO public/private keypair
                                 - "GENERIC" - A Generic public/private keypair
                             status:
-                              title: CredentialStatus
+                              title: CredentialStatusPending
                               type: string
                               enum: &ref_115
                                 - PENDING
@@ -3454,7 +3454,7 @@ paths:
                       type: object
                       properties:
                         status:
-                          title: CredentialStatus
+                          title: CredentialStatusVerified
                           type: string
                           enum: &ref_128
                             - VERIFIED
@@ -6639,14 +6639,14 @@ paths:
           application/json:
             schema:
               oneOf:
-                - title: ThirdpartyRequestsAuthorizationsIDPutResponseGeneric
+                - title: ThirdpartyRequestsAuthorizationsIDPutResponseRejected
                   type: object
                   description: >-
                     The object sent in the PUT
                     /thirdpartyRequests/authorizations/{ID} callback.
                   properties: &ref_147
                     responseType:
-                      title: AuthorizationResponseType
+                      title: AuthorizationResponseTypeRejected
                       description: |
                         The customer rejected the terms of the transfer.
                       type: string
@@ -7426,7 +7426,7 @@ paths:
         information regarding a previously created or requested authorization.
         The *{ID}*
 
-        in the URI should contain the verification request ID 
+        in the URI should contain the verification request ID
       parameters:
         - name: Accept
           in: header
@@ -7476,18 +7476,17 @@ paths:
         - sampled
       operationId: PutThirdpartyRequestsVerificationsById
       summary: PutThirdpartyRequestsVerificationsById
-      description: >
+      description: >-
         The HTTP request `PUT /thirdpartyRequests/verifications/{ID}` is used by
-        the Auth-Service to inform
-
-        the DFSP of a successful result in validating the verification of a
-        Thirdparty Transaction Request.
+        the Auth-Service to inform the DFSP of a successful result in validating
+        the verification of a Thirdparty Transaction Request.
 
+        If the validation fails, the auth-service will send back `PUT
+        /thirdpartyRequests/verifications/{ID}` with `authenticationResponse:
+        'REJECTED'`.
 
-        If the validation fails, The Auth-Service MUST use `PUT
-        /thirdpartyRequests/verifications/{ID}/error`
-
-        instead.
+        In unplanned error cases the Auth-Service MUST use `PUT
+        /thirdpartyRequests/verifications/{ID}/error`.
       parameters:
         - name: Content-Length
           in: header
@@ -7511,13 +7510,21 @@ paths:
               description: >-
                 The object sent in the PUT
                 /thirdpartyRequests/verifications/{ID} request.
-              properties: &ref_157
+              properties: &ref_158
                 authenticationResponse:
+                  title: AuthenticationResponse
                   type: string
-                  enum:
+                  enum: &ref_157
                     - VERIFIED
-                  description: The verification passed
-              required: &ref_158
+                    - REJECTED
+                  description: >-
+                    Below are the allowed values for the enumeration
+                    AuthenticationResponse.
+
+                    - VERIFIED - The challenge was correctly signed.
+
+                    - REJECTED - The challenge was not correctly signed.
+              required: &ref_159
                 - authenticationResponse
             example:
               authenticationResponse: VERIFIED
@@ -8490,7 +8497,7 @@ components:
         - "FIDO" - A FIDO public/private keypair
         - "GENERIC" - A Generic public/private keypair
     CredentialStatusPending:
-      title: CredentialStatus
+      title: CredentialStatusPending
       type: string
       enum: *ref_115
       description: |
@@ -8618,7 +8625,7 @@ components:
       required: *ref_127
       additionalProperties: false
     CredentialStatusVerified:
-      title: CredentialStatus
+      title: CredentialStatusVerified
       type: string
       enum: *ref_128
       description: |
@@ -8708,13 +8715,13 @@ components:
       required: *ref_145
       additionalProperties: false
     AuthorizationResponseTypeRejected:
-      title: AuthorizationResponseType
+      title: AuthorizationResponseTypeRejected
       description: |
         The customer rejected the terms of the transfer.
       type: string
       enum: *ref_146
     ThirdpartyRequestsAuthorizationsIDPutResponseRejected:
-      title: ThirdpartyRequestsAuthorizationsIDPutResponseGeneric
+      title: ThirdpartyRequestsAuthorizationsIDPutResponseRejected
       type: object
       description: >-
         The object sent in the PUT /thirdpartyRequests/authorizations/{ID}
@@ -8780,14 +8787,22 @@ components:
       description: The object sent in the POST /thirdpartyRequests/verifications request.
       properties: *ref_155
       required: *ref_156
+    AuthenticationResponse:
+      title: AuthenticationResponse
+      type: string
+      enum: *ref_157
+      description: |-
+        Below are the allowed values for the enumeration AuthenticationResponse.
+        - VERIFIED - The challenge was correctly signed.
+        - REJECTED - The challenge was not correctly signed.
     ThirdpartyRequestsVerificationsIDPutResponse:
       title: ThirdpartyRequestsVerificationsIDPutResponse
       type: object
       description: >-
         The object sent in the PUT /thirdpartyRequests/verifications/{ID}
         request.
-      properties: *ref_157
-      required: *ref_158
+      properties: *ref_158
+      required: *ref_159
   parameters:
     ID:
       name: ID
diff --git a/package.json b/package.json
@@ -4,6 +4,9 @@
   "description": "Mojaloop API specification reusable snippets",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
+  "engines": {
+    "node": ">=12.0.0"
+  },
   "scripts": {
     "audit:resolve": "SHELL=sh resolve-audit --production",
     "audit:check": "SHELL=sh check-audit --production",
diff --git a/src/thirdparty/index.ts b/src/thirdparty/index.ts
@@ -9,6 +9,7 @@ export namespace Schemas {
   export type AccountsIDPutResponse = components['schemas']['AccountsIDPutResponse']
   export type Amount = components['schemas']['Amount']
   export type AmountType = components['schemas']['AmountType']
+  export type AuthenticationResponse = components['schemas']['AuthenticationResponse']
   export type AuthenticationType = components['schemas']['AuthenticationType']
   export type AuthorizationChannelType = components['schemas']['AuthorizationChannelType']
   export type AuthorizationResponseType = components['schemas']['AuthorizationResponseType']
diff --git a/src/thirdparty/openapi.ts b/src/thirdparty/openapi.ts
@@ -19144,11 +19144,9 @@ export interface operations {
     };
   };
   /**
-   * The HTTP request `PUT /thirdpartyRequests/verifications/{ID}` is used by the Auth-Service to inform
-   * the DFSP of a successful result in validating the verification of a Thirdparty Transaction Request.
-   *
-   * If the validation fails, The Auth-Service MUST use `PUT /thirdpartyRequests/verifications/{ID}/error`
-   * instead.
+   * The HTTP request `PUT /thirdpartyRequests/verifications/{ID}` is used by the Auth-Service to inform the DFSP of a successful result in validating the verification of a Thirdparty Transaction Request.
+   * If the validation fails, the auth-service will send back `PUT /thirdpartyRequests/verifications/{ID}` with `authenticationResponse: 'REJECTED'`.
+   * In unplanned error cases the Auth-Service MUST use `PUT /thirdpartyRequests/verifications/{ID}/error`.
    */
   PutThirdpartyRequestsVerificationsById: {
     parameters: {
@@ -19164,9 +19162,11 @@ export interface operations {
     requestBody: {
       "application/json": {
         /**
-         * The verification passed
+         * Below are the allowed values for the enumeration AuthenticationResponse.
+         * - VERIFIED - The challenge was correctly signed.
+         * - REJECTED - The challenge was not correctly signed.
          */
-        authenticationResponse: "VERIFIED";
+        authenticationResponse: "VERIFIED" | "REJECTED";
       };
     };
     responses: {
@@ -26889,14 +26889,22 @@ export interface components {
        */
       genericSignedPayload: string;
     };
+    /**
+     * Below are the allowed values for the enumeration AuthenticationResponse.
+     * - VERIFIED - The challenge was correctly signed.
+     * - REJECTED - The challenge was not correctly signed.
+     */
+    AuthenticationResponse: "VERIFIED" | "REJECTED";
     /**
      * The object sent in the PUT /thirdpartyRequests/verifications/{ID} request.
      */
     ThirdpartyRequestsVerificationsIDPutResponse: {
       /**
-       * The verification passed
+       * Below are the allowed values for the enumeration AuthenticationResponse.
+       * - VERIFIED - The challenge was correctly signed.
+       * - REJECTED - The challenge was not correctly signed.
        */
-      authenticationResponse: "VERIFIED";
+      authenticationResponse: "VERIFIED" | "REJECTED";
     };
   };
   responses: {
diff --git a/thirdparty/openapi3/components/schemas/AuthenticationResponse.yaml b/thirdparty/openapi3/components/schemas/AuthenticationResponse.yaml
@@ -0,0 +1,9 @@
+title: AuthenticationResponse
+type: string
+enum:
+  - VERIFIED
+  - REJECTED
+description: |-
+  Below are the allowed values for the enumeration AuthenticationResponse.
+  - VERIFIED - The challenge was correctly signed.
+  - REJECTED - The challenge was not correctly signed.
diff --git a/thirdparty/openapi3/components/schemas/AuthorizationResponseTypeRejected.yaml b/thirdparty/openapi3/components/schemas/AuthorizationResponseTypeRejected.yaml
@@ -1,4 +1,4 @@
-title: AuthorizationResponseType
+title: AuthorizationResponseTypeRejected
 description: |
   The customer rejected the terms of the transfer.
 type: string
diff --git a/thirdparty/openapi3/components/schemas/CredentialStatusPending.yaml b/thirdparty/openapi3/components/schemas/CredentialStatusPending.yaml
@@ -1,4 +1,4 @@
-title: CredentialStatus
+title: CredentialStatusPending
 type: string
 enum:
   - PENDING
diff --git a/thirdparty/openapi3/components/schemas/CredentialStatusVerified.yaml b/thirdparty/openapi3/components/schemas/CredentialStatusVerified.yaml
@@ -1,4 +1,4 @@
-title: CredentialStatus
+title: CredentialStatusVerified
 type: string
 enum:
   - VERIFIED
diff --git a/thirdparty/openapi3/components/schemas/SignedCredential.yaml b/thirdparty/openapi3/components/schemas/SignedCredential.yaml
@@ -12,7 +12,7 @@ properties:
     $ref: ./CredentialType.yaml
   # The challenge has signed but not yet verified.
   status:
-   $ref: ./CredentialStatusPending.yaml
+    $ref: ./CredentialStatusPending.yaml
   genericPayload:
     $ref: ./GenericCredential.yaml
   fidoPayload:
diff --git a/thirdparty/openapi3/components/schemas/ThirdpartyRequestsAuthorizationsIDPutResponseRejected.yaml b/thirdparty/openapi3/components/schemas/ThirdpartyRequestsAuthorizationsIDPutResponseRejected.yaml
@@ -1,8 +1,8 @@
-title: ThirdpartyRequestsAuthorizationsIDPutResponseGeneric
+title: ThirdpartyRequestsAuthorizationsIDPutResponseRejected
 type: object
 description: 'The object sent in the PUT /thirdpartyRequests/authorizations/{ID} callback.'
 properties:
-  responseType: 
-    $ref: ./AuthorizationResponseTypeRejected.yaml  
+  responseType:
+    $ref: ./AuthorizationResponseTypeRejected.yaml
 required:
   - responseType
diff --git a/thirdparty/openapi3/components/schemas/ThirdpartyRequestsVerificationsIDPutResponse.yaml b/thirdparty/openapi3/components/schemas/ThirdpartyRequestsVerificationsIDPutResponse.yaml
@@ -3,10 +3,6 @@ type: object
 description: The object sent in the PUT /thirdpartyRequests/verifications/{ID} request.
 properties:
   authenticationResponse:
-    type: string
-    enum:
-      - VERIFIED
-    description: 'The verification passed'
+    $ref: ./AuthenticationResponse.yaml
 required:
   - authenticationResponse
-  
diff --git a/thirdparty/openapi3/components/schemas/index.yaml b/thirdparty/openapi3/components/schemas/index.yaml
@@ -9,11 +9,13 @@ Amount:
 AmountType:
   $ref: ./AmountType.yaml
 AuthenticationInfo:
-   $ref: ./AuthenticationInfo.yaml
+  $ref: ./AuthenticationInfo.yaml
+AuthenticationResponse:
+  $ref: ./AuthenticationResponse.yaml
 AuthenticationType:
   $ref: ./AuthenticationType.yaml
 AuthenticationValue:
-   $ref: ./AuthenticationValue.yaml
+  $ref: ./AuthenticationValue.yaml
 AuthorizationChannelType:
   $ref: ./AuthorizationChannelType.yaml
 AuthorizationResponseType:
diff --git a/thirdparty/openapi3/paths/thirdpartyRequests_verifications_ID.yaml b/thirdparty/openapi3/paths/thirdpartyRequests_verifications_ID.yaml
@@ -20,7 +20,7 @@ get:
   description: |
     The HTTP request `/thirdpartyRequests/verifications/{ID}` is used to get
     information regarding a previously created or requested authorization. The *{ID}*
-    in the URI should contain the verification request ID 
+    in the URI should contain the verification request ID
   parameters:
     #Headers
     - $ref: ../components/parameters/Accept.yaml
@@ -49,12 +49,14 @@ put:
     - sampled
   operationId: PutThirdpartyRequestsVerificationsById
   summary: PutThirdpartyRequestsVerificationsById
-  description: |
+  description: >-
     The HTTP request `PUT /thirdpartyRequests/verifications/{ID}` is used by the Auth-Service to inform
     the DFSP of a successful result in validating the verification of a Thirdparty Transaction Request.
 
-    If the validation fails, The Auth-Service MUST use `PUT /thirdpartyRequests/verifications/{ID}/error`
-    instead.
+    If the validation fails, the auth-service will send back `PUT /thirdpartyRequests/verifications/{ID}`
+    with `authenticationResponse: 'REJECTED'`.
+
+    In unplanned error cases the Auth-Service MUST use `PUT /thirdpartyRequests/verifications/{ID}/error`.
   parameters:
     - $ref: ../components/parameters/Content-Length.yaml
   requestBody:

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-title: AuthorizationResponseType`
	`1`	`+title: AuthorizationResponseTypeRejected`
`2`	`2`	`description: \|`
`3`	`3`	`The customer rejected the terms of the transfer.`
`4`	`4`	`type: string`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-title: CredentialStatus`
	`1`	`+title: CredentialStatusPending`
`2`	`2`	`type: string`
`3`	`3`	`enum:`
`4`	`4`	`- PENDING`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-title: CredentialStatus`
	`1`	`+title: CredentialStatusVerified`
`2`	`2`	`type: string`
`3`	`3`	`enum:`
`4`	`4`	`- VERIFIED`