Skip to content

Commit 8cbb8ed

Browse files
committed
Add 'provider' field to agent test cases
The 'provider' field has been added throughout the MindsDB SDK testing. This change reflects recent updates to the agent model within the SDK, accommodating for new data required for agent instantiation and manipulation. Modification is done in codebase, while maintaining existing functionality and ensuring compatibility with newer versions.
1 parent 4c29c57 commit 8cbb8ed

File tree

1 file changed

+64
-46
lines changed

1 file changed

+64
-46
lines changed

tests/test_sdk.py

+64-46
Original file line numberDiff line numberDiff line change
@@ -1251,7 +1251,8 @@ def test_list(self, mock_get):
12511251
'skills': [],
12521252
'params': {},
12531253
'created_at': created_at,
1254-
'updated_at': updated_at
1254+
'updated_at': updated_at,
1255+
'provider': 'mindsdb'
12551256
}
12561257
])
12571258
all_agents = server.agents.list()
@@ -1265,7 +1266,8 @@ def test_list(self, mock_get):
12651266
[],
12661267
{},
12671268
created_at,
1268-
updated_at
1269+
updated_at,
1270+
'mindsdb'
12691271
)
12701272
assert all_agents[0] == expected_agent
12711273

@@ -1283,7 +1285,8 @@ def test_get(self, mock_get):
12831285
'skills': [],
12841286
'params': {},
12851287
'created_at': created_at,
1286-
'updated_at': updated_at
1288+
'updated_at': updated_at,
1289+
'provider': 'mindsdb'
12871290
}
12881291
)
12891292
agent = server.agents.get('test_agent')
@@ -1295,7 +1298,8 @@ def test_get(self, mock_get):
12951298
[],
12961299
{},
12971300
created_at,
1298-
updated_at
1301+
updated_at,
1302+
'mindsdb'
12991303
)
13001304
assert agent == expected_agent
13011305

@@ -1318,7 +1322,8 @@ def test_create(self, mock_get, mock_post):
13181322
}],
13191323
'params': {'k1': 'v1'},
13201324
'created_at': created_at,
1321-
'updated_at': updated_at
1325+
'updated_at': updated_at,
1326+
'provider': 'mindsdb',
13221327
}
13231328
responses_mock(mock_post, [
13241329
# ML Engine get (SQL post for SHOW ML_ENGINES)
@@ -1344,9 +1349,10 @@ def test_create(self, mock_get, mock_post):
13441349
assert mock_post.call_args_list[-1][1]['json'] == {
13451350
'agent': {
13461351
'name': 'test_agent',
1347-
'model_name':'m1',
1352+
'model_name': 'm1',
13481353
'skills': ['test_skill'],
1349-
'params': {'k1': 'v1'}
1354+
'params': {'k1': 'v1'},
1355+
'provider': None
13501356
}
13511357
}
13521358
expected_skill = SQLSkill('test_skill', ['test_table'], 'test_database', 'test_description')
@@ -1356,7 +1362,8 @@ def test_create(self, mock_get, mock_post):
13561362
[expected_skill],
13571363
{'k1': 'v1'},
13581364
created_at,
1359-
updated_at
1365+
updated_at,
1366+
'mindsdb'
13601367
)
13611368

13621369
assert new_agent == expected_agent
@@ -1383,7 +1390,8 @@ def test_update(self, mock_get, mock_put, _):
13831390
}],
13841391
'params': {'k2': 'v2'},
13851392
'created_at': created_at,
1386-
'updated_at': updated_at
1393+
'updated_at': updated_at,
1394+
'provider': 'mindsdb',
13871395
}
13881396
response_mock(mock_put, data)
13891397

@@ -1395,6 +1403,7 @@ def test_update(self, mock_get, mock_put, _):
13951403
'model_name': 'test_model',
13961404
'skills': [],
13971405
'params': {'k1': 'v1'},
1406+
'provider': 'mindsdb',
13981407
})
13991408

14001409
server = mindsdb_sdk.connect()
@@ -1404,7 +1413,8 @@ def test_update(self, mock_get, mock_put, _):
14041413
[SQLSkill('updated_skill', ['updated_table'], 'updated_database', 'test_description')],
14051414
{'k2': 'v2'},
14061415
created_at,
1407-
updated_at
1416+
updated_at,
1417+
'mindsdb'
14081418
)
14091419

14101420
updated_agent = server.agents.update('test_agent', expected_agent)
@@ -1467,7 +1477,8 @@ def test_add_file(self, mock_post, mock_put, mock_get):
14671477
'skills': [],
14681478
'params': {},
14691479
'created_at': None,
1470-
'updated_at': None
1480+
'updated_at': None,
1481+
'provider': 'mindsdb'
14711482
},
14721483
# Skills get in Agent update to check if it exists.
14731484
{'name': 'new_skill', 'type': 'retrieval', 'params': {'source': 'test_agent_tokaido_rules_kb'}},
@@ -1478,7 +1489,8 @@ def test_add_file(self, mock_post, mock_put, mock_get):
14781489
'skills': [],
14791490
'params': {},
14801491
'created_at': None,
1481-
'updated_at': None
1492+
'updated_at': None,
1493+
'provider': 'mindsdb'
14821494
},
14831495
])
14841496
responses_mock(mock_post, [
@@ -1499,7 +1511,8 @@ def test_add_file(self, mock_post, mock_put, mock_get):
14991511
'skills': [{'name': 'new_skill', 'type': 'retrieval', 'params': {'source': 'test_agent_tokaido_rules_kb'}}],
15001512
'params': {},
15011513
'created_at': None,
1502-
'updated_at': None
1514+
'updated_at': None,
1515+
'provider': 'mindsdb'
15031516
},
15041517
])
15051518
server.agents.add_file('test_agent', './tokaido_rules.pdf', 'Rules for the board game Tokaido', 'existing_kb')
@@ -1518,7 +1531,6 @@ def test_add_file(self, mock_post, mock_put, mock_get):
15181531
}
15191532
assert agent_update_json == expected_agent_json
15201533

1521-
15221534
@patch('requests.Session.get')
15231535
@patch('requests.Session.put')
15241536
@patch('requests.Session.post')
@@ -1527,58 +1539,61 @@ def test_add_webpage(self, mock_post, mock_put, mock_get):
15271539
responses_mock(mock_get, [
15281540
# Existing agent get.
15291541
{
1530-
'name': 'test_agent',
1531-
'model_name': 'test_model',
1532-
'skills': [],
1533-
'params': {},
1534-
'created_at': None,
1535-
'updated_at': None
1542+
'name':'test_agent',
1543+
'model_name':'test_model',
1544+
'skills':[],
1545+
'params':{},
1546+
'created_at':None,
1547+
'updated_at':None,
1548+
'provider':'mindsdb'
15361549
},
15371550
# Skills get in Agent update to check if it exists.
1538-
{'name': 'new_skill', 'type': 'retrieval', 'params': {'source': 'test_agent_docs_mdb_ai_kb'}},
1551+
{'name':'new_skill', 'type':'retrieval', 'params':{'source':'test_agent_docs_mdb_ai_kb'}},
15391552
# Existing agent get in Agent update.
15401553
{
1541-
'name': 'test_agent',
1542-
'model_name': 'test_model',
1543-
'skills': [],
1544-
'params': {},
1545-
'created_at': None,
1546-
'updated_at': None
1554+
'name':'test_agent',
1555+
'model_name':'test_model',
1556+
'skills':[],
1557+
'params':{},
1558+
'created_at':None,
1559+
'updated_at':None,
1560+
'provider':'mindsdb' # Added provider field
15471561
},
15481562
])
15491563
responses_mock(mock_post, [
15501564
# KB get (POST /sql).
15511565
pd.DataFrame([
1552-
{'name': 'test_agent_docs_mdb_ai_kb', 'storage': None, 'model': None},
1566+
{'name':'test_agent_docs_mdb_ai_kb', 'storage':None, 'model':None},
15531567
]),
15541568
# Skill creation.
1555-
{'name': 'new_skill', 'type': 'retrieval', 'params': {'source': 'test_agent_docs_mdb_ai_kb'}}
1569+
{'name':'new_skill', 'type':'retrieval', 'params':{'source':'test_agent_docs_mdb_ai_kb'}}
15561570
])
15571571
responses_mock(mock_put, [
15581572
# KB update.
1559-
{'name': 'test_agent_docs_mdb_ai_kb'},
1573+
{'name':'test_agent_docs_mdb_ai_kb'},
15601574
# Agent update with new skill.
15611575
{
1562-
'name': 'test_agent',
1563-
'model_name': 'test_model',
1564-
'skills': [{'name': 'new_skill', 'type': 'retrieval', 'params': {'source': 'test_agent_docs_mdb_ai_kb'}}],
1565-
'params': {},
1566-
'created_at': None,
1567-
'updated_at': None
1576+
'name':'test_agent',
1577+
'model_name':'test_model',
1578+
'skills':[{'name':'new_skill', 'type':'retrieval', 'params':{'source':'test_agent_docs_mdb_ai_kb'}}],
1579+
'params':{},
1580+
'created_at':None,
1581+
'updated_at':None,
1582+
'provider':'mindsdb' # Added provider field
15681583
},
15691584
])
15701585
server.agents.add_webpage('test_agent', 'docs.mdb.ai', 'Documentation for MindsDB', 'existing_kb')
15711586

15721587
# Check Agent was updated with a new skill.
15731588
agent_update_json = mock_put.call_args[-1]['json']
15741589
expected_agent_json = {
1575-
'agent': {
1576-
'name': 'test_agent',
1577-
'model_name': 'test_model',
1590+
'agent':{
1591+
'name':'test_agent',
1592+
'model_name':'test_model',
15781593
# Skill name is a generated UUID.
1579-
'skills_to_add': [agent_update_json['agent']['skills_to_add'][0]],
1580-
'skills_to_remove': [],
1581-
'params': {},
1594+
'skills_to_add':[agent_update_json['agent']['skills_to_add'][0]],
1595+
'skills_to_remove':[],
1596+
'params':{},
15821597
}
15831598
}
15841599
assert agent_update_json == expected_agent_json
@@ -1596,7 +1611,8 @@ def test_add_database(self, mock_post, mock_put, mock_get):
15961611
'skills': [],
15971612
'params': {},
15981613
'created_at': None,
1599-
'updated_at': None
1614+
'updated_at': None,
1615+
'provider': 'mindsdb'
16001616
},
16011617
# Skills get in Agent update to check if it exists.
16021618
{'name': 'new_skill', 'type': 'sql', 'params': {'database': 'existing_db', 'tables': ['existing_table']}},
@@ -1607,7 +1623,8 @@ def test_add_database(self, mock_post, mock_put, mock_get):
16071623
'skills': [],
16081624
'params': {},
16091625
'created_at': None,
1610-
'updated_at': None
1626+
'updated_at': None,
1627+
'provider': 'mindsdb'
16111628
},
16121629
])
16131630
responses_mock(mock_post, [
@@ -1630,7 +1647,8 @@ def test_add_database(self, mock_post, mock_put, mock_get):
16301647
'skills': [{'name': 'new_skill', 'type': 'sql', 'params': {'database': 'existing_db', 'tables': ['existing_table']}}],
16311648
'params': {},
16321649
'created_at': None,
1633-
'updated_at': None
1650+
'updated_at': None,
1651+
'provider': 'mindsdb'
16341652
},
16351653
])
16361654
server.agents.add_database('test_agent', 'existing_db', ['existing_table'], 'My data')
@@ -1644,7 +1662,7 @@ def test_add_database(self, mock_post, mock_put, mock_get):
16441662
# Skill name is a generated UUID.
16451663
'skills_to_add': [agent_update_json['agent']['skills_to_add'][0]],
16461664
'skills_to_remove': [],
1647-
'params': {},
1665+
'params': {'prompt_template': 'using mindsdb sqltoolbox'},
16481666
}
16491667
}
16501668
assert agent_update_json == expected_agent_json

0 commit comments

Comments
 (0)