Skip to content

Commit c107eb7

Browse files
committed
- refactors vararg implementation to reduce the amount of generated code
1 parent 35456e2 commit c107eb7

9 files changed

+9
-18
lines changed

Templates/Java/requests_extensions/BaseEntityCollectionReferenceRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
1010
import <#=importNamespace#>.http.BaseRequestBuilder;
1111
import <#=importNamespace#>.core.IBaseClient;
12-
import java.util.Arrays;
1312

1413
<#=TypeHelperJava.CreateClassDef(c.TypeCollectionReferenceRequestBuilder(), "BaseRequestBuilder", c.ITypeCollectionReferenceRequestBuilder())#>
1514

@@ -31,7 +30,7 @@ import java.util.Arrays;
3130
* @return the IUserRequest instance
3231
*/
3332
public <#=c.ITypeCollectionReferenceRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
34-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
33+
return buildRequest(getOptions(requestOptions));
3534
}
3635

3736
/**

Templates/Java/requests_extensions/BaseEntityCollectionRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ import <#=mainNamespace#>.<#=TypeHelperJava.GetPrefixForRequests()#>.<#=method.I
3232
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
3333
import <#=importNamespace#>.http.BaseRequestBuilder;
3434
import <#=importNamespace#>.core.IBaseClient;
35-
import java.util.Arrays;
3635

3736
<#=TypeHelperJava.CreateClassDef(c.TypeCollectionRequestBuilder(), "BaseRequestBuilder", c.ITypeCollectionRequestBuilder())#>
3837

@@ -54,7 +53,7 @@ import java.util.Arrays;
5453
* @return the IUserRequest instance
5554
*/
5655
public <#=c.ITypeCollectionRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
57-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
56+
return buildRequest(getOptions(requestOptions));
5857
}
5958

6059
/**

Templates/Java/requests_extensions/BaseEntityCollectionWithReferencesRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
1010
import <#=importNamespace#>.http.BaseRequestBuilder;
1111
import <#=importNamespace#>.core.IBaseClient;
12-
import java.util.Arrays;
1312

1413
<#=TypeHelperJava.CreateClassDef(c.TypeCollectionWithReferencesRequestBuilder(), "BaseRequestBuilder", c.ITypeCollectionWithReferencesRequestBuilder())#>
1514

@@ -31,7 +30,7 @@ import java.util.Arrays;
3130
* @return the IUserRequest instance
3231
*/
3332
public <#=c.ITypeCollectionWithReferencesRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
34-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
33+
return buildRequest(getOptions(requestOptions));
3534
}
3635

3736
/**

Templates/Java/requests_extensions/BaseEntityReferenceRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
1111
import <#=importNamespace#>.http.BaseRequestBuilder;
1212
import <#=importNamespace#>.core.IBaseClient;
13-
import java.util.Arrays;
1413

1514
<#=TypeHelperJava.CreateClassDef(c.TypeReferenceRequestBuilder(), "BaseRequestBuilder", c.ITypeReferenceRequestBuilder())#>
1615

@@ -32,7 +31,7 @@ import java.util.Arrays;
3231
* @return The <#=c.ITypeReferenceRequest()#> instance
3332
*/
3433
public <#=c.ITypeReferenceRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
35-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
34+
return buildRequest(getOptions(requestOptions));
3635
}
3736

3837
/**

Templates/Java/requests_extensions/BaseEntityRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
99
import <#=importNamespace#>.core.IBaseClient;
1010
import <#=importNamespace#>.http.BaseRequestBuilder;
11-
import java.util.Arrays;
1211
<# var mainNamespace = host.CurrentNamespace(); #>
1312

1413
<#=TypeHelperJava.CreateClassDef(c.TypeRequestBuilder(), "BaseRequestBuilder", c.ITypeRequestBuilder())#>
@@ -31,7 +30,7 @@ import java.util.Arrays;
3130
* @return the <#=c.ITypeRequest()#> instance
3231
*/
3332
public <#=c.ITypeRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
34-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
33+
return buildRequest(getOptions(requestOptions));
3534
}
3635

3736
/**

Templates/Java/requests_extensions/BaseEntityStreamRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
99
import <#=importNamespace#>.core.IBaseClient;
1010
import <#=importNamespace#>.http.BaseRequestBuilder;
11-
import java.util.Arrays;
1211

1312
<#=TypeHelperJava.CreateClassDef(c.TypeStreamRequestBuilder(), "BaseRequestBuilder", c.ITypeStreamRequestBuilder())#>
1413

@@ -30,7 +29,7 @@ import java.util.Arrays;
3029
* @return the <#=c.ITypeStreamRequest()#> instance
3130
*/
3231
public <#=c.ITypeStreamRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
33-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
32+
return buildRequest(getOptions(requestOptions));
3433
}
3534

3635
/**

Templates/Java/requests_extensions/BaseEntityWithReferenceRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
<# var importNamespace = host.CurrentModel.GetNamespace().AddPrefix(); #>
1010
import <#=importNamespace#>.http.BaseRequestBuilder;
1111
import <#=importNamespace#>.core.IBaseClient;
12-
import java.util.Arrays;
1312

1413
<#=TypeHelperJava.CreateClassDef(c.TypeWithReferencesRequestBuilder(), "BaseRequestBuilder", c.ITypeWithReferencesRequestBuilder())#>
1514

@@ -31,7 +30,7 @@ import java.util.Arrays;
3130
* @return the <#=c.ITypeWithReferencesRequest()#> instance
3231
*/
3332
public <#=c.ITypeWithReferencesRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
34-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
33+
return buildRequest(getOptions(requestOptions));
3534
}
3635

3736
/**

Templates/Java/requests_extensions/BaseMethodCollectionRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import <#=mainNamespace#>.<#=TypeHelperJava.GetPrefixForRequests()#>.<#=c.TypeCo
1414
import <#=importNamespace#>.options.FunctionOption;
1515
import <#=importNamespace#>.core.IBaseClient;
1616
import <#=importNamespace#>.core.<#=c.GetMethodRequestBuilderSuperClass() #>;
17-
import java.util.Arrays;
1817

1918
<# bool isAction = !c.AsOdcmMethod().IsFunction; #>
2019
<#=TypeHelperJava.CreateClassDef(c.TypeCollectionRequestBuilder(), c.GetMethodRequestBuilderSuperClass(), c.ITypeCollectionRequestBuilder())#>
@@ -50,7 +49,7 @@ import java.util.Arrays;
5049
* @return the IUserRequest instance
5150
*/
5251
public <#=c.ITypeCollectionRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
53-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
52+
return buildRequest(getOptions(requestOptions));
5453
}
5554

5655
/**

Templates/Java/requests_extensions/BaseMethodRequestBuilder.java.tt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import <#=importNamespace#>.core.BaseActionRequestBuilder;
1010
import <#=importNamespace#>.core.BaseFunctionRequestBuilder;
1111
import <#=importNamespace#>.core.IBaseClient;
1212
import com.google.gson.JsonElement;
13-
import java.util.Arrays;
1413

1514
<# bool isAction = !c.AsOdcmMethod().IsFunction; #>
1615
<#=TypeHelperJava.CreateClassDef(c.TypeRequestBuilder(), c.GetMethodRequestBuilderSuperClass(), c.ITypeRequestBuilder())#>
@@ -42,7 +41,7 @@ import java.util.Arrays;
4241
* @return the <#=c.ITypeRequest()#> instance
4342
*/
4443
public <#=c.ITypeRequest()#> buildRequest(final com.microsoft.graph.options.Option... requestOptions) {
45-
return buildRequest(requestOptions != null && requestOptions.length > 0 ? Arrays.asList(requestOptions) : getOptions());
44+
return buildRequest(getOptions(requestOptions));
4645
}
4746

4847
/**

0 commit comments

Comments
 (0)