Fix fix-all actions showing up even on non-fixable errors

Author: mjbvz

e2e/project-fixture/tslint.json

@@ -4,6 +4,7 @@
             true,
             "array-simple"
         ],
+        "no-unused-expression": true,
         "arrow-parens": true,
         "no-var-keyword": true,
         "no-unused-variable": [

e2e/tests/codeFixes.test.js

@@ -19,7 +19,7 @@ function createServerForFile(fileContents) {
 
 /**
  * @param {*} server 
- * @param {{ startLine: number, startOffset: number, endLine: number, endOffset: number }} data
+ * @param {{ startLine: number, startOffset: number, endLine: number, endOffset: number, additionalErrorCodes?: number[] }} data
  */
 const getCodeFixes = async (server, data) => {
 
@@ -32,7 +32,7 @@ const getCodeFixes = async (server, data) => {
         startOffset: data.startOffset,
         endLine: data.endLine,
         endOffset: data.endOffset,
-        errorCodes: [1]
+        errorCodes: [1, ...(data.additionalErrorCodes || [])]
     });
 };
 
@@ -374,4 +374,24 @@ describe('CodeFixes', () => {
         assert.isTrue(codeFixesResponse.success);
         assert.deepEqual(codeFixesResponse.body, []);
     });
+
+    it('should not return TS Lint fix-all for non-fixable errors', async () => {
+        server = createServerForFile(
+            `const foo = 123; food`
+        );
+        await getCodeFixes(server, {
+            startLine: 1,
+            startOffset: 18,
+            endLine: 1,
+            endOffset: 22,
+            additionalErrorCodes: [2552]
+        });
+        await server.close();
+        const codeFixesResponse = await getFirstResponseOfType('getCodeFixes', server);
+
+        assert.isTrue(codeFixesResponse.success);
+        assert.deepEqual(codeFixesResponse.body.length, 2);
+        assert.deepEqual(codeFixesResponse.body[0].fixName, 'spelling');
+        assert.deepEqual(codeFixesResponse.body[1].fixName, 'tslint:disable:no-unused-expression');
+    });
 });

src/plugin.ts

@@ -212,10 +212,11 @@ export class TSLintPlugin {
                             codeFixAction.fixId = TsLintFixId.fromFailure(problem.failure);
                             codeFixAction.fixAllDescription = `Fix all '${problem.failure.getRuleName()}'`;
                         }
+
+                        fixes.push(this.getFixAllAutoFixableQuickFix(documentFixes, fileName));
                     }
                 }
 
-                fixes.push(this.getFixAllAutoFixableQuickFix(documentFixes, fileName));
                 fixes.push(this.getDisableRuleQuickFix(problem.failure, fileName, this.getProgram().getSourceFile(fileName)!));
             }
         }