Skip to content

Commit fa8ab58

Browse files
committed
fix: document bi-directionality of secret stores
1 parent 2ab8fe4 commit fa8ab58

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

chart/values.schema.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1897,7 +1897,7 @@
18971897
},
18981898
"stores": {
18991899
"$ref": "#/$defs/EnableSwitch",
1900-
"description": "Stores defines if secret stores should get synced from the virtual cluster to the host cluster."
1900+
"description": "Stores defines if secret stores should get synced from the virtual cluster to the host cluster and then bi-directionally."
19011901
},
19021902
"clusterStores": {
19031903
"$ref": "#/$defs/ClusterStoresSyncConfig",
@@ -2074,7 +2074,7 @@
20742074
},
20752075
"externalSecrets": {
20762076
"$ref": "#/$defs/ExternalSecrets",
2077-
"description": "ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.\n- ExternalSecrets will be synced from the virtual cluster to the host cluster.\n- SecretStores will be synced bi-directionally.\n- ClusterSecretStores will be synced from the host cluster to the virtual cluster."
2077+
"description": "ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.\n- ExternalSecrets will be synced from the virtual cluster to the host cluster.\n- SecretStores will be synced from the virtual cluster to the host cluster and then bi-directionally.\n- ClusterSecretStores will be synced from the host cluster to the virtual cluster."
20782078
},
20792079
"certManager": {
20802080
"$ref": "#/$defs/CertManager",

chart/values.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,7 @@ integrations:
749749

750750
# ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.
751751
# - ExternalSecrets will be synced from the virtual cluster to the host cluster.
752-
# - SecretStores will be synced bi-directionally.
752+
# - SecretStores will be synced from the virtual cluster to the host cluster and then bi-directionally.
753753
# - ClusterSecretStores will be synced from the host cluster to the virtual cluster.
754754
externalSecrets:
755755
# Enabled defines whether the external secret integration is enabled or not
@@ -762,7 +762,7 @@ integrations:
762762
# ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster.
763763
externalSecrets:
764764
enabled: true
765-
# Stores defines if secret stores should get synced from the virtual cluster to the host cluster.
765+
# Stores defines if secret stores should get synced from the virtual cluster to the host cluster and then bi-directionally.
766766
stores:
767767
enabled: false
768768
# ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster.

config/config.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ type Integrations struct {
9292

9393
// ExternalSecrets reuses a host external secret operator and makes certain CRDs from it available inside the vCluster.
9494
// - ExternalSecrets will be synced from the virtual cluster to the host cluster.
95-
// - SecretStores will be synced bi-directionally.
95+
// - SecretStores will be synced from the virtual cluster to the host cluster and then bi-directionally.
9696
// - ClusterSecretStores will be synced from the host cluster to the virtual cluster.
9797
ExternalSecrets ExternalSecrets `json:"externalSecrets,omitempty"`
9898

@@ -147,7 +147,7 @@ type ExternalSecrets struct {
147147
type ExternalSecretsSync struct {
148148
// ExternalSecrets defines if external secrets should get synced from the virtual cluster to the host cluster.
149149
ExternalSecrets EnableSwitch `json:"externalSecrets,omitempty"`
150-
// Stores defines if secret stores should get synced from the virtual cluster to the host cluster.
150+
// Stores defines if secret stores should get synced from the virtual cluster to the host cluster and then bi-directionally.
151151
Stores EnableSwitch `json:"stores,omitempty"`
152152
// ClusterStores defines if cluster secrets stores should get synced from the host cluster to the virtual cluster.
153153
ClusterStores ClusterStoresSyncConfig `json:"clusterStores,omitempty"`

0 commit comments

Comments
 (0)