Added tests for strict mode in models

rennokki · rennokki · commit 5ad221da658a · 2022-11-09T14:12:21.000+02:00
diff --git a/composer.json b/composer.json
@@ -20,8 +20,8 @@
         }
     ],
     "require": {
-        "illuminate/database": "^8.83|^9.0.1",
-        "illuminate/support": "^8.83|^9.0.1"
+        "illuminate/database": "^8.83|^9.35",
+        "illuminate/support": "^8.83|^9.35"
     },
     "autoload": {
         "psr-4": {
diff --git a/tests/CountTest.php b/tests/CountTest.php
@@ -7,6 +7,9 @@
 
 class CountTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_count()
     {
         $posts = factory(Post::class, 5)->create();
@@ -21,6 +24,9 @@ public function test_count()
         );
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_count_with_columns()
     {
         $posts = factory(Post::class, 5)->create();
diff --git a/tests/FirstTest.php b/tests/FirstTest.php
@@ -7,6 +7,9 @@
 
 class FirstTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_first()
     {
         $post = factory(Post::class)->create();
@@ -21,6 +24,9 @@ public function test_first()
         );
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_first_with_columns()
     {
         $post = factory(Post::class)->create();
diff --git a/tests/FlushCacheOnUpdatePivotTest.php b/tests/FlushCacheOnUpdatePivotTest.php
@@ -7,6 +7,9 @@
 
 class FlushCacheOnUpdatePivotTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_belongs_to_many()
     {
         $key = 'leqc:sqlitegetselect "roles".*, "role_user"."user_id" as "pivot_user_id", "role_user"."role_id" as "pivot_role_id" from "roles" inner join "role_user" on "roles"."id" = "role_user"."role_id" where "role_user"."user_id" = ? limit 1a:1:{i:0;i:1;}';
diff --git a/tests/FlushCacheOnUpdateTest.php b/tests/FlushCacheOnUpdateTest.php
@@ -6,6 +6,9 @@
 
 class FlushCacheOnUpdateTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_flush_cache_on_create()
     {
         $page = factory(Page::class)->create();
@@ -28,6 +31,9 @@ public function test_flush_cache_on_create()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_flush_cache_on_update()
     {
         $page = factory(Page::class)->create();
@@ -50,6 +56,9 @@ public function test_flush_cache_on_update()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_flush_cache_on_delete()
     {
         $page = factory(Page::class)->create();
@@ -70,6 +79,9 @@ public function test_flush_cache_on_delete()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_flush_cache_on_force_deletion()
     {
         $page = factory(Page::class)->create();
diff --git a/tests/GetTest.php b/tests/GetTest.php
@@ -7,6 +7,9 @@
 
 class GetTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_get()
     {
         $post = factory(Post::class)->create();
@@ -26,6 +29,9 @@ public function test_get()
         );
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_get_with_columns()
     {
         $post = factory(Post::class)->create();
@@ -45,6 +51,9 @@ public function test_get_with_columns()
         );
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_get_with_string_columns()
     {
         $post = factory(Post::class)->create();
diff --git a/tests/MethodsTest.php b/tests/MethodsTest.php
@@ -2,6 +2,7 @@
 
 namespace Rennokki\QueryCache\Test;
 
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Cache;
 use Rennokki\QueryCache\Test\Models\Book;
 use Rennokki\QueryCache\Test\Models\Kid;
@@ -10,6 +11,9 @@
 
 class MethodsTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_do_not_cache()
     {
         $post = factory(Post::class)->create();
@@ -23,6 +27,9 @@ public function test_do_not_cache()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_cache_prefix()
     {
         $post = factory(Post::class)->create();
@@ -32,6 +39,9 @@ public function test_cache_prefix()
         $this->assertNotNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_cache_tags()
     {
         $post = factory(Post::class)->create();
@@ -49,6 +59,9 @@ public function test_cache_tags()
         $this->assertNotNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_cache_flush_with_the_right_tag()
     {
         $post = factory(Post::class)->create();
@@ -63,6 +76,9 @@ public function test_cache_flush_with_the_right_tag()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_cache_flush_without_the_right_tag()
     {
         $post = factory(Post::class)->create();
@@ -83,6 +99,9 @@ public function test_cache_flush_without_the_right_tag()
             : $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_cache_flush_with_more_tags()
     {
         $post = factory(Post::class)->create();
@@ -101,6 +120,9 @@ public function test_cache_flush_with_more_tags()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_cache_flush_with_default_tags_attached()
     {
         $book = factory(Book::class)->create();
@@ -116,6 +138,9 @@ public function test_cache_flush_with_default_tags_attached()
         $this->assertNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_hashed_key()
     {
         $kid = factory(Kid::class)->create();
@@ -125,6 +150,9 @@ public function test_hashed_key()
         $this->assertNotNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_append_cache_tags()
     {
         $post = factory(Post::class)->create();
@@ -142,6 +170,9 @@ public function test_append_cache_tags()
         $this->assertNotNull($cache);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_multiple_append_cache_tags()
     {
         $post = factory(Post::class)->create();
@@ -150,6 +181,9 @@ public function test_multiple_append_cache_tags()
         $this->assertEquals($storedPostQuery->getQuery()->getCacheTags(), ['test', 'test2']);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_append_cache_tags_with_sub_query()
     {
         $user = factory(User::class)->create();
diff --git a/tests/PaginateTest.php b/tests/PaginateTest.php
@@ -7,6 +7,9 @@
 
 class PaginateTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_paginate()
     {
         $posts = factory(Post::class, 30)->create();
@@ -28,6 +31,9 @@ public function test_paginate()
         $this->assertEquals(1, $postsCache->first()->id);
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_paginate_with_columns()
     {
         $posts = factory(Post::class, 30)->create();
diff --git a/tests/SimplePaginateTest.php b/tests/SimplePaginateTest.php
@@ -2,11 +2,15 @@
 
 namespace Rennokki\QueryCache\Test;
 
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Cache;
 use Rennokki\QueryCache\Test\Models\Post;
 
 class SimplePaginateTest extends TestCase
 {
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_simple_paginate()
     {
         $posts = factory(Post::class, 30)->create();
@@ -26,6 +30,9 @@ public function test_simple_paginate()
         );
     }
 
+    /**
+     * @dataProvider strictModeContextProvider
+     */
     public function test_simple_paginate_with_columns()
     {
         $posts = factory(Post::class, 30)->create();
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -2,6 +2,7 @@
 
 namespace Rennokki\QueryCache\Test;
 
+use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Cache;
 use Orchestra\Testbench\TestCase as Orchestra;
 
@@ -14,6 +15,11 @@ public function setUp(): void
     {
         parent::setUp();
 
+        if ($this->getProvidedData()) {
+            [$strict] = $this->getProvidedData();
+            Model::preventAccessingMissingAttributes($strict);
+        }
+
         $this->resetDatabase();
         $this->clearCache();
 
@@ -91,6 +97,12 @@ protected function getCacheWithTags(string $key, $tags = null)
             : Cache::get($key);
     }
 
+    public function strictModeContextProvider(): iterable
+    {
+        yield [true];
+        yield [false];
+    }
+
     /**
      * Check if the current driver supports tags.
      *

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`
`8`	`8`	`class CountTest extends TestCase`
`9`	`9`	`{`
	`10`	`+ /**`
	`11`	`+ * @dataProvider strictModeContextProvider`
	`12`	`+ */`
`10`	`13`	`public function test_count()`
`11`	`14`	`{`
`12`	`15`	`$posts = factory(Post::class, 5)->create();`
`@@ -21,6 +24,9 @@ public function test_count()`
`21`	`24`	`);`
`22`	`25`	`}`
`23`	`26`
	`27`	`+ /**`
	`28`	`+ * @dataProvider strictModeContextProvider`
	`29`	`+ */`
`24`	`30`	`public function test_count_with_columns()`
`25`	`31`	`{`
`26`	`32`	`$posts = factory(Post::class, 5)->create();`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`
`8`	`8`	`class FirstTest extends TestCase`
`9`	`9`	`{`
	`10`	`+ /**`
	`11`	`+ * @dataProvider strictModeContextProvider`
	`12`	`+ */`
`10`	`13`	`public function test_first()`
`11`	`14`	`{`
`12`	`15`	`$post = factory(Post::class)->create();`
`@@ -21,6 +24,9 @@ public function test_first()`
`21`	`24`	`);`
`22`	`25`	`}`
`23`	`26`
	`27`	`+ /**`
	`28`	`+ * @dataProvider strictModeContextProvider`
	`29`	`+ */`
`24`	`30`	`public function test_first_with_columns()`
`25`	`31`	`{`
`26`	`32`	`$post = factory(Post::class)->create();`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`
`8`	`8`	`class FlushCacheOnUpdatePivotTest extends TestCase`
`9`	`9`	`{`
	`10`	`+ /**`
	`11`	`+ * @dataProvider strictModeContextProvider`
	`12`	`+ */`
`10`	`13`	`public function test_belongs_to_many()`
`11`	`14`	`{`
`12`	`15`	`$key = 'leqc:sqlitegetselect "roles".*, "role_user"."user_id" as "pivot_user_id", "role_user"."role_id" as "pivot_role_id" from "roles" inner join "role_user" on "roles"."id" = "role_user"."role_id" where "role_user"."user_id" = ? limit 1a:1:{i:0;i:1;}';`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,9 @@`
`6`	`6`
`7`	`7`	`class FlushCacheOnUpdateTest extends TestCase`
`8`	`8`	`{`
	`9`	`+ /**`
	`10`	`+ * @dataProvider strictModeContextProvider`
	`11`	`+ */`
`9`	`12`	`public function test_flush_cache_on_create()`
`10`	`13`	`{`
`11`	`14`	`$page = factory(Page::class)->create();`
`@@ -28,6 +31,9 @@ public function test_flush_cache_on_create()`
`28`	`31`	`$this->assertNull($cache);`
`29`	`32`	`}`
`30`	`33`
	`34`	`+ /**`
	`35`	`+ * @dataProvider strictModeContextProvider`
	`36`	`+ */`
`31`	`37`	`public function test_flush_cache_on_update()`
`32`	`38`	`{`
`33`	`39`	`$page = factory(Page::class)->create();`
`@@ -50,6 +56,9 @@ public function test_flush_cache_on_update()`
`50`	`56`	`$this->assertNull($cache);`
`51`	`57`	`}`
`52`	`58`
	`59`	`+ /**`
	`60`	`+ * @dataProvider strictModeContextProvider`
	`61`	`+ */`
`53`	`62`	`public function test_flush_cache_on_delete()`
`54`	`63`	`{`
`55`	`64`	`$page = factory(Page::class)->create();`
`@@ -70,6 +79,9 @@ public function test_flush_cache_on_delete()`
`70`	`79`	`$this->assertNull($cache);`
`71`	`80`	`}`
`72`	`81`
	`82`	`+ /**`
	`83`	`+ * @dataProvider strictModeContextProvider`
	`84`	`+ */`
`73`	`85`	`public function test_flush_cache_on_force_deletion()`
`74`	`86`	`{`
`75`	`87`	`$page = factory(Page::class)->create();`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`
`8`	`8`	`class GetTest extends TestCase`
`9`	`9`	`{`
	`10`	`+ /**`
	`11`	`+ * @dataProvider strictModeContextProvider`
	`12`	`+ */`
`10`	`13`	`public function test_get()`
`11`	`14`	`{`
`12`	`15`	`$post = factory(Post::class)->create();`
`@@ -26,6 +29,9 @@ public function test_get()`
`26`	`29`	`);`
`27`	`30`	`}`
`28`	`31`
	`32`	`+ /**`
	`33`	`+ * @dataProvider strictModeContextProvider`
	`34`	`+ */`
`29`	`35`	`public function test_get_with_columns()`
`30`	`36`	`{`
`31`	`37`	`$post = factory(Post::class)->create();`
`@@ -45,6 +51,9 @@ public function test_get_with_columns()`
`45`	`51`	`);`
`46`	`52`	`}`
`47`	`53`
	`54`	`+ /**`
	`55`	`+ * @dataProvider strictModeContextProvider`
	`56`	`+ */`
`48`	`57`	`public function test_get_with_string_columns()`
`49`	`58`	`{`
`50`	`59`	`$post = factory(Post::class)->create();`
Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace Rennokki\QueryCache\Test;`
`4`	`4`
	`5`	`+use Illuminate\Database\Eloquent\Model;`
`5`	`6`	`use Illuminate\Support\Facades\Cache;`
`6`	`7`	`use Rennokki\QueryCache\Test\Models\Book;`
`7`	`8`	`use Rennokki\QueryCache\Test\Models\Kid;`
`@@ -10,6 +11,9 @@`
`10`	`11`
`11`	`12`	`class MethodsTest extends TestCase`
`12`	`13`	`{`
	`14`	`+ /**`
	`15`	`+ * @dataProvider strictModeContextProvider`
	`16`	`+ */`
`13`	`17`	`public function test_do_not_cache()`
`14`	`18`	`{`
`15`	`19`	`$post = factory(Post::class)->create();`
`@@ -23,6 +27,9 @@ public function test_do_not_cache()`
`23`	`27`	`$this->assertNull($cache);`
`24`	`28`	`}`
`25`	`29`
	`30`	`+ /**`
	`31`	`+ * @dataProvider strictModeContextProvider`
	`32`	`+ */`
`26`	`33`	`public function test_cache_prefix()`
`27`	`34`	`{`
`28`	`35`	`$post = factory(Post::class)->create();`
`@@ -32,6 +39,9 @@ public function test_cache_prefix()`
`32`	`39`	`$this->assertNotNull($cache);`
`33`	`40`	`}`
`34`	`41`
	`42`	`+ /**`
	`43`	`+ * @dataProvider strictModeContextProvider`
	`44`	`+ */`
`35`	`45`	`public function test_cache_tags()`
`36`	`46`	`{`
`37`	`47`	`$post = factory(Post::class)->create();`
`@@ -49,6 +59,9 @@ public function test_cache_tags()`
`49`	`59`	`$this->assertNotNull($cache);`
`50`	`60`	`}`
`51`	`61`
	`62`	`+ /**`
	`63`	`+ * @dataProvider strictModeContextProvider`
	`64`	`+ */`
`52`	`65`	`public function test_cache_flush_with_the_right_tag()`
`53`	`66`	`{`
`54`	`67`	`$post = factory(Post::class)->create();`
`@@ -63,6 +76,9 @@ public function test_cache_flush_with_the_right_tag()`
`63`	`76`	`$this->assertNull($cache);`
`64`	`77`	`}`
`65`	`78`
	`79`	`+ /**`
	`80`	`+ * @dataProvider strictModeContextProvider`
	`81`	`+ */`
`66`	`82`	`public function test_cache_flush_without_the_right_tag()`
`67`	`83`	`{`
`68`	`84`	`$post = factory(Post::class)->create();`
`@@ -83,6 +99,9 @@ public function test_cache_flush_without_the_right_tag()`
`83`	`99`	`: $this->assertNull($cache);`
`84`	`100`	`}`
`85`	`101`
	`102`	`+ /**`
	`103`	`+ * @dataProvider strictModeContextProvider`
	`104`	`+ */`
`86`	`105`	`public function test_cache_flush_with_more_tags()`
`87`	`106`	`{`
`88`	`107`	`$post = factory(Post::class)->create();`
`@@ -101,6 +120,9 @@ public function test_cache_flush_with_more_tags()`
`101`	`120`	`$this->assertNull($cache);`
`102`	`121`	`}`
`103`	`122`
	`123`	`+ /**`
	`124`	`+ * @dataProvider strictModeContextProvider`
	`125`	`+ */`
`104`	`126`	`public function test_cache_flush_with_default_tags_attached()`
`105`	`127`	`{`
`106`	`128`	`$book = factory(Book::class)->create();`
`@@ -116,6 +138,9 @@ public function test_cache_flush_with_default_tags_attached()`
`116`	`138`	`$this->assertNull($cache);`
`117`	`139`	`}`
`118`	`140`
	`141`	`+ /**`
	`142`	`+ * @dataProvider strictModeContextProvider`
	`143`	`+ */`
`119`	`144`	`public function test_hashed_key()`
`120`	`145`	`{`
`121`	`146`	`$kid = factory(Kid::class)->create();`
`@@ -125,6 +150,9 @@ public function test_hashed_key()`
`125`	`150`	`$this->assertNotNull($cache);`
`126`	`151`	`}`
`127`	`152`
	`153`	`+ /**`
	`154`	`+ * @dataProvider strictModeContextProvider`
	`155`	`+ */`
`128`	`156`	`public function test_append_cache_tags()`
`129`	`157`	`{`
`130`	`158`	`$post = factory(Post::class)->create();`
`@@ -142,6 +170,9 @@ public function test_append_cache_tags()`
`142`	`170`	`$this->assertNotNull($cache);`
`143`	`171`	`}`
`144`	`172`
	`173`	`+ /**`
	`174`	`+ * @dataProvider strictModeContextProvider`
	`175`	`+ */`
`145`	`176`	`public function test_multiple_append_cache_tags()`
`146`	`177`	`{`
`147`	`178`	`$post = factory(Post::class)->create();`
`@@ -150,6 +181,9 @@ public function test_multiple_append_cache_tags()`
`150`	`181`	`$this->assertEquals($storedPostQuery->getQuery()->getCacheTags(), ['test', 'test2']);`
`151`	`182`	`}`
`152`	`183`
	`184`	`+ /**`
	`185`	`+ * @dataProvider strictModeContextProvider`
	`186`	`+ */`
`153`	`187`	`public function test_append_cache_tags_with_sub_query()`
`154`	`188`	`{`
`155`	`189`	`$user = factory(User::class)->create();`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@`
`7`	`7`
`8`	`8`	`class PaginateTest extends TestCase`
`9`	`9`	`{`
	`10`	`+ /**`
	`11`	`+ * @dataProvider strictModeContextProvider`
	`12`	`+ */`
`10`	`13`	`public function test_paginate()`
`11`	`14`	`{`
`12`	`15`	`$posts = factory(Post::class, 30)->create();`
`@@ -28,6 +31,9 @@ public function test_paginate()`
`28`	`31`	`$this->assertEquals(1, $postsCache->first()->id);`
`29`	`32`	`}`
`30`	`33`
	`34`	`+ /**`
	`35`	`+ * @dataProvider strictModeContextProvider`
	`36`	`+ */`
`31`	`37`	`public function test_paginate_with_columns()`
`32`	`38`	`{`
`33`	`39`	`$posts = factory(Post::class, 30)->create();`
Original file line number	Diff line number	Diff line change
`@@ -2,11 +2,15 @@`
`2`	`2`
`3`	`3`	`namespace Rennokki\QueryCache\Test;`
`4`	`4`
	`5`	`+use Illuminate\Database\Eloquent\Model;`
`5`	`6`	`use Illuminate\Support\Facades\Cache;`
`6`	`7`	`use Rennokki\QueryCache\Test\Models\Post;`
`7`	`8`
`8`	`9`	`class SimplePaginateTest extends TestCase`
`9`	`10`	`{`
	`11`	`+ /**`
	`12`	`+ * @dataProvider strictModeContextProvider`
	`13`	`+ */`
`10`	`14`	`public function test_simple_paginate()`
`11`	`15`	`{`
`12`	`16`	`$posts = factory(Post::class, 30)->create();`
`@@ -26,6 +30,9 @@ public function test_simple_paginate()`
`26`	`30`	`);`
`27`	`31`	`}`
`28`	`32`
	`33`	`+ /**`
	`34`	`+ * @dataProvider strictModeContextProvider`
	`35`	`+ */`
`29`	`36`	`public function test_simple_paginate_with_columns()`
`30`	`37`	`{`
`31`	`38`	`$posts = factory(Post::class, 30)->create();`