It seems to be wrong in algorithms/bit/binary_gap.py (#518)

* It seems to be wrong.

* It seems to be wrong.

* I haven't read all of them yet, so delete the test section to avoid mistakes in PR.

* back

* back

Author: One-Xiao-Yi

.travis.yml

@@ -11,7 +11,7 @@ matrix:
         - python: 3.6
           env: TOX_ENV=py36
         - python: 3.7
-          env: TOX_ENV=py37,coverage
+          env: TOX_ENV=py37
 install:
     - pip install -r test_requirements.txt
 before_script:

algorithms/arrays/move_zeros.py

@@ -8,15 +8,19 @@
 """
 
 
+# False == 0 is True
 def move_zeros(array):
     result = []
     zeros = 0
 
     for i in array:
-        if i == 0:  # not using `not i` to avoid `False`, `[]`, etc.
-            zeros += 1
-        else:
-            result.append(i)
+            if i == 0 and type(i) != bool:  # not using `not i` to avoid `False`, `[]`, etc.
+                zeros += 1
+            else:
+                result.append(i)
 
     result.extend([0] * zeros)
     return result
+
+
+print(move_zeros([False, 1, 0, 1, 2, 0, 1, 3, "a"]))

algorithms/bit/binary_gap.py

@@ -13,6 +13,14 @@
 The second consecutive pair of 1's have distance 1.
 The answer is the largest of these two distances, which is 2
 """
+
+
+# 原方法为 binary_gap，但通过实验发现算法有误，不论是什么数，输出值最多为2。
+# 改进方法为binary_gap_improved。
+# The original method is binary_gap,
+# but the experimental results show that the algorithm seems to be wrong,
+# regardless of the number, the output value is up to 2.
+# The improved method is binary_gap_improved.
 def binary_gap(N):
     last = None
     ans = 0
@@ -25,3 +33,25 @@ def binary_gap(N):
         index = index + 1
         N = N >> 1
     return ans
+
+
+def binary_gap_improved(N):
+    last = None
+    ans = 0
+    index = 0
+    while N != 0:
+        tes = N & 1
+        if tes:
+            if last is not None:
+                ans = max(ans, index - last + 1)
+            else:
+                last = index
+        else:
+            last = index + 1
+        index = index + 1
+        N = N >> 1
+    return ans
+
+
+print(binary_gap(111))
+print(binary_gap_improved(111))