Skip to content

Naming the module #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasPe opened this issue Apr 20, 2016 · 6 comments
Closed

Naming the module #4

ThomasPe opened this issue Apr 20, 2016 · 6 comments

Comments

@ThomasPe
Copy link

Currently the app refers to the module just as "builder".
Angular Schema Forms are called "schemaForm" and have a sf-abbreviation, so my the Builder would perhaps be "schemaFormBuilder" with an sfb-abbreviation?
@nicklasb
Copy link
Member

nicklasb commented Apr 20, 2016 •
edited
Loading

When you say sfb, I suppose you talk about the attributes of the directive?

<schemaFormBuilder sfb-model="model"></schemaFormBuilder>

@ThomasPe
Copy link
Author

yeah

@nicklasb
Copy link
Member

IMO, that sounds legit.
(an example is never wrong, you know)

@ThomasPe
Copy link
Author

sry bout that. its basically just what I've already posted here: #3

Just making sure I'm not screwing up the naming conventions.

@nicklasb
Copy link
Member

nicklasb commented Apr 20, 2016 •
edited
Loading

Oh, I meant nothing by that, just a hint.
Sorry, I realised I may have sounded a bit harsh.

It is good that you asked. Worst thing when people don't interact.

@ThomasPe
Copy link
Author

gotcha, no worries

@ThomasPe ThomasPe closed this as completed Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomasPe @nicklasb