Ensure opaque paths always roundtrip

Follows whatwg/url@6c78200.

Closes #293.

Author: domenic

README.md

@@ -4,7 +4,7 @@ whatwg-url is a full implementation of the WHATWG [URL Standard](https://url.spe
 
 ## Specification conformance
 
-whatwg-url is currently up to date with the URL spec up to commit [cfae7c4](https://github.com/whatwg/url/commit/cfae7c4ed1851886390e132fc336b653fada9123).
+whatwg-url is currently up to date with the URL spec up to commit [6c78200](https://github.com/whatwg/url/commit/6c782003a2d53b1feecd072d1006eb8f1d65fb2d).
 
 For `file:` URLs, whose [origin is left unspecified](https://url.spec.whatwg.org/#concept-url-origin), whatwg-url chooses to use a new opaque origin (which serializes to `"null"`).
 

lib/URL-impl.js

@@ -195,7 +195,6 @@ exports.implementation = class URLImpl {
     if (v === "") {
       url.query = null;
       this._query._list = [];
-      this._potentiallyStripTrailingSpacesFromAnOpaquePath();
       return;
     }
 
@@ -220,7 +219,6 @@ exports.implementation = class URLImpl {
   set hash(v) {
     if (v === "") {
       this._url.fragment = null;
-      this._potentiallyStripTrailingSpacesFromAnOpaquePath();
       return;
     }
 
@@ -232,20 +230,4 @@ exports.implementation = class URLImpl {
   toJSON() {
     return this.href;
   }
-
-  _potentiallyStripTrailingSpacesFromAnOpaquePath() {
-    if (!usm.hasAnOpaquePath(this._url)) {
-      return;
-    }
-
-    if (this._url.fragment !== null) {
-      return;
-    }
-
-    if (this._url.query !== null) {
-      return;
-    }
-
-    this._url.path = this._url.path.replace(/\u0020+$/u, "");
-  }
 };

lib/URLSearchParams-impl.js

@@ -37,10 +37,6 @@ exports.implementation = class URLSearchParamsImpl {
       }
 
       this._url._url.query = serializedQuery;
-
-      if (serializedQuery === null) {
-        this._url._potentiallyStripTrailingSpacesFromAnOpaquePath();
-      }
     }
   }
 

lib/url-state-machine.js

@@ -1060,6 +1060,13 @@ URLStateMachine.prototype["parse opaque path"] = function parseOpaquePath(c) {
   } else if (c === p("#")) {
     this.url.fragment = "";
     this.state = "fragment";
+  } else if (c === p(" ")) {
+    const remaining = this.input[this.pointer + 1];
+    if (remaining === p("?") || remaining === p("#")) {
+      this.url.path += "%20";
+    } else {
+      this.url.path += " ";
+    }
   } else {
     // TODO: Add: not a URL code point
     if (!isNaN(c) && c !== p("%")) {

scripts/get-latest-platform-tests.js

@@ -13,7 +13,7 @@ const path = require("path");
 // 1. Go to https://github.com/web-platform-tests/wpt/tree/master/url
 // 2. Press "y" on your keyboard to get a permalink
 // 3. Copy the commit hash
-const commitHash = "d86fcc9e8764155485975a2a9bbfc5ec4aa9e75b";
+const commitHash = "072413fba2fef3c16877673af78215174ca8f7c2";
 
 const urlPrefix = `https://raw.githubusercontent.com/web-platform-tests/wpt/${commitHash}/url/`;
 const targetDir = path.resolve(__dirname, "..", "test", "web-platform-tests");