Skip to content

Commit 8e8478b

Browse files
committed
Remove dead code in urlencoded serializer
It appears we were trying to special-case _charset_ and File objects, but I can find no evidence that anywhere in this codebase, or the jsdom codebase, we ever need this support. Part of #268.
1 parent 0dfbc79 commit 8e8478b

File tree

1 file changed

+3
-20
lines changed

1 file changed

+3
-20
lines changed

lib/urlencoded.js

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -43,30 +43,13 @@ function parseUrlencodedString(input) {
4343
}
4444

4545
// https://url.spec.whatwg.org/#concept-urlencoded-serializer
46-
function serializeUrlencoded(tuples, encodingOverride = undefined) {
47-
let encoding = "utf-8";
48-
if (encodingOverride !== undefined) {
49-
// TODO "get the output encoding", i.e. handle encoding labels vs. names.
50-
encoding = encodingOverride;
51-
}
46+
function serializeUrlencoded(tuples) {
47+
// TODO: accept and use encoding argument
5248

5349
let output = "";
5450
for (const [i, tuple] of tuples.entries()) {
55-
// TODO: handle encoding override
56-
5751
const name = utf8PercentEncodeString(tuple[0], isURLEncodedPercentEncode, true);
58-
59-
let value = tuple[1];
60-
if (tuple.length > 2 && tuple[2] !== undefined) {
61-
if (tuple[2] === "hidden" && name === "_charset_") {
62-
value = encoding;
63-
} else if (tuple[2] === "file") {
64-
// value is a File object
65-
value = value.name;
66-
}
67-
}
68-
69-
value = utf8PercentEncodeString(value, isURLEncodedPercentEncode, true);
52+
const value = utf8PercentEncodeString(tuple[1], isURLEncodedPercentEncode, true);
7053

7154
if (i !== 0) {
7255
output += "&";

0 commit comments

Comments
 (0)