Skip to content

add a Database#setRecycleBin(Group g) method #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorabin opened this issue May 11, 2023 · 1 comment
Open

add a Database#setRecycleBin(Group g) method #44

jorabin opened this issue May 11, 2023 · 1 comment

Comments

@jorabin
Copy link
Owner

jorabin commented May 11, 2023

as mentioned by @aivanovski in his pull request #34 this would allow people to programmatically assign a group as a recycle bin for reasons including those stated in the pull request, of some implementations not hooking the metadata together correctly.

There will need to be some thought as to what happens when there is already a recycle bin assigned, would be grateful for some views. Here's the JavaDoc on getRecycleBin() as it currently stands.

@giusvale-dev
Copy link
Contributor

KeePass2 creates a group (automatically) named "Recycle Bin" when an entry or a group is deleted.
Then a user can't create a Group and mark it as "Recycle Bin".

I think we need to maintain the compatibility of all implementations and existing applications of KeePass2!
You can't add this feature because if I export my KeePass2 database from this Java API to other KeePass applications (KeePass2 for Windows, KeePass XC, etc.) what happened? How do they interpret my deleted data?

I think could be wrong and maybe dangerous to implement this feature, so I suggest you close this issue because the current implementation of this API is compliant with the current implementation of the other KeePass projects!

Giuseppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants