This may be a contestable change. SqlDateTime can hold nulls, but .NET DateTime maps to SQL DATETIME2. I staged this in VS. Will fix to DateTime?

Author: jeffshumphreys@gmail.com

Humanization.cs

@@ -1,15 +1,20 @@
 using Microsoft.SqlServer.Server;
 using System;
+using System.Data.SqlTypes;
 
 namespace MySQLCLRFunctions
 {
     public static class Humanization
     {
+        /*
+         * This needs a lot more work.  And when do I use this? I need use cases.
+         */
         [SqlFunction(DataAccess = DataAccessKind.None)]
-        public static string HumanizeDateTimeDiff(DateTime from)
+        public static string HumanizeDateTimeDiff(SqlDateTime from)
         {
-            if (from == null) return null;
-            TimeSpan ts = DateTime.Now.Subtract(from);
+            if (from.IsNull) return null;
+
+            TimeSpan ts = DateTime.Now.Subtract(from.Value);
 
             // The trick: make variable contain date and time representing the desired timespan,
             // having +1 in each date component.
@@ -46,6 +51,5 @@ private static string ProcessPeriod(int value, int subValue, string name, string
                 ? String.Format("{0} {1}s ago", value, name)
                 : String.Format("About {0} {1}s ago", value, name);
         }
-
     }
 }

MySQLCLRFunctions.csproj

@@ -10,6 +10,7 @@
     <RootNamespace>MySQLCLRFunctions</RootNamespace>
     <AssemblyName>MySQLCLRFunctions</AssemblyName>
     <TargetFrameworkVersion>v4.8</TargetFrameworkVersion>
+    <LangVersion>8.0</LangVersion>
     <FileAlignment>512</FileAlignment>
     <Deterministic>true</Deterministic>
     <TargetFrameworkProfile />
@@ -51,13 +52,16 @@
     <Compile Include="Adaptors.cs" />
     <Compile Include="CharacterExtract.cs" />
     <Compile Include="CharacterTest.cs" />
+    <Compile Include="CharacterTransform.cs" />
     <Compile Include="Compares.cs" />
     <Compile Include="Environmental.cs" />
     <Compile Include="FileNameExtract.cs" />
     <Compile Include="Files.cs" />
+    <Compile Include="GlobalSuppressions.cs" />
     <Compile Include="Humanization.cs" />
     <Compile Include="NetworkCollect.cs" />
     <Compile Include="NetworkTest.cs" />
+    <Compile Include="_NewFunctionsToTry.cs" />
     <Compile Include="_SharedConstants.cs" />
     <Compile Include="StringBuildOut.cs" />
     <Compile Include="StringDecode.cs" />
@@ -71,11 +75,20 @@
     <Compile Include="StringTransformStripDownCustomizations.cs" />
     <Compile Include="StringTransformTSQLSpecific.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
+    <Compile Include="_VERIFY_CSHARP8.cs" />
   </ItemGroup>
   <ItemGroup>
+    <PackageReference Include="Microsoft.Net.Compilers.Toolset">
+      <Version>3.6.0</Version>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
     <PackageReference Include="NUnit">
       <Version>3.12.0</Version>
     </PackageReference>
+    <PackageReference Include="System.Collections">
+      <Version>4.3.0</Version>
+    </PackageReference>
   </ItemGroup>
   <ItemGroup>
     <None Include=".editorconfig" />

MySQLCLRFunctions.sln

@@ -8,6 +8,9 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{912B914B-FAA0-4CB8-B38C-202E9B9965ED}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
+		.gitattributes = .gitattributes
+		.gitignore = .gitignore
+		_config.yml = _config.yml
 		SQLCLR_Register.sql = SQLCLR_Register.sql
 		TestValueSettings.localuseonly = TestValueSettings.localuseonly
 	EndProjectSection

NetworkTest.cs

@@ -40,10 +40,7 @@ private static bool PingHost(string nameOrAddress)
             }
             finally
             {
-                if (pinger != null)
-                {
-                    pinger.Dispose();
-                }
+                pinger?.Dispose();
             }
 
             return pingable;

SQLCLR_Register.sql

@@ -13,11 +13,11 @@ public static class StringFormat
         * 
         **************************************************************************************************************************************************************************************/
         [SqlFunction(DataAccess = DataAccessKind.None, IsDeterministic = true, IsPrecise = true)]
-        public static string RPad(string input, int padToLen)
+        public static string RPad(string input, int length)
         {
-            if (StringTest.IsNullOrWhiteSpaceOrEmpty(input)) return input;
+            if (StringTest.IsNull(input)) return input;
 
-            return input.PadRight(padToLen);
+            return input.PadRight(length);
         }
 
         /***************************************************************************************************************************************************************************************************
@@ -26,11 +26,11 @@ public static string RPad(string input, int padToLen)
         * 
         **************************************************************************************************************************************************************************************/
         [SqlFunction(DataAccess = DataAccessKind.None, IsDeterministic = true, IsPrecise = true)]
-        public static string LPadChar(string input, int padToLen, char padCh)
+        public static string LPadC(string input, int length, char character)
         {
-            if (StringTest.IsNullOrWhiteSpaceOrEmpty(input)) return input;
+            if (StringTest.IsNull(input)) return input;
 
-            return input.PadLeft(padToLen, padCh);
+            return input.PadLeft(length, character);
         }
 
         /***************************************************************************************************************************************************************************************************
@@ -39,11 +39,11 @@ public static string LPadChar(string input, int padToLen, char padCh)
         * 
         **************************************************************************************************************************************************************************************/
         [SqlFunction(DataAccess = DataAccessKind.None, IsDeterministic = true, IsPrecise = true)]
-        public static string RPadChar(string input, int padToLen, char padCh)
+        public static string RPadChar(string input, int length, char character)
         {
-            if (StringTest.IsNullOrWhiteSpaceOrEmpty(input)) return input;
+            if (StringTest.IsNull(input)) return input;
 
-            return input.PadRight(padToLen, padCh);
+            return input.PadRight(length, character);
         }
 
         /***************************************************************************************************************************************************************************************************
@@ -52,11 +52,11 @@ public static string RPadChar(string input, int padToLen, char padCh)
         * 
         **************************************************************************************************************************************************************************************/
         [SqlFunction(DataAccess = DataAccessKind.None, IsDeterministic = true, IsPrecise = true)]
-        public static string LPad(string input, int padToLen)
+        public static string LPad(string input, int length)
         {
-            if (StringTest.IsNullOrWhiteSpaceOrEmpty(input)) return input;
+            if (StringTest.IsNull(input)) return input;
 
-            return input.PadLeft(padToLen);
+            return input.PadLeft(length);
         }
 
         /***************************************************************************************************************************************************************************************************
@@ -69,7 +69,7 @@ public static string Title(string input)
         {
             if (StringTest.IsNullOrWhiteSpaceOrEmpty(input)) return input;
 
-            return Regex.Replace(input.ToLower(), @"\b[a-z]\w+", delegate (Match match)
+            return Regex.Replace(input.ToLower(), @"\b[a-z]\w+", (Match match) =>
             {
                 string v = match.ToString();
                 return char.ToUpper(v[0]) + v.Substring(1);

StringExtract.cs

@@ -1,10 +1,14 @@
 using Microsoft.SqlServer.Server;
-using static MySQLCLRFunctions.StringTest;
 using System;
 using System.Text.RegularExpressions;
 using System.Data.SqlTypes;
+using static MySQLCLRFunctions.StringTest;
+using static MySQLCLRFunctions._SharedConstants;
+
 /*
 * Take measurements from a string.  Not actual values from a string as Extract does, and not a "changed" (immutable) string like Transform or Pivot, or Format, Reduce.
+* 
+* WARNING SqlDateTime is not the same as datetime.  SqlDateTime maps to DATETIME, DateTime maps to DATETIME2
 */
 namespace MySQLCLRFunctions
 {
@@ -18,7 +22,6 @@ public static class StringMeasure
         [SqlFunction(DataAccess = DataAccessKind.None, IsDeterministic = true, IsPrecise = true)]
         public static SqlInt32 HowManyS(string input, string marker)
         {
-            // General Rule: Follow SQL rules around null
             if (IsNull(input) || IsNull(marker)) return SqlInt32.Null;
             if (IsEmpty(marker)) throw new ArgumentOutOfRangeException("Empty strings would result in infinite loop.");
             if (IsEmpty(input)) return 0;