You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OpenAPI yaml has uniqueItems: true in several places where lists of things are accepted/returned.
I don't know if it's too late in the day for this spec, but this field causes the TypeScript generator to use Sets for everything which it then can't serialize/deserialize properly because they have no JSON representation.
Can we remove this field? It breaks code generation and if it's important, it could be in a validation layer instead of the serialisation layer.
The text was updated successfully, but these errors were encountered:
Yes, as long we relax API, should be fine to do this, especially if it makes code generation easier for new users. Old ones probably will never re-generate, as this spec is kinda in purgatory – good enough for ipfs-desktop, but not useful beyond that, and adoption is a mixed bag.
If still relevant, submit a PR – to accept it + tag a patch release.
The OpenAPI yaml has
uniqueItems: true
in several places where lists of things are accepted/returned.I don't know if it's too late in the day for this spec, but this field causes the TypeScript generator to use
Set
s for everything which it then can't serialize/deserialize properly because they have no JSON representation.Can we remove this field? It breaks code generation and if it's important, it could be in a validation layer instead of the serialisation layer.
The text was updated successfully, but these errors were encountered: