Skip to content

Commit 6e686ad

Browse files
committed
fix: disable loadable popup due to issues && enrich loadable view capabilities
1 parent c4ea0a1 commit 6e686ad

File tree

3 files changed

+199
-193
lines changed

3 files changed

+199
-193
lines changed

lib/async/loadable_view.dart

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,20 @@ class LoadableView extends StatelessWidget {
88

99
final bool isLoading;
1010
final kSize3 loadingIndicatorSize;
11+
final bool justOverlay;
1112
final bool maintainState;
13+
final StackFit stackFit;
1214
final Widget child;
1315

1416
const LoadableView({
1517
super.key,
1618
required this.isLoading,
1719
this.loadingIndicatorSize = kSize3.M,
20+
this.justOverlay = false,
1821
this.maintainState = true,
22+
this.stackFit = StackFit.loose,
1923
required this.child,
20-
});
24+
}) : assert(!(justOverlay && !maintainState));
2125

2226
@override
2327
Widget build(BuildContext context)
@@ -37,10 +41,11 @@ class LoadableView extends StatelessWidget {
3741
}
3842

3943
return Stack(
44+
fit: stackFit,
4045
children: [
4146

4247
Visibility(
43-
visible: !isLoading,
48+
visible: !isLoading || justOverlay,
4449
maintainState: true,
4550
maintainAnimation: true,
4651
maintainSize: true,

lib/async/loading_overlay.dart

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22

33
part of devspace;
44

5+
// Note: this is buggy and cases issues on some android devices
6+
// class LoadingOverlay extends StatelessWidget
7+
// {
8+
// final bool show;
9+
// final Widget child;
510

6-
class LoadingOverlay extends StatelessWidget
7-
{
8-
final bool show;
9-
final Widget child;
11+
// const LoadingOverlay({
12+
// super.key,
13+
// required this.show,
14+
// required this.child,
15+
// });
1016

11-
const LoadingOverlay({
12-
super.key,
13-
required this.show,
14-
required this.child,
15-
});
16-
17-
@override
18-
Widget build(BuildContext context)
19-
{
20-
return DialogControlWidget(
21-
show: show,
22-
dialogBarrierDismissible: false,
23-
dialogBuilder: (context)
24-
{
25-
return Center(
26-
child: ArchLoadingIndicator(),
27-
);
28-
},
29-
child: child,
30-
);
31-
}
32-
}
17+
// @override
18+
// Widget build(BuildContext context)
19+
// {
20+
// return DialogControlWidget(
21+
// show: show,
22+
// dialogBarrierDismissible: false,
23+
// dialogBuilder: (context)
24+
// {
25+
// return Center(
26+
// child: ArchLoadingIndicator(),
27+
// );
28+
// },
29+
// child: child,
30+
// );
31+
// }
32+
// }

0 commit comments

Comments
 (0)