BUG/MINOR: fix incorrect old DefaultBackend name in Reload log

hdurand0710 · hdurand0710 · commit 312a9ec1e063 · 2024-05-21T13:48:03.000+02:00
diff --git a/pkg/service/service.go b/pkg/service/service.go
@@ -240,12 +240,13 @@ func (s *Service) SetDefaultBackend(k store.K8s, h haproxy.HAProxy, frontends []
 	if frontend.DefaultBackend != backendName {
 		for _, frontendName := range frontends {
 			frontend, _ := h.FrontendGet(frontendName)
+			oldDefaultBackend := frontend.DefaultBackend
 			frontend.DefaultBackend = backendName
 			err = h.FrontendEdit(frontend)
 			if err != nil {
 				return
 			}
-			instance.Reload("default backend changed in frontend '%s': from '%s' to '%s'", frontendName, frontend.DefaultBackend, backendName)
+			instance.Reload("default backend changed in frontend '%s': from '%s' to '%s'", frontendName, oldDefaultBackend, backendName)
 		}
 	}
 	s.HandleHAProxySrvs(k, h)

Original file line number	Diff line number	Diff line change
`@@ -240,12 +240,13 @@ func (s *Service) SetDefaultBackend(k store.K8s, h haproxy.HAProxy, frontends []`
`240`	`240`	`if frontend.DefaultBackend != backendName {`
`241`	`241`	`for _, frontendName := range frontends {`
`242`	`242`	`frontend, _ := h.FrontendGet(frontendName)`
	`243`	`+ oldDefaultBackend := frontend.DefaultBackend`
`243`	`244`	`frontend.DefaultBackend = backendName`
`244`	`245`	`err = h.FrontendEdit(frontend)`
`245`	`246`	`if err != nil {`
`246`	`247`	`return`
`247`	`248`	`}`
`248`		`- instance.Reload("default backend changed in frontend '%s': from '%s' to '%s'", frontendName, frontend.DefaultBackend, backendName)`
	`249`	`+ instance.Reload("default backend changed in frontend '%s': from '%s' to '%s'", frontendName, oldDefaultBackend, backendName)`
`249`	`250`	`}`
`250`	`251`	`}`
`251`	`252`	`s.HandleHAProxySrvs(k, h)`