Skip to content

update_generation_config.yaml is not updated in downstream repos #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
diegomarquezp opened this issue Mar 13, 2025 · 2 comments
Closed

update_generation_config.yaml is not updated in downstream repos #3701

diegomarquezp opened this issue Mar 13, 2025 · 2 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@diegomarquezp
Copy link
Contributor

Downstream repos don't update this file. For example:

This may extend to other files in the .github folder
@diegomarquezp diegomarquezp added hermetic-build type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 13, 2025
This was referenced Mar 14, 2025
Closed
Merged
@JoeWang1127 JoeWang1127 mentioned this issue Mar 20, 2025
Merged
@diegomarquezp
Copy link
Contributor Author

cc: @JoeWang1127 @suztomo
I noticed that https://github.com/googleapis/sdk-platform-java/blob/main/hermetic_build/library_generation/owlbot/templates/java_library/.kokoro/build.sh is very different from https://github.com/googleapis/java-logging/blob/main/.kokoro/build.sh. Same story with java-bigtable. The different JOB_TYPE handling is not present in this template.

Java-logging still expects build.sh to be updated automatically.

diegomarquezp added a commit that referenced this issue Mar 24, 2025
@diegomarquezp
chore: update lint workflow template to use Java 17
00ca224 
This PR follows from googleapis/java-shared-config#1003, which updated google-java-format to the latest and is now [requiring](https://github.com/google/google-java-format/releases/tag/v1.25.0) Java 17.

Note that this template will not be spread until #3701, but the changes will be done to prevent regressions when it's fixed.
This was referenced Mar 24, 2025
Open
Closed
Merged
diegomarquezp added a commit that referenced this issue Apr 7, 2025
@diegomarquezp
chore(hermetic-build): include .github template updates as part of ge…
1c0841f 
…neration (#3723)

Part of the fix for
#3701 ☕

### Approach
The templates come from
https://github.com/googleapis/synthtool/tree/bf182cd41d9a7de56092cafcc7befe6b398332f6.
The only update was to include `generated-files-bot`, which is already
up to date in all the HW repos.

The `.kokoro` folder will be a separate follow up task. We will now
focus on solving the update of `update_generation_config` `yaml` and
`sh` files.

The fix to include the `.github` folder follows from
https://setuptools.pypa.io/en/latest/userguide/datafiles.html:
```
Glob patterns do not automatically match dotfiles, i.e., directory or file names starting with a dot (.).
To include such files, you must explicitly start the pattern with a dot, e.g. .* to match .gitignore.
```


Interestingly, this is also the reason `cp
synthool/gcp/templates/java_library/* ...` did not bring folders
starting with dot (such as .kokoro) into
#2884
### Confirming effects in downstream repos
Demos show the results as of
b66af92
in
 - googleapis/java-storage#3012
 - googleapis/java-logging#1787
 - googleapis/java-pubsub#2384
 - googleapis/java-bigtable#2546
 - googleapis/java-spanner#3711
 - googleapis/java-firestore#2065
 - googleapis/java-datastore#1810
 - googleapis/java-bigquerystorage#2929
 - googleapis/java-pubsublite#1837

There were no regressions on templated files that were manually
modified.
@diegomarquezp
Copy link
Contributor Author

Fixed in #3723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diegomarquezp