Skip to content

Downstream check should include changes from the generator #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blakeli0 opened this issue Apr 24, 2024 · 5 comments
Open

Downstream check should include changes from the generator #2685

blakeli0 opened this issue Apr 24, 2024 · 5 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@blakeli0
Copy link
Collaborator

blakeli0 commented Apr 24, 2024

We currently have downstream check that validates any changes in Gax or shared dependencies would not break downstream(java-bigtable etc.) libraries. However, it does not include changes from the generator, which caused the downstream libraries to fail. It happened recently for bigtable in the generator update PR.
It was not possible to do so in the past due to BazelBot and Owlbot are not in this repo. Now that we have hermetic build, we can test downstream libraries with changes from the generator as well.

@blakeli0
Copy link
Collaborator Author

@lqiu96 Feel free to add more info.
cc: @JoeWang1127 @diegomarquezp

@zhumin8 zhumin8 added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 25, 2024
@diegomarquezp
Copy link
Contributor

@blakeli0 does this involve downstream checks for changes in the hermetic_build/ folder?

@JoeWang1127
Copy link
Collaborator

@blakeli0 does this involve downstream checks for changes in the hermetic_build/ folder?

I believe so as I consider hermetic build is part of the generator.

@blakeli0
Copy link
Collaborator Author

@blakeli0 does this involve downstream checks for changes in the hermetic_build/ folder?

I believe so as I consider hermetic build is part of the generator.

Agreed. If we are going to add downstream check for the GAPIC generator, we probably only need to re-build the image to test the changes in the hermetic_build/ folder.

@diegomarquezp
Copy link
Contributor

Ok, thanks @blakeli0 @JoeWang1127.

I'm then giving this a +1 to avoid toil from manual testing such as what I did with HW repos in #3723 (it may be a rather special case but still checks out IMO)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

4 participants