Skip to content

Commit cf14319

Browse files
ccmtaylorseankhliao
authored andcommitted
oauth2: fix expiration time window check
Before CL 68017, the test verified that tokens expire exactly one day after they are issued, within the time that Exchange() takes to execute. A refactoring in the CL extended this time window to a whole day, making the check much more lenient. See: https://go-review.googlesource.com/c/oauth2/+/168017 Change-Id: I479db429f64b25a711624817c13f068b4675163e Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/630495 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Junyang Shao <shaojunyang@google.com> Reviewed-by: Sean Liao <sean@liao.dev> Auto-Submit: Sean Liao <sean@liao.dev> Reviewed-by: Carlos Amedee <carlos@golang.org>
1 parent 32d34ef commit cf14319

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

oauth2_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ func testExchangeRequest_JSONResponse_expiry(t *testing.T, exp string, want, nul
300300
conf := newConf(ts.URL)
301301
t1 := time.Now().Add(day)
302302
tok, err := conf.Exchange(context.Background(), "exchange-code")
303-
t2 := t1.Add(day)
303+
t2 := time.Now().Add(day)
304304

305305
if got := (err == nil); got != want {
306306
if want {

0 commit comments

Comments
 (0)