WIP

Author: fmeum

src/os/signal/signal.go

@@ -168,8 +168,8 @@ func Notify(c chan<- os.Signal, sig ...os.Signal) {
 	}
 }
 
-// Reset undoes the effect of any prior calls to [Notify] for the provided
-// signals.
+// Reset undoes the effect of any prior calls to [Notify] or [Ignore] for the
+// provided signals.
 // If no signals are provided, all signal handlers will be reset.
 func Reset(sig ...os.Signal) {
 	cancel(sig, disableSignal)

src/os/signal/signal_test.go

@@ -347,6 +347,8 @@ func TestStop(t *testing.T) {
 	for _, sig := range sigs {
 		sig := sig
 		t.Run(fmt.Sprint(sig), func(t *testing.T) {
+			defer Reset(sig)
+
 			// When calling Notify with a specific signal,
 			// independent signals should not interfere with each other,
 			// and we end up needing to wait for signals to quiesce a lot.

src/runtime/os3_plan9.go

@@ -149,7 +149,8 @@ Exit:
 func sigenable(sig uint32) {
 }
 
-func sigdisable(sig uint32) {
+func sigdisable(sig uint32) bool {
+	return false
 }
 
 func sigignore(sig uint32) {

src/runtime/os_wasm.go

@@ -142,7 +142,7 @@ func getfp() uintptr { return 0 }
 
 func setProcessCPUProfiler(hz int32) {}
 func setThreadCPUProfiler(hz int32)  {}
-func sigdisable(uint32)              {}
+func sigdisable(uint32) bool         { return false }
 func sigenable(uint32)               {}
 func sigignore(uint32)               {}
 

src/runtime/signal_unix.go

@@ -211,14 +211,14 @@ func sigenable(sig uint32) {
 // sigdisable disables the Go signal handler for the signal sig.
 // It is only called while holding the os/signal.handlers lock,
 // via os/signal.disableSignal and signal_disable.
-func sigdisable(sig uint32) {
+func sigdisable(sig uint32) bool {
 	if sig >= uint32(len(sigtable)) {
-		return
+		return false
 	}
 
 	// SIGPROF is handled specially for profiling.
 	if sig == _SIGPROF {
-		return
+		return false
 	}
 
 	t := &sigtable[sig]
@@ -230,11 +230,20 @@ func sigdisable(sig uint32) {
 		// If initsig does not install a signal handler for a
 		// signal, then to go back to the state before Notify
 		// we should remove the one we installed.
-		if !sigInstallGoHandler(sig) {
+		if sigInstallGoHandler(sig) {
+			if atomic.Cas(&handlingSig[sig], 0, 1) {
+				atomic.Storeuintptr(&fwdSig[sig], getsig(sig))
+				setsig(sig, abi.FuncPCABIInternal(sighandler))
+			}
+			return false
+		} else {
 			atomic.Store(&handlingSig[sig], 0)
-			setsig(sig, atomic.Loaduintptr(&fwdSig[sig]))
+			fs := atomic.Loaduintptr(&fwdSig[sig])
+			setsig(sig, fs)
+			return fs == _SIG_IGN
 		}
 	}
+	return false
 }
 
 // sigignore ignores the signal sig.

src/runtime/signal_windows.go

@@ -434,7 +434,8 @@ func initsig(preinit bool) {
 func sigenable(sig uint32) {
 }
 
-func sigdisable(sig uint32) {
+func sigdisable(sig uint32) bool {
+	return false
 }
 
 func sigignore(sig uint32) {

src/runtime/sigqueue.go

@@ -230,11 +230,19 @@ func signal_disable(s uint32) {
 	if s >= uint32(len(sig.wanted)*32) {
 		return
 	}
-	sigdisable(s)
+	ignored := sigdisable(s)
 
 	w := sig.wanted[s/32]
 	w &^= 1 << (s & 31)
 	atomic.Store(&sig.wanted[s/32], w)
+
+	i := sig.ignored[s/32]
+	if ignored {
+		i |= 1 << (s & 31)
+	} else {
+		i &^= 1 << (s & 31)
+	}
+	atomic.Store(&sig.ignored[s/32], i)
 }
 
 // Must only be called from a single goroutine at a time.