Fix empty IN/NOT IN conditions

ethantkoenig · ethantkoenig · commit 043186300e9b · 2017-05-18T17:58:56.000-04:00
diff --git a/cond_in.go b/cond_in.go
@@ -23,10 +23,8 @@ func In(col string, values ...interface{}) Cond {
 }
 
 func (condIn condIn) handleBlank(w Writer) error {
-	if _, err := fmt.Fprintf(w, "%s IN ()", condIn.col); err != nil {
-		return err
-	}
-	return nil
+	_, err := fmt.Fprint(w, "0=1")
+	return err
 }
 
 func (condIn condIn) WriteTo(w Writer) error {
diff --git a/cond_notin.go b/cond_notin.go
@@ -20,10 +20,8 @@ func NotIn(col string, values ...interface{}) Cond {
 }
 
 func (condNotIn condNotIn) handleBlank(w Writer) error {
-	if _, err := fmt.Fprintf(w, "%s NOT IN ()", condNotIn.col); err != nil {
-		return err
-	}
-	return nil
+	_, err := fmt.Fprint(w, "0=0")
+	return err
 }
 
 func (condNotIn condNotIn) WriteTo(w Writer) error {

Original file line number	Diff line number	Diff line change
`@@ -23,10 +23,8 @@ func In(col string, values ...interface{}) Cond {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`func (condIn condIn) handleBlank(w Writer) error {`
`26`		`- if _, err := fmt.Fprintf(w, "%s IN ()", condIn.col); err != nil {`
`27`		`- return err`
`28`		`- }`
`29`		`- return nil`
	`26`	`+ _, err := fmt.Fprint(w, "0=1")`
	`27`	`+ return err`
`30`	`28`	`}`
`31`	`29`
`32`	`30`	`func (condIn condIn) WriteTo(w Writer) error {`
Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,8 @@ func NotIn(col string, values ...interface{}) Cond {`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`func (condNotIn condNotIn) handleBlank(w Writer) error {`
`23`		`- if _, err := fmt.Fprintf(w, "%s NOT IN ()", condNotIn.col); err != nil {`
`24`		`- return err`
`25`		`- }`
`26`		`- return nil`
	`23`	`+ _, err := fmt.Fprint(w, "0=0")`
	`24`	`+ return err`
`27`	`25`	`}`
`28`	`26`
`29`	`27`	`func (condNotIn condNotIn) WriteTo(w Writer) error {`