Skip to content

Commit 3cf2227

Browse files
committed
🐛 Lint fix
Signed-off-by: kaynetik <aleksandar@nesovic.dev>
1 parent 316fdd6 commit 3cf2227

File tree

1 file changed

+24
-18
lines changed

1 file changed

+24
-18
lines changed

routing_test.go

+24-18
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ func TestUnitGetRegisteredRoutes(t *testing.T) {
4848
v := rand.Intn(1000-1) + 1 //nolint:gosec //ignored in tests.
4949
regRoutes := fetchRegRoutes(t, v)
5050

51-
tests := []struct {
51+
type st struct {
5252
name string
5353
fields fields
5454
want RegRoutes
55-
}{
55+
}
56+
57+
tests := []st{
5658
{
5759
name: "success getting registered routes",
5860
fields: fields{
@@ -61,15 +63,17 @@ func TestUnitGetRegisteredRoutes(t *testing.T) {
6163
want: regRoutes,
6264
},
6365
}
64-
for _, tt := range tests { //nolint:paralleltest //ignore.
65-
t.Run(tt.name, func(t *testing.T) {
66+
for _, tt := range tests {
67+
stin := tt
68+
69+
t.Run(stin.name, func(t *testing.T) {
6670
t.Parallel()
6771

6872
o := &OAS{
69-
RegisteredRoutes: tt.fields.registeredRoutes,
73+
RegisteredRoutes: stin.fields.registeredRoutes,
7074
}
7175
got := o.GetRegisteredRoutes()
72-
want := tt.want
76+
want := stin.want
7377

7478
if !reflect.DeepEqual(got, want) {
7579
t.Errorf("GetRegisteredRoutes() = %v, want %v", got, want)
@@ -86,6 +90,12 @@ func TestUnitGetPathByIndex(t *testing.T) {
8690
registeredRoutes RegRoutes
8791
}
8892

93+
type st struct {
94+
name string
95+
fields fields
96+
want *Path
97+
}
98+
8999
paths := Paths{
90100
Path{
91101
Route: "/test",
@@ -96,11 +106,7 @@ func TestUnitGetPathByIndex(t *testing.T) {
96106
v := rand.Intn(1000-1) + 1 //nolint:gosec //ignored in tests.
97107
regRoutes := fetchRegRoutes(t, v)
98108

99-
tests := []struct {
100-
name string
101-
fields fields
102-
want *Path
103-
}{
109+
tests := []st{
104110
{
105111
name: "success get paths",
106112
fields: fields{
@@ -110,17 +116,17 @@ func TestUnitGetPathByIndex(t *testing.T) {
110116
want: &paths[0],
111117
},
112118
}
113-
for _, tt := range tests { //nolint:paralleltest //Range statement for test TestUnitGetPathByIndex
114-
// does not reinitialise the variable tt -> TODO: Troubleshoot this further
115-
t.Run(tt.name, func(t *testing.T) {
119+
for _, tt := range tests {
120+
stin := tt
121+
t.Run(stin.name, func(t *testing.T) {
116122
t.Parallel()
117123

118124
o := &OAS{
119-
Paths: tt.fields.Paths,
120-
RegisteredRoutes: tt.fields.registeredRoutes,
125+
Paths: stin.fields.Paths,
126+
RegisteredRoutes: stin.fields.registeredRoutes,
121127
}
122-
if got := o.GetPathByIndex(0); !reflect.DeepEqual(got, tt.want) {
123-
t.Errorf("GetPathByIndex() = %v, want %v", got, tt.want)
128+
if got := o.GetPathByIndex(0); !reflect.DeepEqual(got, stin.want) {
129+
t.Errorf("GetPathByIndex() = %v, want %v", got, stin.want)
124130
}
125131
})
126132
}

0 commit comments

Comments
 (0)