Skip to content
This repository was archived by the owner on Nov 28, 2024. It is now read-only.

Commit c55e3fb

Browse files
committed
Merge pull request #26 from zcalusic/v2
Fix MIME-Version header field case
2 parents 5bc5c8b + 2449c75 commit c55e3fb

File tree

4 files changed

+9
-4
lines changed

4 files changed

+9
-4
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).
99
- #12: Adds `SendError` to provide additional info about the cause and index of
1010
a failed attempt to transmit a batch of messages.
1111

12+
### Fixed
13+
14+
- #26: Fixes RFC 1341 compliance by properly capitalizing the
15+
`MIME-Version` header.
16+
1217
## [2.2.0] - 2018-03-01
1318

1419
### Added

message_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ func stubSendMail(t *testing.T, bCount int, want *message) SendFunc {
657657
t.Error(err)
658658
}
659659
got := buf.String()
660-
wantMsg := string("Mime-Version: 1.0\r\n" +
660+
wantMsg := string("MIME-Version: 1.0\r\n" +
661661
"Date: Wed, 25 Jun 2014 17:46:00 +0000\r\n" +
662662
want.content)
663663
if bCount > 0 {

send_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const (
1515
testBody = "Test message"
1616
testMsg = "To: " + testTo1 + ", " + testTo2 + "\r\n" +
1717
"From: " + testFrom + "\r\n" +
18-
"Mime-Version: 1.0\r\n" +
18+
"MIME-Version: 1.0\r\n" +
1919
"Date: Wed, 25 Jun 2014 17:46:00 +0000\r\n" +
2020
"Content-Type: text/plain; charset=UTF-8\r\n" +
2121
"Content-Transfer-Encoding: quoted-printable\r\n" +

writeto.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ func (m *Message) WriteTo(w io.Writer) (int64, error) {
1919
}
2020

2121
func (w *messageWriter) writeMessage(m *Message) {
22-
if _, ok := m.header["Mime-Version"]; !ok {
23-
w.writeString("Mime-Version: 1.0\r\n")
22+
if _, ok := m.header["MIME-Version"]; !ok {
23+
w.writeString("MIME-Version: 1.0\r\n")
2424
}
2525
if _, ok := m.header["Date"]; !ok {
2626
w.writeHeader("Date", m.FormatDate(now()))

0 commit comments

Comments
 (0)