Change the priorities of the RequestListener and SubRequestListener listeners (#414)

Author: ste93cry

CHANGELOG.md

@@ -16,6 +16,7 @@
 - [BC BREAK] Remove the `monolog` configuration option. Instead, register the service manually (#406)
 - [BC BREAK] Remove the `listener_priorities` configuration option. Instead, use a compiler pass to change the priority of the listeners (#407)
 - Prefer usage of the existing `Symfony\Bridge\PsrHttpMessage\HttpMessageFactoryInterface` service for the `RequestFetcher` class (#409)
+- [BC BREAK] Change the priorities of the `RequestListener` and `SubRequestListener` listeners (#414)
 
 ## 3.5.3 (2020-10-13)
 

UPGRADE-4.0.md

@@ -77,6 +77,10 @@
 - Changed the priority of the `ConsoleCommandListener::handleConsoleErrorEvent` listener to `-64`.
 - Changed the priority of the `ConsoleCommandListener::::handleConsoleCommandEvent` listener to `128`.
 - Changed the priority of the `MessengerListener::handleWorkerMessageFailedEvent` listener to `50`.
+- Changed the priority of the `RequestListener::handleKernelRequestEvent` listener to `5`.
+- Changed the priority of the `RequestListener::handleKernelControllerEvent` listener to `10`.
+- Changed the priority of the `SubRequestListener::handleKernelRequestEvent` listener to `3`.
+- Changed the priority of the `SubRequestListener::handleKernelFinishRequestEvent` listener to `5`.
 - Changed the type of the `sentry.options.before_send` configuration option from `scalar` to `string`. The value must always be the name of the container service to call without the `@` prefix.
 
   Before

src/Resources/config/services.xml

@@ -41,15 +41,15 @@
             <argument type="service" id="Sentry\State\HubInterface" />
             <argument type="service" id="security.token_storage" on-invalid="ignore" />
 
-            <tag name="kernel.event_listener" event="kernel.request" method="handleKernelRequestEvent" priority="1" />
-            <tag name="kernel.event_listener" event="kernel.controller" method="handleKernelControllerEvent" priority="1" />
+            <tag name="kernel.event_listener" event="kernel.request" method="handleKernelRequestEvent" priority="5" />
+            <tag name="kernel.event_listener" event="kernel.controller" method="handleKernelControllerEvent" priority="10" />
         </service>
 
         <service id="Sentry\SentryBundle\EventListener\SubRequestListener" class="Sentry\SentryBundle\EventListener\SubRequestListener">
             <argument type="service" id="Sentry\State\HubInterface" />
 
-            <tag name="kernel.event_listener" event="kernel.request" method="handleKernelRequestEvent" priority="1" />
-            <tag name="kernel.event_listener" event="kernel.finish_request" method="handleKernelFinishRequestEvent" priority="1" />
+            <tag name="kernel.event_listener" event="kernel.request" method="handleKernelRequestEvent" priority="3" />
+            <tag name="kernel.event_listener" event="kernel.finish_request" method="handleKernelFinishRequestEvent" priority="5" />
         </service>
 
         <service id="Sentry\SentryBundle\EventListener\MessengerListener" class="Sentry\SentryBundle\EventListener\MessengerListener">

tests/DependencyInjection/SentryExtensionTest.php

@@ -125,12 +125,12 @@ public function testRequestListener(): void
                 [
                     'event' => KernelEvents::REQUEST,
                     'method' => 'handleKernelRequestEvent',
-                    'priority' => 1,
+                    'priority' => 5,
                 ],
                 [
                     'event' => KernelEvents::CONTROLLER,
                     'method' => 'handleKernelControllerEvent',
-                    'priority' => 1,
+                    'priority' => 10,
                 ],
             ],
         ], $definition->getTags());
@@ -147,12 +147,12 @@ public function testSubRequestListener(): void
                 [
                     'event' => KernelEvents::REQUEST,
                     'method' => 'handleKernelRequestEvent',
-                    'priority' => 1,
+                    'priority' => 3,
                 ],
                 [
                     'event' => KernelEvents::FINISH_REQUEST,
                     'method' => 'handleKernelFinishRequestEvent',
-                    'priority' => 1,
+                    'priority' => 5,
                 ],
             ],
         ], $definition->getTags());