Skip to content

Commit 83a7319

Browse files
committed
More work on ICU in CI
1 parent de210ce commit 83a7319

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/test.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,12 @@ jobs:
6464
echo "CC=gcc-${{ matrix.version }}" >> $GITHUB_ENV
6565
echo "CXX=g++-${{ matrix.version }}" >> $GITHUB_ENV
6666
fi
67+
68+
sudo apt-get install -y libicu-dev
6769
fi
6870
if [[ '${{ matrix.os }}' == macos-* ]]; then
69-
echo "DEVELOPER_DIR=/Applications/Xcode_${{ matrix.version }}.app" >> $GITHUB_ENV
71+
brew install icu4c
72+
echo "DEVELOPER_DIR=/Applications/Xcode_${{ matrix.version }}.app" >> $GITHUB_ENV
7073
fi
7174
7275
- name: Configure

test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ if (${CMAKE_SYSTEM_NAME} STREQUAL Android)
123123
endif()
124124

125125
set(LIB_TYPES " ")
126-
if (ICU_UC_FOUND)
126+
if (ICU_FOUND AND ICU_UC_FOUND)
127127
list(APPEND LIB_TYPES _headers)
128128
endif()
129129

0 commit comments

Comments
 (0)