Skip to content

Asset database version #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ringa-tech opened this issue Dec 3, 2020 · 3 comments
Open

Asset database version #2

ringa-tech opened this issue Dec 3, 2020 · 3 comments

Comments

@ringa-tech
Copy link

Hi, first of all thanks for this project... thread mgmt in Unity is a pain in the a** while working with AI.

The project was done using a pre-release version, so Unity's "recommended release" version doesn't work. Not that big of a deal, just wanted to ask if this was done for a specific reason.

Another thing is, when I open it with Unity 2020.2.0b14 (instead of b6) it's currently asking about migrating the Asset database to version 2. ¿do you think migrating could create an issue?

I did the migration and seemed to have no problem, just wanted to check if I wouldn't bump into a weird obscure bug down the road.

Thanks again. Will be doing some testing, I'll let you know if my computer explodes.

@flo-wolf
Copy link
Owner

flo-wolf commented Dec 6, 2020

There really shouldn't be any issues. I only used the pre-release version because I wanted to test out training ArticulationBodies, which are currently only available in the pre-release. But code-wise there are no deprecations between those versions, everything should run smoothly no matter what 2020 version is used.

@ringa-tech
Copy link
Author

Thank you!

Quick question:

For my purposes I modified the code a bit so that, if I set something like "30" for the "TrialDuration" variable, sometimes all my units are already dead since second 3 (especially at first when they're just messing around).

So I set up a bool variable in the NeatSupervisor that I can set with my own logic (e.g. EndEarly).

Then in CoroutinedListEvaluator, instead of the "WaitForSeconds(TrialDuration)" I instead do smaller "waits", checking in between if the "EndEarly" flag was set. If so, then I stop waiting. If not, then the max waiting time will be "TrialDuration".

Saved me a lot of time during testing.
Would you be interested in a Pull Request with that?

Thank you.

@flo-wolf
Copy link
Owner

Sure, that sounds like a good feature!

There are a few other changes I made but didn't push yet, they will come in the next few weeks. Biggest one is probably that I moved the Network Input and Output Counts from the NeatSupervisor to the UnitController, that way different Unit Prefabs with different UnitControllers (and potentially different input and output sizes) can just be plugged into the NeatSupervisor, without having to change the input/output size manually in the NeatSupervisor after switching Units.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants