FaunaClient no longer needs to be closed

Author: sprsquish

README.md

@@ -86,8 +86,6 @@ public class Main {
                 Obj("name", Value("my-first-database"))
             )
         ).get();
-
-        adminClient.close();
     }
 }
 ```
@@ -188,8 +186,6 @@ object Main extends App {
   )
 
   Await.result(result, Duration.Inf)
-
-  client.close()
 }
 ```
 

docs/SpellExample.java

@@ -61,18 +61,14 @@ public static void main(String[] args) throws Exception {
 
         String key = keyResults.at("secret").to(String.class).get();
 
-        //Create the client query in a try-with-resources to ensure it gets closed
-        //Because a Fauna Client implements AutoCloseable it will be closed when the try block finishes
-        try (FaunaClient client = adminClient.newSessionClient(key)) {
-            System.out.println("Connected to Fauna database " + DB_NAME + " with server role\n");
-            runSpellExamples(DB_NAME, client);
-        }
+        FaunaClient client = adminClient.newSessionClient(key)
+        System.out.println("Connected to Fauna database " + DB_NAME + " with server role\n");
+        runSpellExamples(DB_NAME, client);
 
         /*
-         * Delete the database and close the admin connection
+         * Delete the database
          */
         deleteDB(adminClient, DB_NAME);
-        adminClient.close();
         System.out.println("Disconnected from FaunaDB as Admin!");
     }
 

docs/SpellExample.scala

@@ -61,20 +61,13 @@ object SpellExample  {
     val key: String = keyResults("secret").to[String].get
     val client = adminClient.sessionClient(key)
 
-    try
-    {
-      println(s"Connected to Fauna database $DB_NAME with server role\n")
-      runSpellExamples(DB_NAME, client)
-    }
-    finally  {
-      client.close()
-    }
+    println(s"Connected to Fauna database $DB_NAME with server role\n")
+    runSpellExamples(DB_NAME, client)
 
     /*
-     * Just to keep things neat and tidy, delete the database and close the client connection
+     * Just to keep things neat and tidy, delete the database
      */
     deleteDB(adminClient, DB_NAME)
-    adminClient.close()
     println("Disconnected from FaunaDB as Admin!")
   }
 

faunadb-common/src/main/java/com/faunadb/common/Connection.java

@@ -231,8 +231,7 @@ private Connection(URL faunaRoot, String authToken, HttpClient client, MetricReg
 
   /**
    * Creates a new {@link Connection} sharing its underneath I/O resources. Queries submitted to a
-   * session connection will be authenticated with the token provided. Close the parent Connection
-   * for freeing up any resources held by the parent connection and this session connection.
+   * session connection will be authenticated with the token provided.
    *
    * @param authToken the token or key to be used to authenticate requests to the new {@link Connection}
    * @return a new {@link Connection}

faunadb-java/src/main/java/com/faunadb/client/FaunaClient.java

@@ -160,9 +160,7 @@ private FaunaClient(Connection connection) {
 
   /**
    * Creates a session client with the user secret provided. Queries submitted to a session client will be
-   * authenticated with the secret provided. A session client shares its parent's {@link Connection} instance
-   * and thus it does not need be closed after its usage. Close the parent session for freeing up any
-   * resources held by the parent session and this session client.
+   * authenticated with the secret provided. A session client shares its parent's {@link Connection} instance.
    *
    * @param secret user secret for the session client
    * @return a new {@link FaunaClient}

faunadb-scala/src/main/scala/faunadb/FaunaClient.scala

@@ -254,8 +254,7 @@ class FaunaClient private (connection: Connection) {
   /**
     * Creates a new scope to execute session queries. Queries submitted within the session scope will be
     * authenticated with the secret provided. A session client shares its parent's [[com.faunadb.common.Connection]]
-    * instance and thus it does not need to be closed after its usage. Close the parent session for freeing up any
-    * resources held by the parent session and this session client.
+    * instance.
     *
     * @param secret user secret for the session scope
     * @param session a function that receives a session client
@@ -268,8 +267,7 @@ class FaunaClient private (connection: Connection) {
 
   /**
     * Create a new session client. The returned session client shares its parent [[com.faunadb.common.Connection]]
-    * instance and thus it does not need to be closed after its usage. Close the parent session for freeing up any
-    * resources held by the parent session and this session client.
+    * instance.
     *
     * @param secret user secret for the session client
     * @return a new session client